Crash when hovering asset category in geometry nodes add menu #104952

New Issue

Dvorakir · 2023-02-19T15:15:28+01:00

Dvorakir commented

2023-02-19 15:15:28 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-18 05:38, hash: 46e13cf8a529
Worked: 3.4.1

Short description of error
Hovering over the menu entry for an asset category in the geometry nodes add menu can show wrong entries or crash blender.

This is a bug that I've only been able to reproduce with a small test asset library and the asset library imported via the Poly Haven Assets Add-on and with custom asset library attached below

Exact steps for others to reproduce the error

Download the attached test asset library and extract somewhere
Add the "test asset" folder as an asset library file path
Create a new geometry node group modifier on the default cube
Hover over the "Hair" menu entries several times

The menu might show a random (shader) node group or blender will crash outright.

If the crash does not happen, it might happen after restarting blender, as it seems to have something to do with loading assets in the geometry node editor

Test Asset

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-18 05:38, hash: `46e13cf8a529` Worked: 3.4.1 **Short description of error** Hovering over the menu entry for an asset category in the geometry nodes add menu can show wrong entries or crash blender. This is a bug that I've only been able to reproduce with a small test asset library and the asset library imported via the [Poly Haven Assets Add-on](https://github.com/Poly-Haven/polyhavenassets) and with custom asset library attached below **Exact steps for others to reproduce the error** 1. Download the attached test asset library and extract somewhere 2. Add the "test asset" folder as an asset library file path 3. Create a new geometry node group modifier on the default cube 4. Hover over the "Hair" menu entries several times The menu might show a random (shader) node group or blender will crash outright. If the crash does not happen, it might happen after restarting blender, as it seems to have something to do with loading assets in the geometry node editor [Test Asset](https://projects.blender.org/attachments/09929e02-71c3-4326-8506-829ee97291a0) ![Image](https://projects.blender.org/attachments/c2431e38-27c4-4b63-be6b-0780fc28210f)

image.png

65 KiB

image.png

11 KiB

image.png

11 KiB

test asset library.zip

648 KiB

image.png

13 KiB

blender.crash.txt

22 KiB

Dvorakir added the

labels 2023-02-19 15:15:28 +01:00

Sun Kim referenced this issue

2023-02-20 13:59:27 +01:00

Crash when accessing hair nodes assets in Geometry Nodes editor #104782

Adrian Sausenthaler commented

2023-02-20 20:05:18 +01:00

Probably a related crash.

Freshly build from git on Arch Linux.

"Segfault" when hovering GN "Add" menu:

Terminal output:

terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string: construction from null is not valid
Abgebrochen (Speicherabzug geschrieben)

Bug is at least 5 days old.

Probably a related crash. Freshly build from git on Arch Linux. "Segfault" when hovering GN "Add" menu: ![image](/attachments/c9365d97-c7cc-4be1-834c-32a3707cc254) Terminal output: ``` terminate called after throwing an instance of 'std::logic_error' what(): basic_string: construction from null is not valid Abgebrochen (Speicherabzug geschrieben) ``` Bug is at least 5 days old.

image.png

351 KiB

Pratik Borhade commented

2023-02-21 07:30:29 +01:00

Hi, looks same as #104782, so closing this ticket.
Feel free to comment if there is misunderstanding.
Thanks for the report.

Hi, looks same as #104782, so closing this ticket. Feel free to comment if there is misunderstanding. Thanks for the report.

Pratik Borhade closed this issue

2023-02-21 07:30:31 +01:00

Pratik Borhade added

and removed

labels 2023-02-21 07:30:39 +01:00

Dvorakir commented

2023-03-07 15:41:20 +01:00

Since #104782 was closed for missing steps to reproduce, I'm reopening this issue.

I'm still having the crash happen in the latest 3.5 beta, and now that the essentials library is included with blender, it is even easier to reproduce:

add the poly haven asset library to blender (refer to the original post for how to download it)
add a new geometry node group to the default cube
open the add menu and go in and out of the Hair library a few times

I've included a video that shows the crash

Since #104782 was closed for missing steps to reproduce, I'm reopening this issue. I'm still having the crash happen in the latest 3.5 beta, and now that the essentials library is included with blender, it is even easier to reproduce: 1. add the poly haven asset library to blender (refer to the original post for how to download it) 2. add a new geometry node group to the default cube 3. open the add menu and go in and out of the Hair library a few times I've included a video that shows the crash

blender_2023-03-07_15-33-59.mp4

1.1 MiB

blender.crash.txt

24 KiB

Dvorakir reopened this issue

2023-03-07 15:41:22 +01:00

Blender Bot added

and removed

labels 2023-03-07 15:41:22 +01:00

Pratik Borhade commented

2023-03-08 16:57:48 +01:00

Hi, thanks for reopening.

Use the add-on to fetch the poly haven library (will be about 2-5 GB when fully downloaded)

Though downloading 2-5 GB of assets is not very reliable way for reproducing the bug.
cc @mano-wii

Hi, thanks for reopening. > Use the add-on to fetch the poly haven library (will be about 2-5 GB when fully downloaded) Though downloading 2-5 GB of assets is not very reliable way for reproducing the bug. cc @mano-wii

Dvorakir commented

2023-03-08 17:46:54 +01:00

Someone in the other report suggested it might happen when asset libraries get very large, so I did some testing and found that I can reproduce it even with a simple asset library consisting of the default blend file (containing assets) copied many many times.

With 1196 blend files in the asset library (the same number as the polyhaven library), i could easily reproduce the crash, but I also tested with 523 files and it would sometimes crash and other times show the wrong entries:

I've attached the 523-file asset library

Someone in the other report suggested it might happen when asset libraries get very large, so I did some testing and found that I can reproduce it even with a simple asset library consisting of the default blend file (containing assets) copied many many times. With 1196 blend files in the asset library (the same number as the polyhaven library), i could easily reproduce the crash, but I also tested with 523 files and it would sometimes crash and other times show the wrong entries: ![image](/attachments/c2431e38-27c4-4b63-be6b-0780fc28210f) I've attached the 523-file asset library

big asset.zip

58 MiB

image.png

36 KiB

Pratik Borhade commented

2023-03-09 02:11:44 +01:00

Thanks. I can now replicate the crash locally.

>	blender.exe!blender::asset_system::AssetRepresentation::get_name() Line 72	C++
 	blender.exe!AS_asset_representation_name_get(const AssetRepresentation * asset_handle) Line 145	C++
 	blender.exe!ED_asset_handle_get_name(const AssetHandle * asset) Line 23	C++
 	blender.exe!blender::ed::space_node::node_add_catalog_assets_draw(const bContext * C, Menu * menu) Line 190	C++
 	blender.exe!UI_menutype_draw(bContext * C, MenuType * mt, uiLayout * layout) Line 5905	C++
 	blender.exe!ui_item_menutype_func(bContext * C, uiLayout * layout, void * arg_mt) Line 2964	C++
 	blender.exe!ui_popup_menu_create::__l2::<lambda_1>::operator()(bContext * C, uiLayout * layout) Line 437	C++
 	[External Code]	
 	blender.exe!ui_block_func_POPUP(bContext * C, uiPopupBlockHandle * handle, void * arg_pup) Line 230	C++
 	blender.exe!ui_popup_block_refresh(bContext * C, uiPopupBlockHandle * handle, ARegion * butregion, uiBut * but) Line 566	C++
 	blender.exe!ui_popup_block_create(bContext * C, ARegion * butregion, uiBut * but, uiBlock *(*)(bContext *, ARegion *, void *) create_func, uiBlock *(*)(bContext *, uiPopupBlockHandle *, void *) handle_create_func, void * arg, void(*)(void *) arg_free) Line 796	C++
 	blender.exe!ui_popup_menu_create(bContext * C, ARegion * butregion, uiBut * but, const char * title, std::function<void __cdecl(bContext *,uiLayout *)> menu_func) Line 418	C++
 	blender.exe!ui_popup_menu_create(bContext * C, ARegion * butregion, uiBut * but, void(*)(bContext *, uiLayout *, void *) menu_func, void * arg) Line 438	C++
 	blender.exe!ui_block_open_begin(bContext * C, uiBut * but, uiHandleButtonData * data) Line 4246	C++
 	blender.exe!button_activate_state(bContext * C, uiBut * but, uiHandleButtonState state) Line 8359	C++
 	blender.exe!ui_handle_button_event(bContext * C, const wmEvent * event, uiBut * but) Line 9192	C++
 	blender.exe!ui_handle_menu_button(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu) Line 10110	C++
 	blender.exe!ui_handle_menu_event(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 10753	C++
 	blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11244	C++
 	blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11191	C++
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11470	C++
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 808	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3297	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3414	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Line 4015	C++
 	blender.exe!WM_main(bContext * C) Line 644	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 588	C

Thanks. I can now replicate the crash locally. ```lines=10 > blender.exe!blender::asset_system::AssetRepresentation::get_name() Line 72 C++ blender.exe!AS_asset_representation_name_get(const AssetRepresentation * asset_handle) Line 145 C++ blender.exe!ED_asset_handle_get_name(const AssetHandle * asset) Line 23 C++ blender.exe!blender::ed::space_node::node_add_catalog_assets_draw(const bContext * C, Menu * menu) Line 190 C++ blender.exe!UI_menutype_draw(bContext * C, MenuType * mt, uiLayout * layout) Line 5905 C++ blender.exe!ui_item_menutype_func(bContext * C, uiLayout * layout, void * arg_mt) Line 2964 C++ blender.exe!ui_popup_menu_create::__l2::<lambda_1>::operator()(bContext * C, uiLayout * layout) Line 437 C++ [External Code] blender.exe!ui_block_func_POPUP(bContext * C, uiPopupBlockHandle * handle, void * arg_pup) Line 230 C++ blender.exe!ui_popup_block_refresh(bContext * C, uiPopupBlockHandle * handle, ARegion * butregion, uiBut * but) Line 566 C++ blender.exe!ui_popup_block_create(bContext * C, ARegion * butregion, uiBut * but, uiBlock *(*)(bContext *, ARegion *, void *) create_func, uiBlock *(*)(bContext *, uiPopupBlockHandle *, void *) handle_create_func, void * arg, void(*)(void *) arg_free) Line 796 C++ blender.exe!ui_popup_menu_create(bContext * C, ARegion * butregion, uiBut * but, const char * title, std::function<void __cdecl(bContext *,uiLayout *)> menu_func) Line 418 C++ blender.exe!ui_popup_menu_create(bContext * C, ARegion * butregion, uiBut * but, void(*)(bContext *, uiLayout *, void *) menu_func, void * arg) Line 438 C++ blender.exe!ui_block_open_begin(bContext * C, uiBut * but, uiHandleButtonData * data) Line 4246 C++ blender.exe!button_activate_state(bContext * C, uiBut * but, uiHandleButtonState state) Line 8359 C++ blender.exe!ui_handle_button_event(bContext * C, const wmEvent * event, uiBut * but) Line 9192 C++ blender.exe!ui_handle_menu_button(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu) Line 10110 C++ blender.exe!ui_handle_menu_event(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 10753 C++ blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11244 C++ blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11191 C++ blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11470 C++ blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 808 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3297 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3414 C++ blender.exe!wm_event_do_handlers(bContext * C) Line 4015 C++ blender.exe!WM_main(bContext * C) Line 644 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 588 C ```

Pratik Borhade added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when hovering asset category in geometry nodes add menu #104952