Link drag search does not show results for node-groups #104975

New Issue

Closed

opened 2023-02-20 15:45:26 +01:00 by Simon Thommes · 8 comments

Simon Thommes commented

2023-02-20 15:45:26 +01:00

Member

System Information
Operating system: Linux-5.17.15-76051715-generic-x86_64-with-glibc2.35 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.48.07

Blender Version
Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-20 11:56, hash: 5fd4d47206ff
Also broken in main
Worked: never (?)

Short description of error
Link drag search does not show results for built-in essentials node-groups
Video attached below

Exact steps for others to reproduce the error

search for one of the builtin hair node-group assets via link drag search

**System Information** Operating system: Linux-5.17.15-76051715-generic-x86_64-with-glibc2.35 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.48.07 **Blender Version** Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-20 11:56, hash: `5fd4d47206ff` Also broken in main Worked: never (?) **Short description of error** Link drag search does not show results for built-in essentials node-groups Video attached below **Exact steps for others to reproduce the error** - search for one of the builtin hair node-group assets via link drag search

bug_node_groups_link_drag_search-2023-02-20_15.42.53.mp4

1.4 MiB

Iliya Katushenock commented

2023-02-20 15:47:33 +01:00

Member

You attach really big video...? I can't open/download that

You attach really big video...? I can't open/download that

Simon Thommes commented

2023-02-20 16:05:28 +01:00

Author

Member

it's 1.3MB on disk, guess it's an issue with the format, I'll ask around

it's 1.3MB on disk, guess it's an issue with the format, I'll ask around

Simon Thommes commented

2023-02-20 16:09:12 +01:00

Author

Member

Seems like the file was corrupt on my end, I replaced the upload. Not sure how to recreate the reference in the post's body. But the link below should be fine.

Seems like the file was corrupt on my end, I replaced the upload. Not sure how to recreate the reference in the post's body. But the link below should be fine.

Hans Goudey added the

Pipeline, Assets & IO

Nodes & Physics

labels 2023-02-20 21:59:35 +01:00

Hans Goudey added this to the 3.5 milestone 2023-02-20 21:59:42 +01:00

Hans Goudey commented

2023-02-20 22:26:07 +01:00

Member

@JulianEisel Hey, this is how I'd expect to get the essentials in link-drag search, but it gives me an assert in find_custom_asset_library_from_library_ref. Do you think that makes sense? BTW, this doesn't use the "all" library you refactored the add-node search to use because of the skip_local thing. That could definitely be handled differently. Curious about your opinion on that.

diff --git a/source/blender/editors/space_node/link_drag_search.cc b/source/blender/editors/space_node/link_drag_search.cc
index 73be1a58a86..9e2dbacbb44 100644
--- a/source/blender/editors/space_node/link_drag_search.cc
+++ b/source/blender/editors/space_node/link_drag_search.cc
@@ -253,11 +253,20 @@ static void gather_search_link_ops_for_all_assets(const bContext &C,
         C, node_tree, socket, library_ref, true, search_link_ops);
   }
 
-  AssetLibraryReference library_ref{};
-  library_ref.custom_library_index = -1;
-  library_ref.type = ASSET_LIBRARY_LOCAL;
-  gather_search_link_ops_for_asset_library(
-      C, node_tree, socket, library_ref, false, search_link_ops);
+  {
+    AssetLibraryReference library_ref{};
+    library_ref.custom_library_index = -1;
+    library_ref.type = ASSET_LIBRARY_LOCAL;
+    gather_search_link_ops_for_asset_library(
+        C, node_tree, socket, library_ref, false, search_link_ops);
+  }
+  {
+    AssetLibraryReference library_ref{};
+    library_ref.custom_library_index = -1;
+    library_ref.type = ASSET_LIBRARY_ESSENTIALS;
+    gather_search_link_ops_for_asset_library(
+        C, node_tree, socket, library_ref, false, search_link_ops);
+  }
 }
 
 /**

@JulianEisel Hey, this is how I'd expect to get the essentials in link-drag search, but it gives me an assert in `find_custom_asset_library_from_library_ref`. Do you think that makes sense? BTW, this doesn't use the "all" library you refactored the add-node search to use because of the `skip_local` thing. That could definitely be handled differently. Curious about your opinion on that. ``` diff --git a/source/blender/editors/space_node/link_drag_search.cc b/source/blender/editors/space_node/link_drag_search.cc index 73be1a58a86..9e2dbacbb44 100644 --- a/source/blender/editors/space_node/link_drag_search.cc +++ b/source/blender/editors/space_node/link_drag_search.cc @@ -253,11 +253,20 @@ static void gather_search_link_ops_for_all_assets(const bContext &C, C, node_tree, socket, library_ref, true, search_link_ops); } - AssetLibraryReference library_ref{}; - library_ref.custom_library_index = -1; - library_ref.type = ASSET_LIBRARY_LOCAL; - gather_search_link_ops_for_asset_library( - C, node_tree, socket, library_ref, false, search_link_ops); + { + AssetLibraryReference library_ref{}; + library_ref.custom_library_index = -1; + library_ref.type = ASSET_LIBRARY_LOCAL; + gather_search_link_ops_for_asset_library( + C, node_tree, socket, library_ref, false, search_link_ops); + } + { + AssetLibraryReference library_ref{}; + library_ref.custom_library_index = -1; + library_ref.type = ASSET_LIBRARY_ESSENTIALS; + gather_search_link_ops_for_asset_library( + C, node_tree, socket, library_ref, false, search_link_ops); + } } /** ```

Julian Eisel commented

2023-02-21 03:16:42 +01:00

Member

This bit seems to be missing:

diff --git a/source/blender/asset_system/intern/asset_library_service.cc b/source/blender/asset_system/intern/asset_library_service.cc
index cf52f9d1d76..45d8264e926 100644
--- a/source/blender/asset_system/intern/asset_library_service.cc
+++ b/source/blender/asset_system/intern/asset_library_service.cc
@@ -215,6 +215,10 @@ std::string AssetLibraryService::root_path_from_library_ref(
     return "";
   }
 
+  if (ELEM(library_reference.type, ASSET_LIBRARY_ESSENTIALS)) {
+    return essentials_directory_path();
+  }
+
   bUserAssetLibrary *custom_library = find_custom_asset_library_from_library_ref(
       library_reference);
   if (!custom_library || !custom_library->path[0]) {

(Eventually this kind of information should be stored in the asset library itself, so we don't have to hardcode behavior for different library types.)

This bit seems to be missing: ```diff diff --git a/source/blender/asset_system/intern/asset_library_service.cc b/source/blender/asset_system/intern/asset_library_service.cc index cf52f9d1d76..45d8264e926 100644 --- a/source/blender/asset_system/intern/asset_library_service.cc +++ b/source/blender/asset_system/intern/asset_library_service.cc @@ -215,6 +215,10 @@ std::string AssetLibraryService::root_path_from_library_ref( return ""; } + if (ELEM(library_reference.type, ASSET_LIBRARY_ESSENTIALS)) { + return essentials_directory_path(); + } + bUserAssetLibrary *custom_library = find_custom_asset_library_from_library_ref( library_reference); if (!custom_library || !custom_library->path[0]) { ``` (Eventually this kind of information should be stored in the asset library itself, so we don't have to hardcode behavior for different library types.)

Philipp Oeser commented

2023-02-21 09:46:53 +01:00

Member

Worked: Recently, unsure when exactly

Are we sure this ever worked with the essentials?

> Worked: Recently, unsure when exactly Are we sure this ever worked with the essentials?

Simon Thommes commented

2023-02-21 11:44:55 +01:00

Author

Member

Worked: Recently, unsure when exactly

Are we sure this ever worked with the essentials?

Actually... no, just tested the version I thought it worked in. I must have mixed that up with the regular search where it works

> > Worked: Recently, unsure when exactly > > Are we sure this ever worked with the essentials? Actually... no, just tested the version I thought it worked in. I must have mixed that up with the regular search where it works

Hans Goudey commented

2023-02-21 14:42:38 +01:00

Member

Thanks @JulianEisel, obvious now!

Thanks @JulianEisel, obvious now!

Hans Goudey referenced this issue from a commit

2023-02-21 14:45:19 +01:00

Fix #104975: Essentials assets missing from node link-drag search

Hans Goudey closed this issue

2023-02-21 14:45:55 +01:00

Blender Bot added

and removed

labels 2023-02-21 14:45:56 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104975

No description provided.