GPencil: Dot-hash modifier only affects first frame when using Time modifier in the chain #104979

New Issue

Closed

opened 2023-02-20 17:20:37 +01:00 by Aleš Jelovčan · 4 comments

Aleš Jelovčan commented

2023-02-20 17:20:37 +01:00

Member

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce MX330/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.66

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-15 18:27, hash: 1e6ed778969e
Worked: never

Short description of error
Only the first frame gets modified

Exact steps for others to reproduce the error

make at least 2 frames
add time offset and dot-dash modifiers

Proposed solution by @SietseB (blender chat):

"The dot dash modifier needs a fix in the source code. It's using

BKE_gpencil_frame_active_set(depsgraph, gpd);
bGPDframe *gpf = gpl->actframe;

to get the active frame, while most other modifiers use the correct:

bGPDframe *gpf = BKE_gpencil_frame_retime_get(depsgraph, scene, ob, gpl);
"

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce MX330/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.66 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-15 18:27, hash: `1e6ed778969e` Worked: never **Short description of error** Only the first frame gets modified **Exact steps for others to reproduce the error** - make at least 2 frames - add time offset and dot-dash modifiers Proposed solution by @SietseB (blender chat): "The dot dash modifier needs a fix in the source code. It's using ``` BKE_gpencil_frame_active_set(depsgraph, gpd); bGPDframe *gpf = gpl->actframe; ``` to get the active frame, while most other modifiers use the correct: `bGPDframe *gpf = BKE_gpencil_frame_retime_get(depsgraph, scene, ob, gpl);` "

Aleš Jelovčan commented

2023-02-20 21:43:57 +01:00

Author

Member

@antoniov here is a patch and a test file

@antoniov here is a patch and a test file

dotdashtest.blend

5.3 MiB

dotdashfix.diff

1.6 KiB

Pratik Borhade added the

labels 2023-02-21 07:00:48 +01:00

Pratik Borhade commented

2023-02-21 07:01:19 +01:00

Member

I can confirm

I can confirm

Antonio Vazquez self-assigned this 2023-02-21 10:01:31 +01:00

Antonio Vazquez referenced this issue from a commit

2023-02-21 10:04:56 +01:00

Fix #104979: GPencil Dot-hash only affects first frame with Time mod

Antonio Vazquez closed this issue

2023-02-21 10:06:07 +01:00

Antonio Vazquez commented

2023-02-21 10:06:40 +01:00

Member

@frogstomp Thanks for the fix... I had to do small changes, but now it's fixed. Could you test it?

@frogstomp Thanks for the fix... I had to do small changes, but now it's fixed. Could you test it?

Aleš Jelovčan commented

2023-02-21 10:50:52 +01:00

Author

Member

tested, all good, thank you

tested, all good, thank you

Julian Eisel referenced this issue from a commit

2023-02-21 15:22:37 +01:00

Fix #104979: GPencil Dot-hash only affects first frame with Time mod

Pratik Borhade added

and removed

labels 2023-02-22 03:25:34 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104979

No description provided.