Regression: Eye icon visible twice in dope sheet for stroke objects #105009

New Issue

Closed

opened 2023-02-21 09:29:19 +01:00 by Denis Briant · 5 comments

Denis Briant commented

2023-02-21 09:29:19 +01:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24

Blender Version
Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-16 21:59, hash: efc2e5134f5d

Introduced by 49ad91b5ab

Short description of error
in the dope sheet (and timeline) the eye icon is visible twice for stroke objects.

Exact steps for others to reproduce the error
this is only a problem seen with greace pencil keyframes.
In 3.4, the eye was visible on the right side, but if we look at other standard keyframe channels, it should be on the left side for consistency (but not twice ;).

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24 **Blender Version** Broken: version: 3.5.0 Beta, branch: blender-v3.5-release, commit date: 2023-02-16 21:59, hash: `efc2e5134f5d` Introduced by 49ad91b5ab **Short description of error** in the dope sheet (and timeline) the eye icon is visible twice for stroke objects. **Exact steps for others to reproduce the error** this is only a problem seen with greace pencil keyframes. In 3.4, the eye was visible on the right side, but if we look at other standard keyframe channels, it should be on the left side for consistency (but not twice ;).

screenCap dopesheet.jpg

43 KiB

screenCap dopesheet.jpg

Brecht Van Lommel added the

labels 2023-02-21 11:14:55 +01:00

Pratik Borhade commented

2023-02-21 15:27:23 +01:00

Member

Hi, thanks for the report. This looks like a regression to me (toggle doesn't appear in 3.4 and prior releases).
I'll bisect and fix the issue.

Hi, thanks for the report. This looks like a regression to me (toggle doesn't appear in 3.4 and prior releases). I'll bisect and fix the issue.

Pratik Borhade added

Animation & Rigging

and removed

labels 2023-02-21 15:27:57 +01:00

Pratik Borhade self-assigned this 2023-02-21 15:28:10 +01:00

Pratik Borhade commented

2023-02-22 08:07:12 +01:00

Member

This is introduced by 49ad91b5ab
@ChrisLend , apart from the eye button issue, pin button is not drawn for gpencil layers.
acf_gpl_setting_flag has no condition for pinning (i.e. case ACHANNEL_SETTING_ALWAYS_VISIBLE)
Do you think grease pencil layers should also draw pin toggle? If not then fix would be:
I'll submit the patch after your reply.

index 000bf04697f..aa0dcdb8306 100644
--- a/source/blender/editors/animation/anim_channels_defines.c
+++ b/source/blender/editors/animation/anim_channels_defines.c
@@ -5227,7 +5227,8 @@ void ANIM_channel_draw_widgets(const bContext *C,
   if (ac->sl) {
     if (ELEM(ac->spacetype, SPACE_ACTION, SPACE_GRAPH) &&
         (acf->has_setting(ac, ale, ACHANNEL_SETTING_VISIBLE) ||
-         acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE))) {
+         acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE)) &&
+        (ale->type != ANIMTYPE_GPLAYER)) {
       /* Pin toggle. */
       if (acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE)) {
         draw_setting_widget(ac, ale, acf, block, offset, ymid, ACHANNEL_SETTING_ALWAYS_VISIBLE);```

This is introduced by 49ad91b5ab7b7ac8d8c3fcfdb89ca07d0e4f194a @ChrisLend , apart from the `eye button` issue, pin button is not drawn for gpencil layers. `acf_gpl_setting_flag` has no condition for pinning (i.e. `case ACHANNEL_SETTING_ALWAYS_VISIBLE`) Do you think grease pencil layers should also draw pin toggle? If not then fix would be: I'll submit the patch after your reply. ```diff --git a/source/blender/editors/animation/anim_channels_defines.c b/source/blender/editors/animation/anim_channels_defines.c index 000bf04697f..aa0dcdb8306 100644 --- a/source/blender/editors/animation/anim_channels_defines.c +++ b/source/blender/editors/animation/anim_channels_defines.c @@ -5227,7 +5227,8 @@ void ANIM_channel_draw_widgets(const bContext *C, if (ac->sl) { if (ELEM(ac->spacetype, SPACE_ACTION, SPACE_GRAPH) && (acf->has_setting(ac, ale, ACHANNEL_SETTING_VISIBLE) || - acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE))) { + acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE)) && + (ale->type != ANIMTYPE_GPLAYER)) { /* Pin toggle. */ if (acf->has_setting(ac, ale, ACHANNEL_SETTING_ALWAYS_VISIBLE)) { draw_setting_widget(ac, ale, acf, block, offset, ymid, ACHANNEL_SETTING_ALWAYS_VISIBLE);```

Pratik Borhade added

and removed

labels 2023-02-22 08:07:28 +01:00

Pratik Borhade changed title from ~~UI problem : eye icon visible twice in dope sheet for stroke objects~~ to Regression: Eye icon visible twice in dope sheet for stroke objects

2023-02-22 08:07:43 +01:00

Christoph Lendenfeld commented

2023-02-22 11:19:44 +01:00

Member

If I understand correctly, grease pencil layers do not support pinning.
If that is the case, then yes they shouldn't draw the pin icon.

If I understand correctly, grease pencil layers do not support pinning. If that is the case, then yes they shouldn't draw the pin icon.

Pratik Borhade referenced a pull request that will close this issue

2023-02-22 17:02:50 +01:00

Fix #105009: Restore GPencil layer drawing in dopesheet #105080

Christoph Lendenfeld commented

2023-02-23 15:20:52 +01:00

Member

@PratikPB2123 this should be closed now, right?

@PratikPB2123 this should be closed now, right?

Pratik Borhade commented

2023-02-23 18:24:40 +01:00

Member

@ChrisLend , I've not pushed it to main repo.
I'll check documentation first before pushing it to main repo (doing this for the first time on new platform)

@ChrisLend , I've not pushed it to main repo. I'll check documentation first before pushing it to main repo (doing this for the first time on new platform)

Pratik Borhade referenced this issue from a commit

2023-02-24 18:02:49 +01:00

Fix #105009: Restore GPencil layer drawing in dopesheet

Pratik Borhade closed this issue

2023-02-24 18:02:51 +01:00

Blender Bot added

and removed

labels 2023-02-24 18:02:51 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105009

No description provided.