Cannot remove user preset when its name is translated #105011

New Issue

EMM · 2023-02-21T10:36:55+01:00

EMM commented

2023-02-21 10:36:55 +01:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.02

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-19 18:28, hash: e1e2dae31719
Worked: (newest version of Blender that worked as expected)

Short description of error
A user-added preset cannot be removed if its name is translated, for instance the default “New Preset”.

Exact steps for others to reproduce the error

In the Cycles Sampling, Viewport Sampling panel, add a new preset, keeping the default name
In the User Preferences, choose any language other than English
Try removing the previously added preset (its name is now translated)
This operation fails.

Original report

I found that if a preset is directly created and translated, it cannot be deleted
Because the deleted operator is deleted by name, but the name entered by the operator is translated
Operators like the following
This name should not be translated

bpy.ops.render.cycles_viewport_sampling_preset_add(name="预览", remove_name=True)

if change \scripts\modules\bpy_types.py 1048 line to props.name = f.split('.')[0]
Can solve this problem

props.name = f.split('.')[0]

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.02 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-19 18:28, hash: `e1e2dae31719` Worked: (newest version of Blender that worked as expected) **Short description of error** A user-added preset cannot be removed if its name is translated, for instance the default “New Preset”. **Exact steps for others to reproduce the error** - In the Cycles Sampling, Viewport Sampling panel, add a new preset, keeping the default name - In the User Preferences, choose any language other than English - Try removing the previously added preset (its name is now translated) - This operation fails. ----- **Original report** I found that if a preset is directly created and translated, it cannot be deleted Because the deleted operator is deleted by name, but the name entered by the operator is translated Operators like the following This name should not be translated bpy.ops.render.cycles_viewport_sampling_preset_add(name="预览", remove_name=True) if change \scripts\modules\bpy_types.py 1048 line to props.name = f.split('.')[0] Can solve this problem ``` props.name = f.split('.')[0] ``` ![image](/attachments/ca0723da-51cf-4757-8c70-28c0dfd314a1) ![image](/attachments/78734c4f-433c-4acf-88f2-0309cc24d096)

image.png

67 KiB

image.png

32 KiB

Brecht Van Lommel added the

labels 2023-02-21 11:14:56 +01:00

Iliya Katushenock commented

2023-02-21 12:57:51 +01:00

Hello. Are you sure you don't have to manually translate the string to delete?
Does the translation function work as it should?
Is this problem similar to #104145 ?

Hello. Are you sure you don't have to manually translate the string to delete? Does the translation function work as it should? Is this problem similar to https://projects.blender.org/blender/blender/issues/104145 ?

EMM commented

2023-02-22 02:49:05 +01:00

This is because the input name of the operator's actual parameter is translated, so the preset cannot be deleted. If I switch to English, this problem will not occur. The reason for the problem is in the following code image. I mentioned above that the solution is to change the name to f.split('.')[0]

This is because the input name of the operator's actual parameter is translated, so the preset cannot be deleted. If I switch to English, this problem will not occur. The reason for the problem is in the following code image. I mentioned above that the solution is to change the name to f.split('.')[0] ![image](/attachments/a558d250-f6c3-4399-8da2-5e93d97e9c7d) ![image](/attachments/6a72942c-b3fd-4ff8-bdf8-060a227e2711) ![image](/attachments/0a14143f-b8a0-438d-9426-8c8c3b378997) ![image](/attachments/11f2fa3c-ec3a-4458-876b-903d3ab2d03b)

image.png

58 KiB

image.png

21 KiB

image.png

146 KiB

image.png

43 KiB

image.png

65 KiB