Copy as a new driver operator can't have a shortcut #105371

New Issue

hamza.SMA · 2023-03-02T11:40:01+01:00

hamza.SMA commented

2023-03-02 11:40:01 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: rB55485cb379f7
Worked: (newest version of Blender that worked as expected)

Short description of error
for Copy as a new driver operator, can't assign shortcut

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: `rB55485cb379f7` Worked: (newest version of Blender that worked as expected) **Short description of error** for Copy as a new driver operator, can't assign shortcut ![image](/attachments/5510ace5-def9-4df0-ad02-e9fb5136cc0f)

image.png

52 KiB

hamza.SMA added the

labels 2023-03-02 11:40:02 +01:00

Iliya Katushenock commented

2023-03-02 14:34:03 +01:00

Isn't there a reason why this feature is missing?

Richard Antalik commented

2023-03-02 19:30:44 +01:00

Isn't there a reason why this feature is missing?

It works when I have created it manually. After that it also can be changed.

For assign shortcut button, there is comment /* only show 'assign' if there's a suitable key map for it to go in */. Checked WM_keymap_guess_opname() and there isn't.

Will make patch for this, but this is not a bug since it was never implemented.

> Isn't there a reason why this feature is missing? It works when I have created it manually. After that it also can be changed. For assign shortcut button, there is comment `/* only show 'assign' if there's a suitable key map for it to go in */`. Checked `WM_keymap_guess_opname()` and there isn't. Will make patch for this, but this is not a bug since it was never implemented.

👍 1

Richard Antalik closed this issue

2023-03-02 19:30:45 +01:00

Blender Bot added

and removed

labels 2023-03-02 19:30:47 +01:00

Richard Antalik commented

2023-03-02 19:43:15 +01:00

Just a note: I have noticed another comment in WM_keymap_guess_opname():

  /* Op types purposely skipped for now:
   *     BRUSH_OT
   *     BOID_OT
   *     BUTTONS_OT
   *     CONSTRAINT_OT
   *     PAINT_OT
   *     ED_OT
   *     FLUID_OT
   *     TEXTURE_OT
   *     UI_OT
   *     WORLD_OT
   */

But this has been done 5 years ago and PAINT_OT violates this already. So I will disregard this and make patch anyway. worst case won't go in.

Just a note: I have noticed another comment in `WM_keymap_guess_opname()`: ``` /* Op types purposely skipped for now: * BRUSH_OT * BOID_OT * BUTTONS_OT * CONSTRAINT_OT * PAINT_OT * ED_OT * FLUID_OT * TEXTURE_OT * UI_OT * WORLD_OT */ ``` But this has been done 5 years ago and `PAINT_OT` violates this already. So I will disregard this and make patch anyway. worst case won't go in.

Richard Antalik referenced this issue

2023-03-02 19:50:11 +01:00

UI: Make it possible to add shortcuts to UI operators. #105383

Richard Antalik referenced this issue from a commit

2023-04-21 17:09:53 +02:00

UI: Make it possible to add shortcuts to UI operators.

Richard Antalik commented

2023-04-21 17:10:32 +02:00

This issue should be fixed by 35a8341d7b

This issue should be fixed by 35a8341d7b

Sign in to join this conversation.