Geometry Nodes: cycling through outputs with viewer node does not work with geometry output #105397

New Issue

Closed

opened 2023-03-03 10:36:32 +01:00 by Sun Kim · 2 comments

Sun Kim commented

2023-03-03 10:36:32 +01:00

Contributor

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.2.2.230217

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-03 00:42, hash: 37c0b0b2b890
Worked: version: 3.5.0 Alpha, branch: master, commit date: 2023-01-30 22:48, hash: rBea8fd343eb2c

Likely caused by 5c994d7846

Short description of error
Cycling through outputs with viewer node stuck if:

the input node has a geometry output
the geometry output is the first output of the node
the geometry output is already connected to the viewer node

Exact steps for others to reproduce the error
Video:

Test file: ViewerNodeGeoCycleTest.blend

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.2.2.230217 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-03 00:42, hash: `37c0b0b2b890` Worked: version: 3.5.0 Alpha, branch: master, commit date: 2023-01-30 22:48, hash: `rBea8fd343eb2c` Likely caused by 5c994d7846 **Short description of error** Cycling through outputs with viewer node stuck if: - the input node has a geometry output - the geometry output is the first output of the node - the geometry output is already connected to the viewer node **Exact steps for others to reproduce the error** Video: <video controls src="/attachments/badd9f9c-f28a-4ae7-942f-747e64973cae"></video> Test file: [ViewerNodeGeoCycleTest.blend](/attachments/b5a8de12-90d2-44a9-a505-13c1286cf22d)

ViewerNodeGeoCycleTest.blend

1.1 MiB

ViewerNodeCycleThroughIssue.mp4

806 KiB

Sun Kim added the

labels 2023-03-03 10:36:32 +01:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-03-03 13:12:08 +01:00

Richard Antalik added

Nodes & Physics

and removed

labels 2023-03-03 18:13:37 +01:00

Richard Antalik commented

2023-03-03 18:16:55 +01:00

Member

Even in older version, the link was stuck on geometry input, so not sure if I should confirm this as regression. will ask about priority too.

Even in older version, the link was stuck on geometry input, so not sure if I should confirm this as regression. will ask about priority too.

Hans Goudey added

and removed

labels 2023-03-03 18:20:51 +01:00

Lukas Tönne commented

2023-03-16 15:57:37 +01:00

Member

Happens because the socket to connect to the viewer is determined by first finding an existing viewed socket, then picking the next viewable, unconnected output and connect that. However, if a geometry output is already viewed, this check makes it so the algorithm thinks no output is connected (last_linked_socket_index == -1). Following the rule described, it then connects the first viewable output, which is the geometry socket again, so nothing actually changes.

        if (socket->type == SOCK_GEOMETRY && (target_node.flag & NODE_DO_OUTPUT)) {
          /* Skip geometry sockets connected to viewer nodes when deciding whether to cycle through
           * outputs. */
          continue;
        }

If the geometry socket is preceded by a non-geometry socket, then then last_linked_socket_index is that non-geometry socket, so the algorithm goes into the 2nd branch where it iterates after the found socket.

It's badly defined how this operator should work, but i think we can make it so the non-geometry sockets cycle through by ensuring it doesn't just reconnect the geometry output all the time.

Happens because the socket to connect to the viewer is determined by first finding an existing viewed socket, then picking the _next_ viewable, unconnected output and connect that. However, if a geometry output is already viewed, [this check](https://projects.blender.org/blender/blender/src/commit/cb20f2cbf993737db5201a3e8cb4c4588ef608e4/source/blender/editors/space_node/node_relationships.cc#L545-L549) makes it so the algorithm thinks _no_ output is connected (`last_linked_socket_index == -1`). Following the rule described, it then connects the first viewable output, which is the geometry socket _again_, so nothing actually changes. ``` if (socket->type == SOCK_GEOMETRY && (target_node.flag & NODE_DO_OUTPUT)) { /* Skip geometry sockets connected to viewer nodes when deciding whether to cycle through * outputs. */ continue; } ``` If the geometry socket is preceded by a non-geometry socket, then then `last_linked_socket_index` is that non-geometry socket, so the algorithm goes into the 2nd branch where it iterates _after_ the found socket. It's badly defined how this operator should work, but i think we can make it so the non-geometry sockets cycle through by ensuring it doesn't just reconnect the geometry output all the time.

Lukas Tönne self-assigned this 2023-03-16 16:54:39 +01:00

Lukas Tönne referenced a pull request that will close this issue

2023-03-16 17:13:11 +01:00

Fix #105397: Support viewer socket cycling with linked geometry output #105836

Lukas Tönne referenced this issue from a commit

2023-03-20 14:08:57 +01:00

Fix #105397: Support cycling through sockets after a geometry output is linked.

Lukas Tönne closed this issue

2023-03-20 14:10:14 +01:00

Blender Bot added

and removed

labels 2023-03-20 14:10:15 +01:00

Sun Kim referenced this issue

2023-03-29 11:01:11 +02:00

Viewer node socket cycling ignores some sockets #106261

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105397

No description provided.