Mass deleting of files doesn't work properly in Blender File View. Each file requires to be confirmed separately. #105500

New Issue

Steffen Hartmann · 2023-03-06T17:40:00+01:00

Steffen Hartmann commented

2023-03-06 17:40:00 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.49

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: rB55485cb379f7
Worked: (newest version of Blender that worked as expected)

Short description of error
Mass deleting of files doesn't work properly in Blender File View. Each file requires to be confirmed separately. That makes it awkward to delete multiple selected files.

Exact steps for others to reproduce the error
Open Blender
File -> Open
Move to Blender project files
Select and press x to delete multiple files at once
You need to confirm on every file

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.49 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: `rB55485cb379f7` Worked: (newest version of Blender that worked as expected) **Short description of error** Mass deleting of files doesn't work properly in Blender File View. Each file requires to be confirmed separately. That makes it awkward to delete multiple selected files. **Exact steps for others to reproduce the error** Open Blender File -> Open Move to Blender project files Select and press x to delete multiple files at once You need to confirm on every file

2023-03-06 18-28-12.mp4

407 KiB

Steffen Hartmann added the

labels 2023-03-06 17:40:00 +01:00

Iliya Katushenock commented

2023-03-06 17:48:41 +01:00

Why is this a bug? It seems that even deleting in Windows works the same way.

Steffen Hartmann commented

2023-03-06 17:51:45 +01:00

Noo no in Windows if you select multiple files it shows a prompt to delete all files at once. Blender File View though requires you to confirm the deletion of every file seperatly and that is super awkward. Imagine you want to delete like 10 or 100 files (like an image sqeuence).

Iliya Katushenock commented

2023-03-06 18:22:19 +01:00

So, I decided to investigate if this is a regression, and in the end: are you sure that by selecting several projects/folders you cannot delete them all at once?

Iliya Katushenock added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-03-06 18:22:28 +01:00

Steffen Hartmann commented

2023-03-06 18:28:54 +01:00

So, I decided to investigate if this is a regression, and in the end: are you sure that by selecting several projects/folders you cannot delete them all at once?

> So, I decided to investigate if this is a regression, and in the end: are you sure that by selecting several projects/folders you cannot delete them all at once?

2023-03-06 18-28-12.mp4

407 KiB

Iliya Katushenock commented

2023-03-06 18:32:36 +01:00

This is not a problem with blender, but with your operating system. Not sure if it's possible to delete all selected files with one Win-Api call to match manual deletion.

Iliya Katushenock added the

Platform

Windows

label 2023-03-06 18:33:00 +01:00

Steffen Hartmann commented

2023-03-06 18:35:59 +01:00

Just call the windows "delete multiple items" instead "file delete" prompt?

Well i don't know but it's a very annoying situation.

Just call the windows "delete multiple items" instead "file delete" prompt? Well i don't know but it's a very annoying situation.

Harley Acheson commented

2023-03-06 22:00:11 +01:00

There are two different confirmations that can happen.

Within Blender

if you delete multiple files within Blender you will get just a single confirmation alert from Blender for the group of them.

From the Operating System

When deleting files, Blender moves them to the Recycle Bin. It has been the default configuraton of Windows, since version 8, that it does NOT give you a confirmation alert when this happens. This is because the act is not destructive as you can just move things back out of it.

So on my computer, using defaults, I do not get any warning from Windows when deleting files from Blender or from an explorer window. If yours is behaving differently and is not how you prefer, then change it:

Right-click on the Recycle Bin and select "Properties" from the Context Menu. Then uncheck the box for "Display delete confirmation dialog"

There are two different confirmations that can happen. **Within Blender** if you delete multiple files within Blender you will get just a single confirmation alert from Blender for the group of them. **From the Operating System** When deleting files, Blender moves them to the Recycle Bin. It has been the default configuraton of Windows, since version 8, that it does **NOT** give you a confirmation alert when this happens. This is because the act is not destructive as you can just move things back out of it. So on my computer, using defaults, I do not get any warning from Windows when deleting files from Blender or from an explorer window. If yours is behaving differently and is not how you prefer, then change it: Right-click on the Recycle Bin and select "Properties" from the Context Menu. Then uncheck the box for "Display delete confirmation dialog" ![RecyleConfirm.png](/attachments/b2c5d71e-6f37-4573-8611-bd0f32a06c89)

RecyleConfirm.png

66 KiB

Steffen Hartmann commented

2023-03-07 07:48:35 +01:00

I prefer to confirm deletion but don't think having to confirm on every single file, when i wanna mass delete files within Blenders File View, is a smart operation.

@Harley This is not a good solution, as the Delete Multiple Items message box should appear instead. Did you watch the video i've attached and how annoying mass deleting files is?
Windows File browser gives you just one confirmation box to delete all selected items.

edit: Imagine you want to delete like 300 images (sequence) with the Blender File Viewer, that will result in the need of confirming every single file because the rest of Blender will be locked until it's done. That is insane, you probably need to quit Blender with the task manager.

I prefer to confirm deletion but don't think having to confirm on every single file, when i wanna mass delete files within Blenders File View, is a smart operation. @Harley This is not a good solution, as the Delete Multiple Items message box should appear instead. Did you watch the video i've attached and how annoying mass deleting files is? Windows File browser gives you just one confirmation box to delete all selected items. edit: Imagine you want to delete like 300 images (sequence) with the Blender File Viewer, that will result in the need of confirming every single file because the rest of Blender will be locked until it's done. That is insane, you probably need to quit Blender with the task manager.

Harley Acheson commented

2023-03-07 17:17:51 +01:00

I prefer to confirm deletion but don't think having to confirm on every single file, when i wanna mass delete files within Blenders File View, is a smart operation.

One easy solution to consider is for us to turn off confirmations within our OS call for moving to recycle bin (probably using FOF_ALLOWUNDO | FOF_SILENT | FOF_WANTNUKEWARNING | FOF_NOCONFIRMATION | FOF_NOCONFIRMMKDIR). That way you wouldn't get a Windows dialog (unless there is an error or if anything would be permanently destroyed) when deleting from within Blender even if you have that preference selected (shown above), but you'd still get it outside of Blender when deleting files in Explorer.

@Harley This is not a good solution, as the Delete Multiple Items message box should appear instead. Did you watch the video i've attached and how annoying mass deleting files is?
Windows File browser gives you just one confirmation box to delete all selected items.

The only way to get the Windows "Delete Multiple Items" dialog is if we delete the multiple items at once using a single OS call. There isn't an alternative solution like turning off the warning on all but the first one when doing per-item deletions. Because if you answered "No" to that first one the rest would still be moved.

Adding a new operator to soft delete multiple items in a group isn't that simple because we have to support multiple platforms. And that is a feature request, not a bug report.

Imagine you want to delete like 300 images (sequence) with the Blender File Viewer, that will result in the need of confirming every single file because the rest of Blender will be locked until it's done. That is insane, you probably need to quit Blender with the task manager.

That wouldn't happen to me because I have my Windows preferences set to the defaults, like most users, so I can delete without seeing those Windows dialogs.

> I prefer to confirm deletion but don't think having to confirm on every single file, when i wanna mass delete files within Blenders File View, is a smart operation. One easy solution to consider is for us to turn off confirmations within our OS call for moving to recycle bin (probably using FOF_ALLOWUNDO | FOF_SILENT | FOF_WANTNUKEWARNING | FOF_NOCONFIRMATION | FOF_NOCONFIRMMKDIR). That way you wouldn't get a Windows dialog (unless there is an error or if anything would be permanently destroyed) when deleting from within Blender even if you have that preference selected (shown above), but you'd still get it outside of Blender when deleting files in Explorer. > @Harley This is not a good solution, as the Delete Multiple Items message box should appear instead. Did you watch the video i've attached and how annoying mass deleting files is? > Windows File browser gives you just one confirmation box to delete all selected items. The only way to get the Windows "Delete Multiple Items" dialog is if we delete the multiple items at once using a single OS call. There isn't an alternative solution like turning off the warning on all but the first one when doing per-item deletions. Because if you answered "No" to that first one the rest would still be moved. **Adding a new operator** to soft delete multiple items in a group isn't that simple because we have to support multiple platforms. And that is a feature request, not a bug report. > Imagine you want to delete like 300 images (sequence) with the Blender File Viewer, that will result in the need of confirming every single file because the rest of Blender will be locked until it's done. That is insane, you probably need to quit Blender with the task manager. That wouldn't happen to me because I have my Windows preferences set to the defaults, like most users, so I can delete without seeing those Windows dialogs.

Steffen Hartmann commented

2023-03-07 17:40:47 +01:00

That wouldn't happen to me because I have my Windows preferences set to the defaults, like most users, so I can delete without seeing those Windows dialogs.

Wait wait that is the default setting? I don't remember changing this. You sure?

edit: Doesn't change the awkward behaviour when using that specific setting though. It will result in people loosing it's mind when mass deleting files.

Feature request ok but it can also result in a bug like behaviour when Blender is kinda locked until you force close it via task manager or press yes or no a couple hundred times.

> That wouldn't happen to me because I have my Windows preferences set to the defaults, like most users, so I can delete without seeing those Windows dialogs. > Wait wait that is the default setting? I don't remember changing this. You sure? edit: Doesn't change the awkward behaviour when using that specific setting though. It will result in people loosing it's mind when mass deleting files. Feature request ok but it can also result in a bug like behaviour when Blender is kinda locked until you force close it via task manager or press yes or no a couple hundred times.

Harley Acheson commented

2023-03-07 17:47:09 +01:00

Wait wait that is the default setting? I don't remember changing this. You sure?

The following shows someone complaining about this, thinking it is a changed default in Windows 10. In the thread you will find someone then does fresh installs of old versions of Windows to confirm.

Apparently this option (to turn the confirmation off and on) was introduced in Windows 95. It was enabled by default until Windows 7. But has been disabled by default since Windows 8.

https://superuser.com/questions/1705010/has-windows-10-recently-started-defaulting-to-not-asking-before-deleting-files

> Wait wait that is the default setting? I don't remember changing this. You sure? The following shows someone complaining about this, thinking it is a changed default in Windows 10. In the thread you will find someone then does fresh installs of old versions of Windows to confirm. Apparently this option (to turn the confirmation off and on) was introduced in Windows 95. It was enabled by default until Windows 7. But has been disabled by default since Windows 8. https://superuser.com/questions/1705010/has-windows-10-recently-started-defaulting-to-not-asking-before-deleting-files

👍 1

Harley Acheson commented

2023-03-07 23:55:09 +01:00

Closing as feature request.

This issue only affects users deleting multiple files at once within the File Browser, on the Windows platform only, and only if they have also enabled the "Display delete confirmation dialog" OS preference (which has been off by default since windows 8). In that case they receive more OS dialogs than they may wish (once per file rather than once per group of deletions).

In order to do this better we'd need a BLI_delete_soft that deletes groups of files. Probably using IFileOperation::DeleteItems instead of current IFileOperation::DeleteItem in delete_soft in fileops.c.

Closing as feature request. This issue only affects users deleting multiple files at once within the File Browser, on the Windows platform only, and only if they have also enabled the "Display delete confirmation dialog" OS preference (which has been off by default since windows 8). In that case they receive more OS dialogs than they may wish (once per file rather than once per group of deletions). In order to do this better we'd need a `BLI_delete_soft` that deletes groups of files. Probably using [IFileOperation::DeleteItems](https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifileoperation-deleteitems) instead of current IFileOperation::DeleteItem in `delete_soft` in `fileops.c`.

Harley Acheson closed this issue

2023-03-07 23:55:37 +01:00

Blender Bot added

Status

Archived

and removed

Status

Needs Information from User

labels 2023-03-07 23:55:38 +01:00

Sign in to join this conversation.