Regression: Crash during create Viewer node #105720

New Issue

Closed

opened 2023-03-13 15:10:37 +01:00 by Jeroen Bakker · 2 comments

Jeroen Bakker commented

2023-03-13 15:10:37 +01:00

Member

System Information
Operating system: Linux-6.0.12-76060006-generic-x86_64-with-glibc2.35 64 Bits
Graphics card: AMD Radeon RX 5700 (navi10, LLVM 14.0.0, DRM 3.48, 6.0.12-76060006-generic) AMD 4.6 (Core Profile) Mesa 22.2.0

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: Unknown Unknown, hash: 2ae9526cd973867d46c7a51054be01ae7f26043b
Worked: (newest version of Blender that worked as expected)

Potentially caused by: 076a33c

Short description of error
If the node was not the top one in the draw order (there are other nodes that overlap it), clicking on that node's socket to call the Viewer node's causes a crash.

Exact steps for others to reproduce the error
In debug build:

Create new node tree (Geometry nodes or compositor).
Create 2 random nodes.
Click on first one. Now this node are on the top of space for drawing.
Click on the socket of last one node for create Viewer (CTRL-SHIFT-click).
Expected crash.

**System Information** Operating system: Linux-6.0.12-76060006-generic-x86_64-with-glibc2.35 64 Bits Graphics card: AMD Radeon RX 5700 (navi10, LLVM 14.0.0, DRM 3.48, 6.0.12-76060006-generic) AMD 4.6 (Core Profile) Mesa 22.2.0 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: Unknown Unknown, hash: `2ae9526cd973867d46c7a51054be01ae7f26043b` Worked: (newest version of Blender that worked as expected) Potentially caused by: 076a33c **Short description of error** If the node was not the top one in the draw order (there are other nodes that overlap it), clicking on that node's socket to call the Viewer node's causes a crash. **Exact steps for others to reproduce the error** In debug build: 1. Create new node tree (Geometry nodes or compositor). 2. Create 2 random nodes. 3. Click on first one. Now this node are on the top of space for drawing. 4. Click on the socket of last one node for create Viewer (`CTRL-SHIFT-click`). Expected crash.

crash stack_trace .txt

22 KiB

Jeroen Bakker added this to the 3.6 LTS milestone 2023-03-13 15:10:37 +01:00

Jeroen Bakker added the

labels 2023-03-13 15:10:37 +01:00

Jeroen Bakker added this to the Nodes & Physics project 2023-03-13 15:10:38 +01:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-03-13 15:29:39 +01:00

Iliya Katushenock added

and removed

labels 2023-03-13 15:31:02 +01:00

Iliya Katushenock changed title from ~~Crash, Switching Compositor Viewer node connection of older files~~ to Regression: Crash, Switching Compositor Viewer node connection of older files

2023-03-13 15:31:09 +01:00

Iliya Katushenock commented

2023-03-13 15:52:45 +01:00

Member

@HooglyBoogly Apparently, the composer tree does not have an initialized list of socket positions, if you follow the description

@HooglyBoogly Apparently, the composer tree does not have an initialized list of socket positions, if you follow the description

Iliya Katushenock commented

2023-03-13 19:47:02 +01:00

Member

Click on node socket cause re-sorting nodes that clear socket positions. But redrawing didn't happening due to operator doesn't not finished yet and trying to get socket positions.
Possible solutions that i can see:

~~Call another one node space redrawing after click but before other operator parts.~~
ensure_socket_locations
~~Do not cause sorting before other steps.~~

Click on node socket cause re-sorting nodes that clear socket positions. But redrawing didn't happening due to operator doesn't not finished yet and trying to get socket positions. Possible solutions that i can see: 1. ~~Call another one node space redrawing after click but before other operator parts.~~ 2. `ensure_socket_locations` 3. ~~Do not cause sorting before other steps.~~

Iliya Katushenock changed title from ~~Regression: Crash, Switching Compositor Viewer node connection of older files~~ to Regression: Crash during create Viewer node

2023-03-14 12:28:55 +01:00

Iliya Katushenock removed this from the Nodes & Physics project 2023-03-14 15:57:03 +01:00

Iliya Katushenock added

Nodes & Physics

and removed

Nodes & Physics

labels 2023-03-14 15:57:39 +01:00

Jacques Lucke referenced a pull request that will close this issue

2023-03-18 12:54:00 +01:00

Fix #105720: crash when adding viewer node #105877

Jacques Lucke added the

label 2023-03-18 12:54:57 +01:00

Hans Goudey added

and removed

labels 2023-03-19 01:00:00 +01:00

Jacques Lucke referenced this issue from a commit

2023-03-19 07:03:14 +01:00

Fix #105720: crash when adding viewer node

Jacques Lucke closed this issue

2023-03-19 07:03:15 +01:00

Blender Bot added

and removed

labels 2023-03-19 07:03:17 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105720

No description provided.