Undo in Armature Edit Mode does not undo Custom Properties #105744

New Issue

sanek122005 · 2023-03-13T20:37:38+01:00

sanek122005 commented

2023-03-13 20:37:38 +01:00

System Information
Operating system: Ubuntu 20.04
Graphics card: Geforce MX230

Blender Version
Broken: 3.5 Beta

Short description of error
Undo in Armature Edit Mode does not undo changes to Armature Custom Properties

Exact steps for others to reproduce the error

[optionally] In default scene delete all objects
Add an "Armature" object
Go to Edit Mode
In Object Data Properties add a Custom Property
Change the value of the property (to for example 0.0) in order to add an Undo step
Try undo (Ctrl+Z)

The step is not undone in edit mode.
Interestingly, changes to the Custom Properties of Bones are correctly undone in Edit mode.
This makes it seem that changes to Armature Custom Properties were perhaps missed in the Armature Edit Mode Undo Context.

Original Report
Video
Note when changing the head size in the redo panel, you can observe how the number of elements in in the Collection Property bones_for_delete grows.

Execute the script generate_rig.py from the file, if you do not have automatic script execution enabled
After execution, the Generate Rig panel will appear in the Rig category
Select Empty.021 first, then Armature.001. Switch to armature editing mode, and click Generate Rig on the panel
The bones will appear, and also the text on the panel will notify that there are elements in bones_for_delete. After that, you can scroll the head size on the redo panel, or simply undo the operator. the label in the panel will notify you that the number of items will not change

**System Information** Operating system: Ubuntu 20.04 Graphics card: Geforce MX230 **Blender Version** Broken: 3.5 Beta **Short description of error** Undo in Armature Edit Mode does not undo changes to Armature Custom Properties **Exact steps for others to reproduce the error** - [optionally] In default scene delete all objects - Add an "Armature" object - Go to `Edit Mode` - In `Object Data Properties` add a `Custom Property` - Change the value of the property (to for example `0.0`) in order to add an Undo step - Try undo (`Ctrl+Z`) The step is not undone in edit mode. Interestingly, changes to the Custom Properties of Bones are correctly undone in Edit mode. This makes it seem that changes to Armature Custom Properties were perhaps missed in the Armature Edit Mode Undo Context. --- **Original Report** [Video](https://youtu.be/3RZNWd5tRQI) Note when changing the **head size** in the redo panel, you can observe how the number of elements in in the Collection Property `bones_for_delete` grows. 1. Execute the script generate_rig.py from the file, if you do not have automatic script execution enabled 2. After execution, the Generate Rig panel will appear in the Rig category 3. Select Empty.021 first, then Armature.001. Switch to armature editing mode, and click Generate Rig on the panel 4. The bones will appear, and also the text on the panel will notify that there are elements in bones_for_delete. After that, you can scroll the **head size** on the redo panel, or simply undo the operator. the label in the panel will notify you that the number of items will not change

kira.blend

13 MiB

sanek122005 added the

labels 2023-03-13 20:37:39 +01:00

Germano Cavalcante commented

2023-03-14 19:45:41 +01:00

Thanks for the report, but I'm having trouble understanding the problem.
I didn't see any "bones_for_delete" notification, but I did see this error message:

Traceback (most recent call last):
  File "C:\Users\Germano Cavalcante\Downloads\kira.blend\generate_rig.py", line 124, in draw
AttributeError: 'NoneType' object has no attribute 'bones_for_delete'

Unfortunately the scenario described is too time consuming for us to track down, we require the bug reporter to narrow down the problem.

Normally .blend files can be simplified by removing most objects and disabling settings, until the problem reveals itself more clearly.

Thanks for the report, but I'm having trouble understanding the problem. I didn't see any "bones_for_delete" notification, but I did see this error message: ``` Traceback (most recent call last): File "C:\Users\Germano Cavalcante\Downloads\kira.blend\generate_rig.py", line 124, in draw AttributeError: 'NoneType' object has no attribute 'bones_for_delete' ``` Unfortunately the scenario described is too time consuming for us to track down, we require the bug reporter to narrow down the problem. Normally .blend files can be simplified by removing most objects and disabling settings, until the problem reveals itself more clearly.

Germano Cavalcante added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-03-14 19:45:53 +01:00

sanek122005 commented

2023-03-14 20:00:32 +01:00

that's how it should be. this error does not matter, when you switch to the armature, the label will appear

Germano Cavalcante commented

2023-03-14 20:12:29 +01:00

Can you try to simplify the file and the script?

The presented Scene is complex and too time consuming for us to track down. Generally bug reports only need a few lines of a script to demonstrate an error.

Also the error message in the presented script can hinder the developer to investigate.

Can you try to simplify the file and the script? The presented Scene is complex and too time consuming for us to track down. Generally bug reports only need a few lines of a script to demonstrate an error. Also the error message in the presented script can hinder the developer to investigate.

sanek122005 commented

2023-03-14 20:39:30 +01:00

good. I simplified the scene. the culprit of the bug is the script. if you create the necessary structure from emptys, and run a script on them in a new file, the error will also be reproducible
take this file here. execute generate_rig.py , I made some edits. select Empty first, then the Armature object with the Shift clamped. next, enter the bone editing mode, click Generate Rig. then the operator can be undo, for example, the panel will show that the number of items in the collection will not roll back

good. I simplified the scene. the culprit of the bug is the script. if you create the necessary structure from emptys, and run a script on them in a new file, the error will also be reproducible take this file here. execute generate_rig.py , I made some edits. select Empty first, then the Armature object with the Shift clamped. next, enter the bone editing mode, click Generate Rig. then the operator can be undo, for example, the panel will show that the number of items in the collection will not roll back

bug_test_2.blend

130 KiB

Germano Cavalcante commented

2023-03-15 15:41:53 +01:00

Thanks for simplifying the file. Now I could understand the problem.

What happens is that the Edit Mode of Armatures has its own Undo context - "Edit Armature"

Unlike the "Global Undo" context, apparently the "Edit Armature" context does not consider the Custom Properties of the Armature.

(It should be noted however that the Custom Properties of the Bones are considered).

We need information from the Core team developers to define whether the lack of Undo for Custom Properties of Armatures in Editing Mode is really a bug. However, the steps are still too complex to confirm this report.

Would you mind if I edit the description to just contain the following steps?
"

In default scene, optionally delete all objects
Add an "Armature" object
Go to Edit Mode
In Object Data Properties add a Custom Property
Change the value of the property (to for example 0.0) in order to add an Undo step
Try undo (Ctrl+Z)

The step is not undone in edit mode.
Interestingly, changes to the Custom Properties of Bones are correctly undone in Edit mode.
This makes it seem that changes to Armature Custom Properties were perhaps missed in the Armature Edit Mode Undo Context.
"

Thanks for simplifying the file. Now I could understand the problem. What happens is that the Edit Mode of Armatures has its own Undo context - "Edit Armature" Unlike the "Global Undo" context, apparently the "Edit Armature" context does not consider the Custom Properties of the Armature. (It should be noted however that the Custom Properties of the Bones are considered). We need information from the Core team developers to define whether the lack of Undo for Custom Properties of Armatures in Editing Mode is really a bug. However, the steps are still too complex to confirm this report. Would you mind if I edit the description to just contain the following steps? " - In default scene, optionally delete all objects - Add an "Armature" object - Go to `Edit Mode` - In `Object Data Properties` add a `Custom Property` - Change the value of the property (to for example `0.0`) in order to add an Undo step - Try undo (`Ctrl+Z`) The step is not undone in edit mode. Interestingly, changes to the Custom Properties of Bones are correctly undone in Edit mode. This makes it seem that changes to Armature Custom Properties were perhaps missed in the Armature Edit Mode Undo Context. "

sanek122005 commented

2023-03-15 15:49:58 +01:00

Would you mind if I edit the description to just contain the following steps?

I absolutely don't mind

> Would you mind if I edit the description to just contain the following steps? I absolutely don't mind

Germano Cavalcante changed title from ~~changes to CollectionProperty are not undone~~ to Undo in Armature Edit Mode does not undo Custom Properties

2023-03-15 15:58:37 +01:00

Germano Cavalcante added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undo in Armature Edit Mode does not undo Custom Properties #105744