Regression: object.hide_collection "Shift to extend" doesn't work in 3D View Collections panel #106251

Closed
opened 2023-03-29 02:21:34 +02:00 by Thomas Barlow · 4 comments
Member

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.2, 3.6
Worked: 3.1.2
Caused by d7dd7403a8

Short description of error
Holding shift while clicking on a collection name in the Collections panel (in the View tab of the right shelf of the 3D View) no longer extends the currently visible collections, instead acting as if the shift key was not held.

I'm guessing the cause is d7dd7403a8.

I'm not sure if it's actually possible to replicate the old behaviour without a hard-coded modifier key check, so, it may just be that the description for the operator should be updated to remove reference to using the shift key. The old behaviour doesn't even seem useful because clicking on an eye icon to the right of a collection name seems to do the same thing as the old behaviour of holding shift and clicking on a collection name, though maybe there's a difference I haven't noticed.

Exact steps for others to reproduce the error
The attached .blend (authored in 3.1.2) contains four collections each with a default cube, with only 1 collection currently visible.
Hold shift and click on the name of one of the currently hidden collections in the Collections panel in the View tab of the right shelf of the 3D view.
In 3.1.2, this unhides the clicked on collection and the already visible collection remains visible.
In 3.2.0+, this unhides the clicked on collection and hides all other visible collections (the same behaviour as when not holding shift in 3.1.2).

image

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.2, 3.6 Worked: 3.1.2 Caused by d7dd7403a8137e1043df4443898a677291726f0e **Short description of error** Holding `shift` while clicking on a collection name in the `Collections` panel (in the `View` tab of the right shelf of the 3D View) no longer extends the currently visible collections, instead acting as if the `shift` key was not held. I'm guessing the cause is https://projects.blender.org/blender/blender/commit/d7dd7403a8137e1043df4443898a677291726f0e. I'm not sure if it's actually possible to replicate the old behaviour without a hard-coded modifier key check, so, it may just be that the description for the operator should be updated to remove reference to using the `shift` key. The old behaviour doesn't even seem useful because clicking on an eye icon to the right of a collection name seems to do the same thing as the old behaviour of holding `shift` and clicking on a collection name, though maybe there's a difference I haven't noticed. **Exact steps for others to reproduce the error** The attached .blend (authored in 3.1.2) contains four collections each with a default cube, with only 1 collection currently visible. Hold `shift` and click on the name of one of the currently hidden collections in the `Collections` panel in the `View` tab of the right shelf of the 3D view. In 3.1.2, this unhides the clicked on collection and the already visible collection remains visible. In 3.2.0+, this unhides the clicked on collection and hides all other visible collections (the same behaviour as when not holding `shift` in 3.1.2). ![image](/attachments/48d54f3b-7b2c-4647-bcc6-5bb309d1e0e3)
Thomas Barlow added the
Severity
Normal
Type
Report
Status
Needs Triage
labels 2023-03-29 02:21:35 +02:00
Pratik Borhade changed title from object.hide_collection "Shift to extend" doesn't work in 3D View Collections panel to Regression: object.hide_collection "Shift to extend" doesn't work in 3D View Collections panel 2023-03-29 07:57:09 +02:00
Pratik Borhade added
Module
User Interface
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-03-29 07:57:35 +02:00
Member

Thanks for the report. Can confirm the regression. Bisecting...

Thanks for the report. Can confirm the regression. Bisecting...
Member

yes, caused by d7dd7403a8
@ideasman42 ^

yes, caused by d7dd7403a8137e1043df4443898a677291726f0e @ideasman42 ^
Pratik Borhade added
Severity
High
and removed
Severity
Normal
labels 2023-03-29 08:09:06 +02:00
Campbell Barton self-assigned this 2023-03-29 10:36:37 +02:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-03-29 11:06:33 +02:00
Member

@ideasman42 hi, can we backport this fix to 3.3 and 3.5?

@ideasman42 hi, can we backport this fix to [3.3](https://projects.blender.org/blender/blender/issues/100749) and [3.5](https://projects.blender.org/blender/blender/issues/106258)?

@PratikPB2123 yes, this is safe to back-port.

@PratikPB2123 yes, this is safe to back-port.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106251
No description provided.