Metal backend fails to compile simple shaders #106304

New Issue

Closed

opened 2023-03-30 13:05:00 +02:00 by stephen leger · 4 comments

stephen leger commented

2023-03-30 13:05:00 +02:00

Member

System Information
Operating system: MacOs - Metal backend
Graphics card: M1

Blender Version
Broken: 3.5
Worked: ?

Short description of error
Simple shader compilation fails under metal backend. The same does work using opengl backend on same computer.

Exact steps for others to reproduce the error
Start blender on M1, run the code in the console, lead to "shader compilation error".

import gpu

line_vertSrc = '''
uniform mat4 ModelViewProjectionMatrix;

in vec2 pos;

void main()
{
    gl_Position = ModelViewProjectionMatrix * vec4(pos, 0.0, 1.0);
}

'''

line_fragSrc = '''
uniform vec4 color;

out vec4 fragColor;

void main()
{
    fragColor = blender_srgb_to_framebuffer_space(color);
}
'''


_format = gpu.types.GPUVertFormat()
_pos_id = _format.attr_add(
    id="pos",
    comp_type="F32",
    len=2,
    fetch_mode="FLOAT")
shader = gpu.types.GPUShader(line_vertSrc, line_fragSrc)
unif_color = shader.uniform_from_name("color")

**System Information** Operating system: MacOs - Metal backend Graphics card: M1 **Blender Version** Broken: 3.5 Worked: ? **Short description of error** Simple shader compilation fails under metal backend. The same does work using opengl backend on same computer. **Exact steps for others to reproduce the error** Start blender on M1, run the code in the console, lead to "shader compilation error". ``` import gpu line_vertSrc = ''' uniform mat4 ModelViewProjectionMatrix; in vec2 pos; void main() { gl_Position = ModelViewProjectionMatrix * vec4(pos, 0.0, 1.0); } ''' line_fragSrc = ''' uniform vec4 color; out vec4 fragColor; void main() { fragColor = blender_srgb_to_framebuffer_space(color); } ''' _format = gpu.types.GPUVertFormat() _pos_id = _format.attr_add( id="pos", comp_type="F32", len=2, fetch_mode="FLOAT") shader = gpu.types.GPUShader(line_vertSrc, line_fragSrc) unif_color = shader.uniform_from_name("color") ```

stephen leger added the

labels 2023-03-30 13:05:01 +02:00

Pratik Borhade commented

2023-03-31 07:11:15 +02:00

Member

@mano-wii , can you check?

@mano-wii , can you check?

Pratik Borhade added the

labels 2023-03-31 07:11:27 +02:00

Michael Parkin-White commented

2023-03-31 10:12:49 +02:00

Believe this is a consequence of using the old shader creation API in python.
Metal requires Create-info for generating the shader resource binding points, so rather than using in vec2 pos directly, this should be specified with bpy.types.GPUShaderCreateInfo.

See: https://docs.blender.org/api/current/gpu.shader.html

I believe this older usage of the API had been deprecated?

Believe this is a consequence of using the old shader creation API in python. Metal requires Create-info for generating the shader resource binding points, so rather than using `in vec2 pos` directly, this should be specified with `bpy.types.GPUShaderCreateInfo`. See: https://docs.blender.org/api/current/gpu.shader.html I believe this older usage of the API had been deprecated?

Richard Antalik added

EEVEE & Viewport

and removed

labels 2023-03-31 19:03:09 +02:00

Germano Cavalcante commented

2023-03-31 22:58:01 +02:00

Member

In fact the use of the old API should be deprecated.

We can see examples of the new one at:
https://docs.blender.org/api/current/gpu.html#triangle-with-custom-shader

I feel like we need to do a task about this.
The closest I found was this one: #105644

In fact the use of the old API should be deprecated. We can see examples of the new one at: https://docs.blender.org/api/current/gpu.html#triangle-with-custom-shader I feel like we need to do a task about this. The closest I found was this one: #105644

Germano Cavalcante commented

2023-03-31 22:58:57 +02:00

Member

I am closing this report as it is an issue that needs to be handled differently than a bug.

I am closing this report as it is an issue that needs to be handled differently than a bug.

Germano Cavalcante closed this issue

2023-03-31 22:58:59 +02:00

Blender Bot added

and removed

labels 2023-03-31 22:59:00 +02:00

Germano Cavalcante referenced this issue

2023-04-26 16:27:35 +02:00

Blender 3.5 issues migrating code from bgl to gpu on Mac M1 Metal backend #107332

Germano Cavalcante referenced this issue

2023-04-26 16:29:43 +02:00

PyGPU: Deprecate shader creation through direct GLSL code input #107374

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106304

No description provided.