Switching to Sculpt mode crashes Blender #106358

New Issue

Closed

opened 2023-03-31 06:52:20 +02:00 by Shady Hamza · 5 comments

Shady Hamza commented

2023-03-31 06:52:20 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-31 02:03, hash: cde99075e870
Worked: (newest version of Blender that worked as expected)

Short description of error
Switching to sculpt mode from upper tab when scene is empty or there are hidden objects crashes blender.

Exact steps for others to reproduce the error

Using provided file, switch to "Sculpting" tab from the top tab bar. Blender crashes.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-31 02:03, hash: `cde99075e870` Worked: (newest version of Blender that worked as expected) **Short description of error** Switching to sculpt mode from upper tab when scene is empty or there are hidden objects crashes blender. **Exact steps for others to reproduce the error** - Using provided file, switch to "Sculpting" tab from the top tab bar. Blender crashes.

33 MiB

Shady Hamza added the

labels 2023-03-31 06:52:21 +02:00

YimingWu commented

2023-03-31 08:37:13 +02:00

Member

Can confirm the crash using provided Test.blend, however can't reproduce this issue with a newly created empty scene or hidden objects.

Can confirm the crash using provided `Test.blend`, however can't reproduce this issue with a newly created empty scene or hidden objects.

Iliya Katushenock added the

Sculpt, Paint & Texture

label 2023-03-31 08:38:09 +02:00

YimingWu commented

2023-03-31 11:04:47 +02:00

Member

This is caused by a newly opened file with no objects enabled/visible, causing me_eval==NULL when calling sculpt_update_object(). See source/blender/blenkernel/intern/paint.cc line 1674.

There's an assert there already by 9823a8f72b by @angavrilov , but apparently it needs another early return to avoid this crash because we can't really control whatever setup that's already in the file.

This is caused by a newly opened file with no objects enabled/visible, causing `me_eval==NULL` when calling `sculpt_update_object()`. See `source/blender/blenkernel/intern/paint.cc` line 1674. There's an assert there already by 9823a8f72be8 by @angavrilov , but apparently it needs another early return to avoid this crash because we can't really control whatever setup that's already in the file.

YimingWu added

and removed

labels 2023-03-31 11:04:58 +02:00

Alexander Gavrilov commented

2023-03-31 11:20:54 +02:00

Member

That assert was simply moved into the function from its two call sites (both did the same call to BKE_object_get_evaluated_mesh(ob_eval)), so I don't think my change actually affected anything. Switching to sculpt mode also should not enter the meaningful part of the code added by my commit either, since that's for painting.

That assert was simply moved into the function from its two call sites (both did the same call to `BKE_object_get_evaluated_mesh(ob_eval)`), so I don't think my change actually affected anything. Switching to sculpt mode also should not enter the meaningful part of the code added by my commit either, since that's for painting.

YimingWu commented

2023-03-31 11:25:14 +02:00

Member

Alright. I guess it's not related. I'll make it into an early return and see if it works in this kind of situation. Thanks!

Alright. I guess it's not related. I'll make it into an early return and see if it works in this kind of situation. Thanks!

YimingWu referenced a pull request that will close this issue

2023-03-31 11:48:01 +02:00

Fix #106358: Handles null evaluated object when entering sculpting workspace #106371

YimingWu commented

2023-03-31 11:49:58 +02:00

Member

#106371 is an attempt to fix this. Probably need developers who's more familiar with the sculpting part to tell whether this fix is appropriate or not. Tested to work correctly with the Test file in this issue.

#106371 is an attempt to fix this. Probably need developers who's more familiar with the sculpting part to tell whether this fix is appropriate or not. Tested to work correctly with the `Test` file in this issue.

Julien Kaspar added

Sculpt, Paint & Texture

and removed

Sculpt, Paint & Texture

labels 2023-04-06 14:00:04 +02:00

Joseph Eagar referenced this issue from a commit

2023-04-17 00:14:32 +02:00

Squashed commit of the following:

Joseph Eagar closed this issue

2023-04-17 00:14:33 +02:00

Blender Bot added

and removed

labels 2023-04-17 00:14:34 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106358

No description provided.