VSE range drawing off by one for endframe, Set Frame Range to Strips off by one for endframe #106480

Closed
opened 2023-04-03 08:53:53 +02:00 by Erik-Groeneveld · 3 comments

System Information
Operating system: Linux-4.19.0-23-amd64-x86_64-with-glibc2.28 64 Bits
Graphics card: llvmpipe (LLVM 7.0, 128 bits) VMware, Inc. 3.3 (Core Profile) Mesa 18.3.6

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-02 15:08, hash: dc63f75837f2
Worked: (newest version of Blender that worked as expected)

Short description of error
In the Video Sequence Editor, the function "View / Range / Set End Frame" sets the end frame one frame further on the timeline than the current position of the playhead.

Exact steps for others to reproduce the error

  1. Start Blender in Video Editing mode.
  2. On the timeline: SHIFT-A, add an image.
  3. PgUp: move the playhead to the last frame of the strip.
  4. Ctrl-End: set end frame.
  5. Notice that the end frame is not set to the current position of the playhead, but one frame to the right.

Probably related:

  1. Start Blender in Video Editing mode.
  2. On the timeline: SHIFT-A, add an image.
  3. View / Range / Set Frame Range to Strips
  4. Notice that now, the end frame is correctly set to the last frame of the strip
  5. Shift-arrow right should move the playhead to the last position of the strip, but it moves to the last position minus one frame.
**System Information** Operating system: Linux-4.19.0-23-amd64-x86_64-with-glibc2.28 64 Bits Graphics card: llvmpipe (LLVM 7.0, 128 bits) VMware, Inc. 3.3 (Core Profile) Mesa 18.3.6 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-02 15:08, hash: `dc63f75837f2` Worked: (newest version of Blender that worked as expected) **Short description of error** In the Video Sequence Editor, the function "View / Range / Set End Frame" sets the end frame one frame further on the timeline than the current position of the playhead. **Exact steps for others to reproduce the error** 1. Start Blender in Video Editing mode. 2. On the timeline: SHIFT-A, add an image. 3. PgUp: move the playhead to the last frame of the strip. 4. Ctrl-End: set end frame. 5. Notice that the end frame is not set to the current position of the playhead, but one frame to the right. Probably related: 1. Start Blender in Video Editing mode. 2. On the timeline: SHIFT-A, add an image. 3. View / Range / Set Frame Range to Strips 4. Notice that now, the end frame is correctly set to the last frame of the strip 5. Shift-arrow right should move the playhead to the last position of the strip, but it moves to the last position minus one frame.
Erik-Groeneveld added the
Priority
Normal
Status
Needs Triage
Type
Report
labels 2023-04-03 08:53:54 +02:00
Member

Can confirm, will check.

Can confirm, will check.
Philipp Oeser added
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-04-03 09:26:36 +02:00
Member

Hm, to me it looks like the drawing of the range is actually wrong.

Note though that it has bee tried to correct this [which has then been reverted for reasons I dont fully grasp... ].

See the following commits:
0e02ad8b64
2cdcb1c171

Maybe @Psy-Fi or @fsiddi remembers why this got reverted?

Regarding Set Frame Range to Strips: this otoh looks like it actually sets the range wrong since the initial implementation in d4bef6a215 (it subtracts 1 from the end for no obvious reason -- possibly to circumvent the drawing issue?)

So until we know why the drawing is the way it is, we might want to NOT change the other issue [both would be trivial to do though]

CC @iss

Hm, to me it looks like the **drawing** of the range is actually wrong. Note though that it has bee tried to correct this [which has then been reverted for reasons I dont fully grasp... ]. See the following commits: 0e02ad8b6495b2755598a24b487041a3ed8e0116 2cdcb1c17161 Maybe @Psy-Fi or @fsiddi remembers why this got reverted? Regarding `Set Frame Range to Strips`: this otoh looks like it actually sets the **range** wrong since the initial implementation in d4bef6a21508 (it subtracts 1 from the end for no obvious reason -- possibly to circumvent the drawing issue?) So until we know why the drawing is the way it is, we might want to NOT change the other issue [both would be trivial to do though] CC @iss
Philipp Oeser added the
Interest
Video Sequencer
Module
VFX & Video
labels 2023-04-03 10:13:16 +02:00
Philipp Oeser changed title from "Set End Frame" is set to next frame, instead of playhead position (VSE) to VSE range drawing off by one for endframe, Set Frame Range to Strips off by one for endframe 2023-04-03 10:14:26 +02:00

This is working as intended. Reason is, because in VSE a frame has "width". Keyframes are point like, so you don't have this issue.

This can't be resolved by mnodifying strip_jump operator, because it wouldn't work correctly.
This also can't be resolved by modifying end_frame_set operator, because if you set end frame according to what you see in preview, it would not work correctly.
Same goes for drawing issue - if you ignore frame width, users would extend strip up tu end frame line, which will result in always rendering black frame.

Only solution would be to make playhead represent the width of a frame, but that would be ugly and perhaps even more confusing.

Will close, since this is working as expected. Thanks for reporting anyway. Will add comment to code to clarify this.

This is working as intended. Reason is, because in VSE a frame has "width". Keyframes are point like, so you don't have this issue. This can't be resolved by mnodifying `strip_jump` operator, because it wouldn't work correctly. This also can't be resolved by modifying `end_frame_set` operator, because if you set end frame according to what you see in preview, it would not work correctly. Same goes for drawing issue - if you ignore frame width, users would extend strip up tu end frame line, which will result in always rendering black frame. Only solution would be to make playhead represent the width of a frame, but that would be ugly and perhaps even more confusing. Will close, since this is working as expected. Thanks for reporting anyway. Will add comment to code to clarify this.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2023-04-03 17:24:25 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106480
No description provided.