Custom data split normals are taking active object from the area even if the active object is overriden #106612

New Issue

Open

opened 2023-04-06 07:35:34 +02:00 by Andrej · 4 comments

Andrej commented

2023-04-06 07:35:34 +02:00

Contributor

Blender 3.5

Short description of error

Operators customdata_custom_splitnormals_add and customdata_custom_splitnormals_clear if called from properties panel seem to take active object from currently active area even if you context.temp_override(object=obj) or context.view_layer.objects.active = obj to change active object which is counterintuitive and contradicts with how other operators active object override work.

Found a workaround - if you context.temp_override(area=None, object=obj) it will take active object into account.

Exact steps for others to reproduce the error

Open attached .blend file
Run the script
(Make sure all objects are selected)
Go to Custom Split Normals section (in Object Data Properties after Geometry Data).
Try "Add CSN" - it wouldn't work
Try "Add CSN override area" - it doesk work.

Blender 3.5 **Short description of error** Operators `customdata_custom_splitnormals_add` and `customdata_custom_splitnormals_clear` if called from properties panel seem to take active object from currently active area even if you `context.temp_override(object=obj)` or `context.view_layer.objects.active = obj` to change active object which is counterintuitive and contradicts with how other operators active object override work. Found a workaround - if you `context.temp_override(area=None, object=obj)` it will take active object into account. **Exact steps for others to reproduce the error** 1. Open attached .blend file 2. Run the script 3. (Make sure all objects are selected) 4. Go to Custom Split Normals section (in Object Data Properties after Geometry Data). 5. Try "Add CSN" - it wouldn't work 6. Try "Add CSN override area" - it doesk work.

ScriptTest.blend

934 KiB

Andrej added the

labels 2023-04-06 07:35:35 +02:00

Iliya Katushenock added the

label 2023-04-06 14:56:35 +02:00

Germano Cavalcante commented

2023-04-06 19:13:26 +02:00

Member

You need to overwrite "mesh".

context.temp_override(mesh=obj.data, object=obj)

I don't know why overriding the "area" removes the keyword "mesh".
@ideasman42 can you shed some light?

You need to overwrite "mesh". ``` context.temp_override(mesh=obj.data, object=obj) ``` I don't know why overriding the "area" removes the keyword "mesh". @ideasman42 can you shed some light?

Germano Cavalcante added

Needs Info from Developers

and removed

labels 2023-04-06 19:13:38 +02:00

Thomas Barlow commented

2023-04-06 19:18:12 +02:00

Member

mesh.customdata_custom_splitnormals_add and mesh.customdata_custom_splitnormals_clear use ED_mesh_context to get the mesh to operate on, which first attempts to get the "mesh" from the current context. You should be able to override "mesh" to the bpy.types.Mesh that you want to operate on to achieve your desired results.

If there's no "mesh" in the current context, it falls back to getting the Object with ED_object_active_context which tries to get it from "object" if it exists (ED_object_context) or then falls back to "active_object" if it exists (CTX_data_active_object).

There's basically no rhyme nor reason to how each operator gets what to operate on from the current context, some will prefer "object", some will prefer "active_object", some will get the active object directly from the "view_layer" or you might have something different like "mesh" in this case. You will have to look up the source code of the operator every time that you want to use a context override.

`mesh.customdata_custom_splitnormals_add` and `mesh.customdata_custom_splitnormals_clear` use `ED_mesh_context` to get the mesh to operate on, which first attempts to get the "mesh" from the current context. You should be able to override "mesh" to the `bpy.types.Mesh` that you want to operate on to achieve your desired results. If there's no "mesh" in the current context, it falls back to getting the Object with `ED_object_active_context` which tries to get it from "object" if it exists (`ED_object_context`) or then falls back to "active_object" if it exists (`CTX_data_active_object`). There's basically no rhyme nor reason to how each operator gets what to operate on from the current context, some will prefer "object", some will prefer "active_object", some will get the active object directly from the "view_layer" or you might have something different like "mesh" in this case. You will have to look up the source code of the operator every time that you want to use a context override.

Andrej commented

2023-04-06 20:30:43 +02:00

Author

Contributor

Thanks for the insight, never seen overriding mesh parameter before. Never thought there is such option because usually mesh is not an attribute of https://docs.blender.org/api/current/bpy.types.Context.html

>>> bpy.context.mesh
Traceback (most recent call last):
  File "<blender_console>", line 1, in <module>
AttributeError: 'Context' object has no attribute 'mesh'

But if you check it from the operator that was executed from properties panel it's indeed there.

>>> print('mesh context', bpy.context.mesh)
mesh context <bpy_struct, Mesh("Cube.004") at 0x000001CD2C830108>

Thanks for the insight, never seen overriding `mesh` parameter before. Never thought there is such option because usually `mesh` is not an attribute of https://docs.blender.org/api/current/bpy.types.Context.html ``` >>> bpy.context.mesh Traceback (most recent call last): File "<blender_console>", line 1, in <module> AttributeError: 'Context' object has no attribute 'mesh' ``` But if you check it from the operator that was executed from properties panel it's indeed there. ``` >>> print('mesh context', bpy.context.mesh) mesh context <bpy_struct, Mesh("Cube.004") at 0x000001CD2C830108> ```

Thomas Barlow commented

2023-04-06 20:53:03 +02:00

Member

Thanks for the insight, never seen overriding mesh parameter before. Never thought there is such option because usually mesh is not an attribute of https://docs.blender.org/api/current/bpy.types.Context.html

https://docs.blender.org/api/current/bpy.context.html gives a more complete list of the context members that are available in different contexts.

> Thanks for the insight, never seen overriding `mesh` parameter before. Never thought there is such option because usually `mesh` is not an attribute of https://docs.blender.org/api/current/bpy.types.Context.html https://docs.blender.org/api/current/bpy.context.html gives a more complete list of the context members that are available in different contexts.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106612

No description provided.