Regression: Accessing a GN submenu via Quick Favorites causes crash in #106621

New Issue

Closed

opened 2023-04-06 13:22:03 +02:00 by Sun Kim · 8 comments

Sun Kim commented

2023-04-06 13:22:03 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315

Blender Version
Broken: version: 3.4, 3.6.0 Alpha
Worked: 3.3
Caused by cf98518055

Short description of error
In Geometry Nodes editor, accessing a submenu of the add menu via Quick Favorites can cause crash. This happens if the access from Quick Favorites happens before accessing the add menu via the usual ways (Shift-A, header menu, context menu).

Crash log from 3.5.0 stable:
blender.crash.txt

Exact steps for others to reproduce the error

From Geometry Nodes editor, open the add menu, and register any of menus that has submenu(s) to Quick Favorites (Attribute menu for example)
Close Blender so we can start clean
Launch Blender, and go to Geometry Nodes editor. DO NOT bring up the add menu
Bring up the quick favorites, and access the menu

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315 **Blender Version** Broken: version: 3.4, 3.6.0 Alpha Worked: 3.3 Caused by cf985180551da833d4160afcdf2cb4292e138174 **Short description of error** In Geometry Nodes editor, accessing a submenu of the add menu via Quick Favorites can cause crash. This happens if the access from Quick Favorites happens before accessing the add menu via the usual ways (`Shift-A`, header menu, context menu). Crash log from 3.5.0 stable: [blender.crash.txt](/attachments/28906544-d164-45bd-ae52-e3712e98ebe1) **Exact steps for others to reproduce the error** - From Geometry Nodes editor, open the add menu, and register any of menus that has submenu(s) to Quick Favorites (`Attribute` menu for example) - Close Blender so we can start clean - Launch Blender, and go to Geometry Nodes editor. DO NOT bring up the add menu - Bring up the quick favorites, and access the menu

blender.crash.txt

26 KiB

Sun Kim added the

labels 2023-04-06 13:22:04 +02:00

Iliya Katushenock added

and removed

labels 2023-04-06 15:12:06 +02:00

Sun Kim commented

2023-04-26 12:49:32 +02:00

Author

Contributor

@mod_moder Hi, how about adding Geometry Nodes label so this can get some attention from the module?

@mod_moder Hi, how about adding Geometry Nodes label so this can get some attention from the module?

Iliya Katushenock commented

2023-04-26 13:34:50 +02:00

Member

@persun In a fact, i was may just be confused in this, that bug look like interface related. Not sure, why i assign python module, sorry.

@persun In a fact, i was may just be confused in this, that bug look like interface related. Not sure, why i assign python module, sorry.

Iliya Katushenock added

Nodes & Physics

and removed

labels 2023-04-26 13:35:09 +02:00

Pratik Borhade commented

2023-04-26 13:41:33 +02:00

Member

Worked: 3.4

For me 3.4 is the first bad version. I'll bisect and raise the priority for now.

> Worked: 3.4 For me 3.4 is the first bad version. I'll bisect and raise the priority for now.

Pratik Borhade added

and removed

labels 2023-04-26 13:41:41 +02:00

Pratik Borhade commented

2023-04-26 14:09:26 +02:00

Member

Bisecting points to: cf98518055
@HooglyBoogly ^

Bisecting points to: cf985180551da833d4160afcdf2cb4292e138174 @HooglyBoogly ^

Pratik Borhade changed title from ~~Accessing a submenu of the add menu via Quick Favorites causes crash in Geometry Nodes~~ to Regression: Accessing a GN submenu via Quick Favorites causes crash in

2023-04-26 14:10:11 +02:00

Harley Acheson commented

2023-05-10 21:25:46 +02:00

Member

Following these instructions exactly I see this same error with an exception in uiTemplateNodeAssetMenuItems while iterating through an AssetCatalogTree with find_root_item.

At the point of error the tree's catalogs is null. So everything seems to work perfectly with this change:

diff --git a/source/blender/editors/space_node/add_menu_assets.cc b/source/blender/editors/space_node/add_menu_assets.cc
index ba14abcdd92..8bc435bbc3f 100644
--- a/source/blender/editors/space_node/add_menu_assets.cc
+++ b/source/blender/editors/space_node/add_menu_assets.cc
@@ -330,12 +330,16 @@ void uiTemplateNodeAssetMenuItems(uiLayout *layout, bContext *C, const char *cat
 {
   using namespace blender;
   using namespace blender::ed::space_node;
   bScreen &screen = *CTX_wm_screen(C);
   SpaceNode &snode = *CTX_wm_space_node(C);
   AssetItemTree &tree = *snode.runtime->assets_for_menu;
+
+  if (&tree.catalogs == nullptr) {
+    return;
+  }
   const asset_system::AssetCatalogTreeItem *item = tree.catalogs.find_root_item(catalog_path);
   if (!item) {
     return;
   }
 
   asset_system::AssetLibrary *all_library = get_all_library_once_available();

But without understanding this area much the above could also just be hiding an unexpected error state.

@HooglyBoogly Following these instructions exactly I see this same error with an exception in `uiTemplateNodeAssetMenuItems` while iterating through an AssetCatalogTree with find_root_item. At the point of error the tree's `catalogs` is null. So everything seems to work perfectly with this change: ```Diff diff --git a/source/blender/editors/space_node/add_menu_assets.cc b/source/blender/editors/space_node/add_menu_assets.cc index ba14abcdd92..8bc435bbc3f 100644 --- a/source/blender/editors/space_node/add_menu_assets.cc +++ b/source/blender/editors/space_node/add_menu_assets.cc @@ -330,12 +330,16 @@ void uiTemplateNodeAssetMenuItems(uiLayout *layout, bContext *C, const char *cat { using namespace blender; using namespace blender::ed::space_node; bScreen &screen = *CTX_wm_screen(C); SpaceNode &snode = *CTX_wm_space_node(C); AssetItemTree &tree = *snode.runtime->assets_for_menu; + + if (&tree.catalogs == nullptr) { + return; + } const asset_system::AssetCatalogTreeItem *item = tree.catalogs.find_root_item(catalog_path); if (!item) { return; } asset_system::AssetLibrary *all_library = get_all_library_once_available(); ``` But without understanding this area much the above could also just be hiding an unexpected error state.

Hans Goudey commented

2023-05-11 04:38:29 +02:00

Member

I don't get a crash here, the menu in the quick favorites is just empty. That's probably expected due to the way we build the menu dynamically though, which relies on the context variables stored in the parent UI layout to find which sub-catalog to use.

@Harley Not sure about that diff. If tree isn't null, tree.catalogs will never be null. Maybe the null check needs to be on snode.runtime->assets_for_menu. If that's enough to avoid a crash though, I see no reason not to add the null check there.

I don't get a crash here, the menu in the quick favorites is just empty. That's probably expected due to the way we build the menu dynamically though, which relies on the context variables stored in the parent UI layout to find which sub-catalog to use. @Harley Not sure about that diff. If `tree` isn't null, `tree.catalogs` will never be null. Maybe the null check needs to be on `snode.runtime->assets_for_menu`. If that's enough to avoid a crash though, I see no reason not to add the null check there.

Harley Acheson commented

2023-05-11 04:44:26 +02:00

Member

@HooglyBoogly - If tree isn't null, tree.catalogs will never be null

At the time of the crash the tree existed in that I could examine its contents, but for its "catalogs" my MSVS debugger showed it having a value like "struct at NULL" which I honestly have never seen before.

@HooglyBoogly - If tree isn't null, tree.catalogs will never be null At the time of the crash the tree existed in that I could examine its contents, but for its "catalogs" my MSVS debugger showed it having a value like "struct at NULL" which I honestly have never seen before.

Harley Acheson self-assigned this 2023-05-16 18:14:26 +02:00

Harley Acheson referenced a pull request that will close this issue

2023-05-16 19:04:04 +02:00

Fix #106621: Crash Adding GN Menus to Quick Favorites #107984

Harley Acheson commented

2023-05-16 19:05:02 +02:00

Member

Maybe the null check needs to be on snode.runtime->assets_for_menu. If that's enough to avoid a crash though, I see no reason not to add the null check there.

Yes, that works perfectly and is a better check. Will post a PR.

> Maybe the null check needs to be on `snode.runtime->assets_for_menu`. If that's enough to avoid a crash though, I see no reason not to add the null check there. Yes, that works perfectly and is a better check. Will post a PR.

Harley Acheson closed this issue

2023-05-16 20:50:54 +02:00

Blender Bot added

and removed

labels 2023-05-16 20:50:55 +02:00

Harley Acheson referenced this issue from a commit

2023-05-16 20:51:00 +02:00

Fix #106621: Crash Adding GN Menus to Quick Favorites

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106621

No description provided.