Cycles: Multi-device denoise runs denoising data passes #106667

New Issue

Sergey Sharybin · 2023-04-07T15:58:42+02:00

Sergey Sharybin commented

2023-04-07 15:58:42 +02:00

System Information
Operating system: Linux-6.1.0-7-amd64-x86_64-with-glibc2.36 64 Bits, X11 UI
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 525.89.02

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-06 20:17, hash: 3681ed377be6
Worked: Presumably, prior to 79787bf8e1

Short description of error

When Cycles has the following options enabled:

Multiple render GPU
Denoising Data in the render passes
Denoise of render result

the denoising data passes are modified by the den denoiser, and are left to be too dark.

It is a bit hard to confirm, but seems it is caused by the 79787bf8e1 which allowed in-place modification of the buffer copied from all the devices, and used that to copy pixels into the render result.

Exact steps for others to reproduce the error

Render attached file with multi-device configuration (GPU+GPU or GPU+CPU), and see the denoising data passes. They appear too dark.

**System Information** Operating system: Linux-6.1.0-7-amd64-x86_64-with-glibc2.36 64 Bits, X11 UI Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 525.89.02 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-06 20:17, hash: `3681ed377be6` Worked: Presumably, prior to 79787bf8e1e1 **Short description of error** When Cycles has the following options enabled: - Multiple render GPU - Denoising Data in the render passes - Denoise of render result the denoising data passes are modified by the den denoiser, and are left to be too dark. It is a bit hard to confirm, but seems it is caused by the 79787bf8e1e1 which allowed in-place modification of the buffer copied from all the devices, and used that to copy pixels into the render result. **Exact steps for others to reproduce the error** Render attached file with multi-device configuration (GPU+GPU or GPU+CPU), and see the denoising data passes. They appear too dark.

denoise_passes.blend

885 KiB

Sergey Sharybin added the

labels 2023-04-07 15:58:59 +02:00

Sergey Sharybin self-assigned this 2023-04-07 15:59:04 +02:00

Sergey Sharybin referenced a pull request that will close this issue