viewport compositor - color change when disabling Hue correction node with no adjustments #106965
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#106965
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315
Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-12 11:04, hash:
da75495ada00Worked: n/a
Short description of error
In the included node setup I'm getting a color shift (mostly in oranges and yellows) when disabling the hue correct node that has no adjustments. In my included blend file the hue correct node is on the far right in the green frame. Tried a fresh hue correction node and same issue. The issue does not happen if I use a huecorrect as the only node plugged into the image.
Exact steps for others to reproduce the error
Open my blend file and mute and unmute the hue correct node in the green frame on the far right of the compositor using the viewport compositor. Image is included.
I can confirm that real-time compositor gives a result that doesn't look right here. And also, the final composer is completely serviceable.
If I disable the nodes before the hue correction (in the same green frame), the problem doesn't happen.
I can't reproduce the issue. Can you try to simplify that file as much as possible, this is currently too complex to investigate.
@mod_moder Can you actually reproduce the Hue Correction issue or just that the realtime compositor gives a bad result?
made a smaller node setup. You can use the same image from before. Mute the hue correction node and you should see the colors shift, if you replace it with a new hue correct the same problem happens.
Think It might be a clamping problem, did a quick test with subtracting the image and was able to replicate it. test attached
edit: yes If I enable clamping on the the subtract node , the color shifting no longer happens. the shifting does not happen with the main compositor.
@OmarEmaraDev
@kevindonovan Maybe I am missing something, but the Saturation curve in your test3 example has changed, so a difference is expected.
You are correct, my mistake from testing. In the test 2 example if you reset the curve you will still see the problem
uploaded a vid of the problem.
This is due to a difference in how the CPU compositor and realtime compositor do HSV<=>RGB conversion.
Not sure yet if we should make shader materials match the compositor or if we should add a special variant.
understood. I just tested it with the color correction node and pushing saturation high, just adding the hue correction node greatly desaturates the image (mostly the yellows). In its current state the node is unusable because it destroys your work from before.
I also tested with the separate color and combine color in hsv mode, the problem does not happen there.
Thanks for looking into this
the fix did not fix the problem for me, all it did was make the color shift happen on the cpu the same as it did on the gpu .