Naming Inconsistency with LIGHT_PROBE causing problem #106978

New Issue

Harry McKenzie · 2023-04-15T04:39:48+02:00

Harry McKenzie commented

2023-04-15 04:39:48 +02:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: NVIDIA GeForce GTX TITAN/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 473.04

Blender Version
Broken: version: 3.4.0, branch: master (modified), commit date: 2022-12-07 11:39, hash: rB175bd3820151
Worked: Never

Short description of error

This issue is not a bug but rather a consistency issue which I though is worth reporting. The following script works for all types defined in Id Type Items except for LIGHT_PROBE which deviates from the naming convention used for all other types. Every enum type just concatenates all words together without an underscore like GREASEPENCIL, CACHEFILE, WINDOWMANAGER, PAINTCURVE, LINESTYLE, etc. I noticed this problem when I answered this thread.

Exact steps for others to reproduce the error

Create any Light Probe object via Add > Light Probe
Run the following script:

def get_id_type(obj):
    return obj.bl_rna.identifier.upper()

obj = bpy.data.lightprobes[0]
id_type = get_id_type(obj)
print("Id Type: ", id_type)

Notice it prints LIGHTPROBE instead of expected enum LIGHT_PROBE. All the other types such as GREASEPENCIL, CACHEFILE, WINDOWMANAGER, PAINTCURVE, LINESTYLE, etc work. LIGHT_PROBE is the only enum with an underscore. That is a consistency issue and also creates problems like in that code where you end up needing to resort to hard-coding additional unnecessary checks like if id_type == LIGHTPROBE: id_type = LIGHT_PROBE. LIGHT_PROBE enum should be renamaed to LIGHTPROBE for consistency.

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: NVIDIA GeForce GTX TITAN/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 473.04 **Blender Version** Broken: version: 3.4.0, branch: master (modified), commit date: 2022-12-07 11:39, hash: `rB175bd3820151` Worked: Never **Short description of error** This issue is not a bug but rather a consistency issue which I though is worth reporting. The following script works for all types defined in [Id Type Items](https://docs.blender.org/api/current/bpy_types_enum_items/id_type_items.html#rna-enum-id-type-items) except for `LIGHT_PROBE` which deviates from the naming convention used for all other types. Every enum type just concatenates all words together without an underscore like `GREASEPENCIL, CACHEFILE, WINDOWMANAGER, PAINTCURVE, LINESTYLE`, etc. I noticed this problem when I answered [this thread](https://blender.stackexchange.com/questions/290548/how-to-get-a-object-id-type-in-python/290717). **Exact steps for others to reproduce the error** 1. Create any Light Probe object via _Add > Light Probe_ 2. Run the following script: ``` def get_id_type(obj): return obj.bl_rna.identifier.upper() obj = bpy.data.lightprobes[0] id_type = get_id_type(obj) print("Id Type: ", id_type) ``` 3. Notice it prints `LIGHTPROBE` instead of expected enum `LIGHT_PROBE`. All the other types such as `GREASEPENCIL, CACHEFILE, WINDOWMANAGER, PAINTCURVE, LINESTYLE`, etc work. `LIGHT_PROBE` is the only enum with an underscore. That is a consistency issue and also creates problems like in that code where you end up needing to resort to hard-coding additional unnecessary checks like `if id_type == LIGHTPROBE: id_type = LIGHT_PROBE`. `LIGHT_PROBE` enum should be renamaed to `LIGHTPROBE` for consistency.

Harry McKenzie added the

labels 2023-04-15 04:39:49 +02:00

Harry McKenzie changed title from ~~Naming Inconsistency with LIGHT_PROBE being the only Id Type enum with an underscore~~ to Naming Inconsistency with LIGHT_PROBE causing problem

2023-04-15 04:48:15 +02:00

Iliya Katushenock added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Naming Inconsistency with LIGHT_PROBE causing problem #106978