Crash creating "position" attribute with the wrong type while in Edit mode #107232

New Issue

Closed

opened 2023-04-22 03:12:26 +02:00 by Thomas Barlow · 4 comments

Thomas Barlow commented

2023-04-22 03:12:26 +02:00

Member

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.41

Blender Version
Broken: 3.5.0 and 3.6.0 Alpha, branch: main, commit date: 2023-04-20 23:46, hash: 5721b34e5364
Worked:

Short description of error
While in Edit mode, attempting to create an attribute called "position" that has type not set to "FLOAT_VECTOR" will crash Blender.

I couldn't get any other attributes to crash when added while in Edit mode.
Creating the "position" attribute with the correct type, but incorrect domain does not cause a crash either.

I can't imagine a use case for users wanting to do this, but it came up while I was determining the extent of #107228 and isn't really the same issue.

Exact steps for others to reproduce the error

Select a mesh object
Enter Edit Mode
Either:
1. Run bpy.context.object.data.attributes.new("position", "FLOAT", "POINT") from the Python Console
2. Create a new attribute called "position" using the bpy.ops.geometry.attribute_add operator and set the Data Type to anything other than Vector:

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.41 **Blender Version** Broken: 3.5.0 and 3.6.0 Alpha, branch: main, commit date: 2023-04-20 23:46, hash: `5721b34e5364` Worked: **Short description of error** While in Edit mode, attempting to create an attribute called `"position"` that has type not set to `"FLOAT_VECTOR"` will crash Blender. I couldn't get any other attributes to crash when added while in Edit mode. Creating the `"position"` attribute with the correct type, but incorrect domain does not cause a crash either. I can't imagine a use case for users wanting to do this, but it came up while I was determining the extent of https://projects.blender.org/blender/blender/issues/107228 and isn't really the same issue. **Exact steps for others to reproduce the error** 1. Select a mesh object 1. Enter Edit Mode 1. Either: 1. Run `bpy.context.object.data.attributes.new("position", "FLOAT", "POINT")` from the Python Console 1. Create a new attribute called "position" using the `bpy.ops.geometry.attribute_add` operator and set the `Data Type` to anything other than `Vector`: ![image](/attachments/13556957-8f36-47b0-8088-a9c53a2c8397)

143 KiB

Thomas Barlow added the

labels 2023-04-22 03:12:27 +02:00

Iliya Katushenock added the

label 2023-04-22 10:02:12 +02:00

Jesse Yurkovich added

Nodes & Physics

and removed

labels 2023-04-22 23:30:51 +02:00

Philipp Oeser commented

2024-02-16 14:42:21 +01:00

Member

The crash is because positions are always accessed/treated as CD_PROP_FLOAT3 / float3 around code [without checking], but this is not a given if we let users create "builtin" attributes with other types.

@HooglyBoogly : shouldnt we really guard against creating attributes with used builtin names?

Here is another unfortunate case:

even if you create the "position" attribute with the correct type (Vector) in editmode, that will complete wipe/destroy the original coords
looks like this then:

going into objectmode afterwards then makes your mesh collapse.

Does the whole issue deserve High priority?
(will raise for the moment to get the crash out of the way, feel free to lower again though...)

The crash is because positions are always accessed/treated as `CD_PROP_FLOAT3` / `float3` around code [without checking], but this is not a given if we let users create "builtin" attributes with other types. @HooglyBoogly : shouldnt we really guard against creating attributes with used builtin names? Here is another unfortunate case: - even if you create the "position" attribute with the correct type (Vector) in editmode, that will complete wipe/destroy the original coords - looks like this then: ![image](/attachments/64297c32-b604-4282-81c4-c65d4c838b2a) going into objectmode afterwards then makes your mesh collapse. Does the whole issue deserve High priority? (will raise for the moment to get the crash out of the way, feel free to lower again though...)

221 KiB

Philipp Oeser added

and removed

labels 2024-02-16 14:42:31 +01:00

Hans Goudey commented

2024-02-16 14:49:57 +01:00

Member

shouldnt we really guard against creating attributes with used builtin names?

Yes, we should. The difference in builtin attributes between BMesh and other areas is a problem area.

You sort of have to go out of your way to do this though, which is why I didn't prioritize making it safer so far. But other perspectives make sense too.

> shouldnt we really guard against creating attributes with used builtin names? Yes, we should. The difference in builtin attributes between BMesh and other areas is a problem area. You sort of have to go out of your way to do this though, which is why I didn't prioritize making it safer so far. But other perspectives make sense too.

Hans Goudey added

and removed

labels 2024-02-16 14:52:44 +01:00

Hans Goudey self-assigned this 2024-03-05 22:30:45 +01:00

Hans Goudey referenced a pull request that will close this issue

2024-03-06 06:44:23 +01:00

Fix #107232: Creating builtin attributes in edit mode can cause crash #119110

Hans Goudey referenced this issue from a commit

2024-03-06 16:16:55 +01:00

Fix #107232: Creating builtin attributes in edit mode can cause crash

Hans Goudey closed this issue

2024-03-06 16:16:58 +01:00

Blender Bot added

and removed

labels 2024-03-06 16:16:59 +01:00

Philipp Oeser commented

2024-03-07 08:38:42 +01:00

Member

I assume we want this bckported to 3.6 LTS @HooglyBoogly ?

I assume we want this bckported to 3.6 LTS @HooglyBoogly ?

Hans Goudey commented

2024-03-07 14:01:52 +01:00

Member

Sure, couldn't hurt, it's a pretty simple change.

Sure, couldn't hurt, it's a pretty simple change.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107232

No description provided.