Node group assets in add menu do not work with quick favorites #107383

New Issue

Open

opened 2023-04-26 19:57:34 +02:00 by Sun Kim · 5 comments

Sun Kim commented

2023-04-26 19:57:34 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.61

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-25 23:13, hash: 91020ccde15a
Worked: n/a

Node groups assets in the add menu was introduced in 3.4.

Short description of error
Right click on node group assets in the add menu brings up Add to Quick Favorites operator but they don't work with quick favorites.

If you register a submenu it just shows an empty box in quick favorites. If it's a node group asset, it does not add the asset.

Also all of the group assets and menus try to use the same quick favorite slot.

Exact steps for others to reproduce the error

In Geometry Nodes editor's add menu, right click on Hair menu or the assets under it
Add to Quick Favorites
Bring up Quick Favorites, and try to use the item just registered

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.61 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-25 23:13, hash: `91020ccde15a` Worked: n/a Node groups assets in the add menu was introduced in 3.4. **Short description of error** Right click on node group assets in the add menu brings up `Add to Quick Favorites` operator but they don't work with quick favorites. If you register a submenu it just shows an empty box in quick favorites. If it's a node group asset, it does not add the asset. Also all of the group assets and menus try to use the same quick favorite slot. **Exact steps for others to reproduce the error** - In Geometry Nodes editor's add menu, right click on Hair menu or the assets under it - Add to Quick Favorites - Bring up Quick Favorites, and try to use the item just registered

Sun Kim added the

labels 2023-04-26 19:57:35 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-04-26 20:19:58 +02:00

Richard Antalik added

and removed

labels 2023-04-27 02:10:09 +02:00

Philipp Oeser commented

2023-05-03 10:50:15 +02:00

Member

Will check on this.

Will check on this.

Philipp Oeser self-assigned this 2023-05-03 10:50:24 +02:00

Julian Eisel commented

2023-05-05 16:47:43 +02:00

Member

I'd simply consider this unsupported for now. It's not a code error that causes this, additional changes are needed to introduce support for such operators in the quick favorites.

If we decide to store some asset reference in the quick favorites storage, better to use AssetWeakReference over naked paths, it's designed for such use-cases.

I'd simply consider this unsupported for now. It's not a code error that causes this, additional changes are needed to introduce support for such operators in the quick favorites. If we decide to store some asset reference in the quick favorites storage, better to use `AssetWeakReference` over naked paths, it's designed for such use-cases.

Sun Kim commented

2023-09-26 14:15:10 +02:00

Author

Contributor

75d788f2d3 solved half of this issue. Adding individual assets to quick favorites works now.

75d788f2d3 solved half of this issue. Adding individual assets to quick favorites works now.

Philipp Oeser commented

2024-03-27 14:18:50 +01:00

Member

Stepping down since I currently do not plan on actually working on this

Stepping down since I currently do not plan on actually working on this

Philipp Oeser removed their assignment 2024-03-27 14:18:58 +01:00

Julian Eisel commented

2024-03-27 17:12:31 +01:00

Member

What exactly is there that is not working still? I guess adding the submenus to quick favorites? The way we build those sub-menus dynamically from catalogs seems incompatible with the way quick favorites work. We build the menus by storing the catalog-path in the layout context, which the menu's draw callback queries to filter the items/sub-menus. I don't think we can pass this layout context to the quick favorites storage.

We could get this to work by supporting ID-properties for invoking menus, similar to how operator properties work. These would then have to be stored alongside the menu-type to be invoked, again like we do it for operators. I don't think this is too difficult, but will require some work still. I think meanwhile we should consider this a known limitation.

What exactly is there that is not working still? I guess adding the submenus to quick favorites? The way we build those sub-menus dynamically from catalogs seems incompatible with the way quick favorites work. We build the menus by storing the catalog-path in the layout context, which the menu's draw callback queries to filter the items/sub-menus. I don't think we can pass this layout context to the quick favorites storage. We could get this to work by supporting ID-properties for invoking menus, similar to how operator properties work. These would then have to be stored alongside the menu-type to be invoked, again like we do it for operators. I don't think this is too difficult, but will require some work still. I think meanwhile we should consider this a known limitation.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107383

No description provided.