Regression: Can`t select ruler or click it to make andgular ruler. #107570

New Issue

Closed

opened 2023-05-03 02:24:31 +02:00 by Vyacheslav Kobozev · 19 comments

Vyacheslav Kobozev commented

2023-05-03 02:24:31 +02:00

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.95

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-05-01 20:15, hash: 0652945dbda7
Broken: 3.6.0 Alpha, 993d24c1749c, 2023-04-23 19:27
Worked: 3.6.0 Alpha, e078419c9c12, 2023-04-14 22:58
probably caused by f87e474af0

Exact steps for others to reproduce the error
Select measurement tool, drag a line/ruler, drag another one, try to click the first one to select.
2023-05-03_03-14-53.mp4

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.95 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-05-01 20:15, hash: `0652945dbda7` Broken: 3.6.0 Alpha, `993d24c1749c`, 2023-04-23 19:27 Worked: 3.6.0 Alpha, `e078419c9c12`, 2023-04-14 22:58 probably caused by f87e474af0 **Exact steps for others to reproduce the error** Select measurement tool, drag a line/ruler, drag another one, try to click the first one to select. [2023-05-03_03-14-53.mp4](/attachments/863789af-45b2-49cb-b221-c6eb1799f344)

2023-05-03_03-14-53.mp4

2.9 MiB

Vyacheslav Kobozev added the

labels 2023-05-03 02:24:31 +02:00

Pratik Borhade commented

2023-05-03 08:25:25 +02:00

Member

Thanks for the report. Can confirm. Bisecting...

Thanks for the report. Can confirm. Bisecting...

Pratik Borhade added

and removed

labels 2023-05-03 08:25:49 +02:00

YimingWu commented

2023-05-03 08:29:27 +02:00

Member

Hello @Vyach , looks like the ruler has already been working normally here on today's build. You could try a latest build and see if it works. I guess it was probably some other viewport draw/selection changes that temporarily broke the thing.

Hello @Vyach , looks like the ruler has already been working normally here on today's build. You could try a latest build and see if it works. I guess it was probably some other viewport draw/selection changes that temporarily broke the thing.

Pratik Borhade added

Needs Information from User

and removed

labels 2023-05-03 08:35:26 +02:00

Pratik Borhade commented

2023-05-03 09:08:20 +02:00

Member

Can confirm in 3.6-d5fc1b9ba4b8 buildbot build :/
I don't see any commits after d5fc1b9ba4 which would fix the issue.

Can confirm in 3.6-d5fc1b9ba4b8 buildbot build :/ I don't see any commits after d5fc1b9ba4b8 which would fix the issue.

YimingWu commented

2023-05-03 09:31:43 +02:00

Member

Interesting... Let me test if there's any specific input key setup that might interfere with this

Interesting... Let me test if there's any specific input key setup that might interfere with this

Philipp Oeser commented

2023-05-03 10:14:45 +02:00

Member

Sorry, that previous comment was ... misunderstanding the tool.

So, I cant really repro this either
@Harley : since this seems to be a recent regression, can you repro after b367a2b5f9 ?

Sorry, that previous comment was ... misunderstanding the tool. So, I cant really repro this either @Harley : since this seems to be a recent regression, can you repro after b367a2b5f9befbc946cd215760e1ea04abe3e5fc ?

Pratik Borhade commented

2023-05-03 13:10:12 +02:00

Member

AFAICS this problem introduced between bd86e719ab - 993d24c174 (but can not trigger this on lite build)
Either an OpenGL issue or introduced by C -> Cpp porting: f87e474af0

AFAICS this problem introduced between bd86e719ab91 - 993d24c1749c (but can not trigger this on lite build) Either an OpenGL issue or introduced by C -> Cpp porting: f87e474af00483dd3516fc2f6b36b1dffb89f678

Vyacheslav Kobozev commented

2023-05-03 15:57:26 +02:00

Author

issue still here in the fresh build
3.6.0 Alpha, d5fc1b9ba4b8, 2023-05-02 21:24

issue still here in the fresh build 3.6.0 Alpha, `d5fc1b9ba4b8`, 2023-05-02 21:24

Harley Acheson commented

2023-05-03 19:28:27 +02:00

Member

I can confirm the reported behavior in the last buildbot nightly build - blender-3.6.0-alpha+main.d5fc1b9ba4b8-windows.amd64-release.zip. The quickest indication of the problem is that the mouse cursor does not change to a "four-pointed arrow" cursor on the endpoints or to a "plus" cursor at an angle point.

But (so far) not able to recreate while compiling main. Not seeing any commits between 2023-04-14 and 2023-04-23 that would explain it.

I can confirm the reported behavior in the last buildbot nightly build - blender-3.6.0-alpha+main.d5fc1b9ba4b8-windows.amd64-release.zip. The quickest indication of the problem is that the mouse cursor does not change to a "four-pointed arrow" cursor on the endpoints or to a "plus" cursor at an angle point. But (**so far**) not able to recreate while compiling main. Not seeing any commits between 2023-04-14 and 2023-04-23 that would explain it.

Harley Acheson commented

2023-05-03 22:46:10 +02:00

Member

This features works as expected when I compile (lite or Full) myself. But the same code on the buildbot breaks.

For the nightlies this worked on April 19th (45c0762f1b) but was broken on April 20th (f87e474af0)

This features works as expected when I compile (lite or Full) myself. But the same code on the buildbot breaks. For the nightlies this worked on April 19th (45c0762f1b9b) but was broken on April 20th (f87e474af004)

Harley Acheson commented

2023-05-03 23:29:50 +02:00

Member

view3d_gizmo_ruler.cc changed from C to C++ on April 19th, the last day it worked. So this is looking like a compiler issue. It is working correctly when compiled on VS 2022 but not working correctly if compiled on the version of VS 2019 that is on the buildbots?

`view3d_gizmo_ruler.cc` changed from C to C++ on **April 19th**, the last day it worked. So this is looking like a compiler issue. It is working correctly when compiled on VS 2022 but not working correctly if compiled on the version of VS 2019 that is on the buildbots?

Pratik Borhade commented

2023-05-04 07:28:00 +02:00

Member

So Harley and me both observing this issue in buildbot build but not in a build from source.
Confirming again.

So Harley and me both observing this issue in buildbot build but not in a build from source. Confirming again.

Pratik Borhade added

and removed

Needs Information from User

labels 2023-05-04 07:28:20 +02:00

Pratik Borhade changed title from ~~Can`t select ruler or click it to make andgular ruler.~~ to Regression: Can`t select ruler or click it to make andgular ruler.

2023-05-04 07:29:36 +02:00

Philipp Oeser commented

2023-05-04 09:22:45 +02:00

Member

Just noting that daily buildbot builds on linux are fine.

Just noting that daily buildbot builds on linux are fine.

Philipp Oeser added the

Platforms, Builds & Tests

labels 2023-05-04 09:23:22 +02:00

Harley Acheson commented

2023-05-04 17:49:11 +02:00

Member

I'm not observing this issue with the project built for, and loaded into VS 2019 .29.30133. The buildbots are on .29.30139.0. So this might not be a strictly compiler version issue. Possibly a configuration difference on the bot?

@LazyDodo has asked for details from the bot including a copy of the CMakeCache.txt so we can see that actual versions, build flags, etc. And also about the behavior of building with the "clean" flag, ie "does it wipe the whole build dir or just runs an extra ninja -t clean / make clean?"

I'm not observing this issue with the project built for, and loaded into **VS 2019** .29.30133. The buildbots are on .29.30139.0. So this might not be a strictly compiler version issue. Possibly a configuration difference on the bot? @LazyDodo has asked for details from the bot including a copy of the CMakeCache.txt so we can see that actual versions, build flags, etc. And also about the behavior of building with the "clean" flag, ie "does it wipe the whole build dir or just runs an extra ninja -t clean / make clean?"

Ray molenkamp commented

2023-05-05 01:41:41 +02:00

Member

This reproduces on VS 16.11.9 ONLY older is fine, newer is fine as well , it's easy to sidestep with something like this (but that does add a warn for ninja about /Ob2 and /Ob0 being supplied, i can't seem to disable, nor is there an easy way to remove something from the CXX flags for a single compile unit)

diff --git a/source/blender/editors/space_view3d/CMakeLists.txt b/source/blender/editors/space_view3d/CMakeLists.txt
index 747e3a537fa..df70081a348 100644
--- a/source/blender/editors/space_view3d/CMakeLists.txt
+++ b/source/blender/editors/space_view3d/CMakeLists.txt
@@ -97,3 +97,8 @@ blender_add_lib(bf_editor_space_view3d "${SRC}" "${INC}" "${INC_SYS}" "${LIB}")
 add_dependencies(bf_editor_space_view3d bf_dna)
 # RNA_prototypes.h
 add_dependencies(bf_editor_space_view3d bf_rna)
+
+if(MSVC) # MSVC has a codegen bug in this file in 16.11.9
+  SET_SOURCE_FILES_PROPERTIES(view3d_gizmo_ruler.cc PROPERTIES COMPILE_FLAGS /Ob0)
+endif()
+

I can't narrow it down any further, there is no amount of turning the optimizer on/off on a per function basis that seems to make this problem go away.

Given I don't know where else this codegen bug is going to popup and the rate things are being converted to C++ the fix i'd like to see is to bump the CI env to a newer MSVC version however this will have some implications for the LTS releases that should probably be discussed outside of this ticket.

cc: @Arnd , @brecht

This reproduces on VS 16.11.9 _ONLY_ older is fine, newer is fine as well , it's easy to sidestep with something like this (but that does add a warn for ninja about /Ob2 and /Ob0 being supplied, i can't seem to disable, nor is there an easy way to remove something from the CXX flags for a single compile unit) ```Diff diff --git a/source/blender/editors/space_view3d/CMakeLists.txt b/source/blender/editors/space_view3d/CMakeLists.txt index 747e3a537fa..df70081a348 100644 --- a/source/blender/editors/space_view3d/CMakeLists.txt +++ b/source/blender/editors/space_view3d/CMakeLists.txt @@ -97,3 +97,8 @@ blender_add_lib(bf_editor_space_view3d "${SRC}" "${INC}" "${INC_SYS}" "${LIB}") add_dependencies(bf_editor_space_view3d bf_dna) # RNA_prototypes.h add_dependencies(bf_editor_space_view3d bf_rna) + +if(MSVC) # MSVC has a codegen bug in this file in 16.11.9 + SET_SOURCE_FILES_PROPERTIES(view3d_gizmo_ruler.cc PROPERTIES COMPILE_FLAGS /Ob0) +endif() + ``` I can't narrow it down any further, there is no amount of turning the optimizer on/off on a per function basis that seems to make this problem go away. Given I don't know where else this codegen bug is going to popup and the rate things are being converted to C++ the fix i'd like to see is to bump the CI env to a newer MSVC version however this will have some implications for the LTS releases that should probably be discussed outside of this ticket. cc: @Arnd , @brecht

Brecht Van Lommel commented

2023-05-05 18:07:30 +02:00

Owner

I've installed VS 16.11.26.0 on the uatest buildbot, it's building now.
https://builder-uatest.blender.org/admin/#/builders/18/builds/920
https://builder-uatest.blender.org/admin/#/builders/164/builds/12
https://builder-uatest.blender.org/download/daily/

If these builds work we can roll out the same thing to the production buildbot.

For my own reference, the commands to upgrade:

choco pin remove -n=visualstudio2019community
choco pin remove -n=visualstudio2019-workload-nativedesktop
choco upgrade visualstudio2019community visualstudio2019-workload-nativedesktop
choco pin add -n=visualstudio2019community
choco pin add -n=visualstudio2019-workload-nativedesktop

I've installed VS 16.11.26.0 on the uatest buildbot, it's building now. https://builder-uatest.blender.org/admin/#/builders/18/builds/920 https://builder-uatest.blender.org/admin/#/builders/164/builds/12 https://builder-uatest.blender.org/download/daily/ If these builds work we can roll out the same thing to the production buildbot. For my own reference, the commands to upgrade: ``` choco pin remove -n=visualstudio2019community choco pin remove -n=visualstudio2019-workload-nativedesktop choco upgrade visualstudio2019community visualstudio2019-workload-nativedesktop choco pin add -n=visualstudio2019community choco pin add -n=visualstudio2019-workload-nativedesktop ```

Brecht Van Lommel commented

2023-05-05 19:34:55 +02:00

Owner

Can someone confirm if the issue is solved in the 3.6 build here?
https://builder-uatest.blender.org/download/daily/

Can someone confirm if the issue is solved in the 3.6 build here? https://builder-uatest.blender.org/download/daily/

Harley Acheson commented

2023-05-05 19:46:54 +02:00

Member

checking

checking

Harley Acheson commented

2023-05-05 19:54:15 +02:00

Member

It works!!!!

It works!!!!

Brecht Van Lommel commented

2023-05-05 20:47:33 +02:00

Owner

Thanks for confirming, the production buildbot has been updated as well now. So this should be fixed in the next daily build.

Thanks for confirming, the production buildbot has been updated as well now. So this should be fixed in the next daily build.

Brecht Van Lommel closed this issue

2023-05-05 20:47:35 +02:00

Blender Bot added

and removed

labels 2023-05-05 20:47:36 +02:00

YimingWu referenced this issue

2023-05-11 09:13:25 +02:00

Regression: Missing snap gizmo in multiple viewport instances #107830

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107570

No description provided.