Name filtering for Asset Shelf assets #107784

New Issue

Dalai Felinto · 2023-05-09T15:47:06+02:00

Dalai Felinto commented

2023-05-09 15:47:06 +02:00

We need to have a way for animators to filter the assets based on the name, similar to how it was possible in the current/old Pose Library panel.

Dalai Felinto added the

Type

To Do

label 2023-05-09 15:47:06 +02:00

Dalai Felinto added this to the Brush Assets & Asset Shelf project 2023-05-09 15:47:07 +02:00

Dalai Felinto referenced this issue

2023-05-09 16:00:57 +02:00

Get pose library asset shelf ready for merge into main, experimental feature #107498

Julian Eisel commented

2023-05-10 21:51:40 +02:00

For now I think it's enough to implement this for the grid view only, it can be generalized easily later.

Notes on how this could be implemented:

Store a filter string in AssetShelfSettings.
Add a virtual ui::AbstractGridViewItem::is_filtered_visible() (returns true in the default implementation).
Override it to perform name filtering in ed::asset::shelf::AssetView (asset_shelf_asset_view.cc).
Add a ui::AbstractGridViewItem::foreach_filtered_item() iterator that calls it.
Use that instead of foreach_item in GridViewLayoutBuilder::build_from_view()
BuildOnlyVisibleButtonsHelper::fill_layout_after_visible() needs to get the count of visible items, not the total item count.
Optionally: foreach_filtered_item() could avoid re-filtering all the time, by storing the result in the item (e.g. something like a {"filtered_visible", "filtered_hidden", "filter_pending"} enum).

This would filter drawn items, but wouldn't remove grid items from storage, which is important to keep state like selection and active of the items.

For now I think it's enough to implement this for the grid view only, it can be generalized easily later. Notes on how this could be implemented: - Store a filter string in `AssetShelfSettings`. - Add a virtual `ui::AbstractGridViewItem::is_filtered_visible()` (returns true in the default implementation). - Override it to perform name filtering in `ed::asset::shelf::AssetView` (`asset_shelf_asset_view.cc`). - Add a `ui::AbstractGridViewItem::foreach_filtered_item()` iterator that calls it. - Use that instead of `foreach_item` in `GridViewLayoutBuilder::build_from_view()` - `BuildOnlyVisibleButtonsHelper::fill_layout_after_visible()` needs to get the count of visible items, not the total item count. - Optionally: `foreach_filtered_item()` could avoid re-filtering all the time, by storing the result in the item (e.g. something like a {"filtered_visible", "filtered_hidden", "filter_pending"} enum). This would filter drawn items, but wouldn't remove grid items from storage, which is important to keep state like selection and active of the items.

Julian Eisel referenced this issue

2023-05-18 02:01:53 +02:00

UI: Asset Shelf (Experimental Feature) #104831

Julian Eisel commented

2023-06-08 17:45:36 +02:00

Implemented with 8848a78111 & 86e72999dd.

Implemented with 8848a78111 & 86e72999dd.

Julian Eisel closed this issue

2023-06-08 17:45:38 +02:00

Blender Bot added the

Status

Archived