Vertex paint mode breaks permanently under certain conditions (Global undo involved) #107845

Open
opened 2023-05-11 15:13:05 +02:00 by Philipp Oeser · 3 comments
Member

System Information
Operating system: Linux-6.1.18-200.fc37.x86_64-x86_64-with-glibc2.36 64 Bits, WAYLAND UI
Graphics card: AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.49, 6.1.18-200.fc37.x86_64) AMD 4.6 (Core Profile) Mesa 22.3.7

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-05-07 23:20, hash: 893bd37bc035

Caused by 575ade22d4 (vertex paint now does SCULPT_undo_push_begin_ex in wpaint_invoke [which leads to BKE_undosys_step_push using sculpt undo])

Short description of error
Vertex paint mode breaks permanently under certain conditions

Exact steps for others to reproduce the error

  • turn OFF Global undo in Preferences
  • enter vertex paint mode on the default cube (a color attribute is created)
  • make two strokes
  • Undo (prior to 575ade22d4 nothing was undone, now stroke is actually undone)
  • Undo again (this now takes you out of vertexpaint mode into object mode prior to 575ade22d4 you would never leave vertexpaint mode -- color attribute is also removed)
  • enter vertex paint mode again
  • painting is not possible anymore (strokes have no effect)
  • this is also true for other objects
**System Information** Operating system: Linux-6.1.18-200.fc37.x86_64-x86_64-with-glibc2.36 64 Bits, WAYLAND UI Graphics card: AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.49, 6.1.18-200.fc37.x86_64) AMD 4.6 (Core Profile) Mesa 22.3.7 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-05-07 23:20, hash: `893bd37bc035` Caused by 575ade22d4de (vertex paint now does `SCULPT_undo_push_begin_ex` in wpaint_invoke [which leads to `BKE_undosys_step_push` using sculpt undo]) **Short description of error** Vertex paint mode breaks permanently under certain conditions **Exact steps for others to reproduce the error** - turn OFF Global undo in Preferences - enter vertex paint mode on the default cube (a color attribute is created) - make two strokes - Undo (prior to 575ade22d4de nothing was undone, now stroke is actually undone) - Undo again (this now takes you out of vertexpaint mode into object mode prior to 575ade22d4de you would never leave vertexpaint mode -- color attribute is also removed) - enter vertex paint mode again - painting is not possible anymore (strokes have no effect) - this is also true for other objects
Julien Kaspar added
Type
Bug
and removed
Type
Report
labels 2023-07-04 09:53:58 +02:00

I tested this from main, and it looks fixed to me. Here's a gif of me trying the steps outlined here:
vtx_paint.gif

Not sure what that means next.

I tested this from main, and it looks fixed to me. Here's a gif of me trying the steps outlined here: ![vtx_paint.gif](/attachments/80ede630-2bfd-4bc5-b882-a50a97338e23) Not sure what that means next.
Member

@lichtwerk hi, can you check again? I'm not able to confirm this. BTW, now we have #116029

@lichtwerk hi, can you check again? I'm not able to confirm this. BTW, now we have #116029
Author
Member

I can still reproduce this (but yeah indeed you have to start from the default cube, so comment from #116029 is right, Undo needs to delete the color attribute for the bug to kick in -- will update the description).

So the situation seems to have gotten worse, will bisect #116029 to see when...)

I can still reproduce this (but yeah indeed you have to start from the default cube, so comment from #116029 is right, Undo needs to delete the color attribute for the bug to kick in -- will update the description). So the situation seems to have gotten worse, will bisect #116029 to see when...)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107845
No description provided.