Reroute node draws the same way for "selected" and "active", cause confusion. #108028

New Issue

Peter · 2023-05-18T00:17:44+02:00

Peter commented

2023-05-18 00:17:44 +02:00

System Information
Operating system: Windows 10 Pro, OS build 19045.2846
Graphics card: Nvidia RTX 3090

Blender Version
Broken: Today's daily build and every build of blender 3.6 I have (mostly the simulation nodes branch)
Worked: I can't find a version where it works any earlier than end of February, one of them crashed on startup and it's preventing earlier builds from starting.

Short description of error:

Reroute node draws the same way for "selected" and "active", they both appears to be "active", cause confusion on operations such as F2 renaming/labelling, as the user won't know which one is the one being operated on.

Original description:

Renaming reroute nodes seem to be inconsistent when pasting them from existing unconnected reroute nodes.
I use empty reroutes to comment on graphs as an alternative to creating text blocks.

Exact steps for others to reproduce the error:

Add a reroute node from the add menu
Rename it with the f2 shortcut
Copy and paste it
Rename the second node
Act slightly confused

**System Information** Operating system: Windows 10 Pro, OS build 19045.2846 Graphics card: Nvidia RTX 3090 **Blender Version** Broken: Today's daily build and every build of blender 3.6 I have (mostly the simulation nodes branch) Worked: I can't find a version where it works any earlier than end of February, one of them crashed on startup and it's preventing earlier builds from starting. **Short description of error:** Reroute node draws the same way for "selected" and "active", they both appears to be "active", cause confusion on operations such as `F2` renaming/labelling, as the user won't know which one is the one being operated on. ![图片](/attachments/5bb5a929-7a90-4678-85eb-2707d93a4cf3) --------- Original description: Renaming reroute nodes seem to be inconsistent when pasting them from existing unconnected reroute nodes. I use empty reroutes to comment on graphs as an alternative to creating text blocks. **Exact steps for others to reproduce the error:** 1. Add a reroute node from the add menu 2. Rename it with the f2 shortcut 3. Copy and paste it 4. Rename the second node 5. Act slightly confused

reroute paste behaviour.mp4

17 MiB

👍 1 👀 1

Peter added the

labels 2023-05-18 00:17:45 +02:00

Peter changed title from ~~Renaming pasted reroute nodes will instead rename the node it was copied from2~~ to Renaming pasted reroute nodes will instead rename the node it was copied from

2023-05-18 00:22:08 +02:00

Iliya Katushenock commented

2023-05-18 06:29:23 +02:00

It's an addon bug, isn't it?

YimingWu commented

2023-05-18 07:37:00 +02:00

@mod_moder I don't think this is an addon bug. It's rather a display bug.

The thing is F2 renames the active node, but box select won't change the active node, because box select could be selecting multiple nodes, and it can also extend selection. And the problem here I believe is that reroute nodes all drew the same way for "selected" and "active", so that's a confusion.

Expected behaviour is "selected" but "not active" nodes should have yellow outline other than white (selected color rather than active color).

In source/blender/editors/space_node/node_draw.cc Line 3013: It only differentiate between selected or not. cc @HooglyBoogly @JacquesLucke

  /* Only draw input socket as they all are placed on the same position highlight
   * if node itself is selected, since we don't display the node body separately. */
  node_draw_sockets(region.v2d, C, ntree, node, block, false, node.flag & SELECT);

@mod_moder I don't think this is an addon bug. It's rather a display bug. The thing is `F2` renames the active node, but box select won't change the active node, because box select could be selecting multiple nodes, and it can also extend selection. And the problem here I believe is that reroute nodes all drew the same way for "selected" and "active", so that's a confusion. Expected behaviour is "selected" but "not active" nodes should have yellow outline other than white (selected color rather than active color). ![图片](/attachments/5bb5a929-7a90-4678-85eb-2707d93a4cf3) In `source/blender/editors/space_node/node_draw.cc` Line 3013: It only differentiate between selected or not. cc @HooglyBoogly @JacquesLucke ``` /* Only draw input socket as they all are placed on the same position highlight * if node itself is selected, since we don't display the node body separately. */ node_draw_sockets(region.v2d, C, ntree, node, block, false, node.flag & SELECT); ```

图片.png

1.5 KiB

YimingWu added

and removed

labels 2023-05-18 07:37:27 +02:00

YimingWu changed title from ~~Renaming pasted reroute nodes will instead rename the node it was copied from~~ to Reroute node draws the same way for "selected" and "active", cause confusion.

2023-05-18 07:38:05 +02:00

Leon Schittek commented

2023-05-18 08:01:49 +02:00

@ChengduLittleA What you're saying is true, but I think the original report was describing a different issue.

When pasing nodes it properly shows the newly pasted node as active but when using F2 to rename it it will rename the previously active node. For some reason the active node is not really updated? This can also be reproduced with nodes other than the reroute (see attached video).

@ChengduLittleA What you're saying is true, but I think the original report was describing a different issue. When pasing nodes it properly shows the newly pasted node as active but when using `F2` to rename it it will rename the previously active node. For some reason the active node is not really updated? This can also be reproduced with nodes other than the reroute (see attached video).

label-after-paste.mp4

177 KiB

👀 1

YimingWu commented

2023-05-18 08:49:34 +02:00

Yeah I can confirm that. Pretty weird.

Edit: I reported this as a separate issue #108036.

Yeah I can confirm that. Pretty weird. Edit: I reported this as a separate issue #108036.

👍 2

Iliya Katushenock referenced this issue

2023-05-18 15:54:50 +02:00

Nodes: Copy-pasting nodes makes many active nodes #108049