Sculpt: Expand mask by topology doesn't invert the mask #108164

New Issue

Closed

opened 2023-05-23 00:12:02 +02:00 by Lucas · 3 comments

Lucas commented

2023-05-23 00:12:02 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.41

Blender Version
Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-05-21 17:38, hash: 52f991b1a9b3
Broken: 3.5
Worked: 3.4

Behavior changed in dce7917717

Short description of error
Expand mask by topology doesn't invert the mask when pressing F as it should

Exact steps for others to reproduce the error
While in sculpt mode press shift+a on a mesh and define a mask, press F, it clears the mask instead of inverting it.
I know this worked inverted by default (object appeared masked first and you defined the unmasked area first) but was recently changed (for whatever reason). Pressing F worked fine though.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.41 **Blender Version** Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-05-21 17:38, hash: `52f991b1a9b3` Broken: 3.5 Worked: 3.4 Behavior changed in dce7917717 **Short description of error** Expand mask by topology doesn't invert the mask when pressing F as it should **Exact steps for others to reproduce the error** While in sculpt mode press shift+a on a mesh and define a mask, press F, it clears the mask instead of inverting it. I know this worked inverted by default (object appeared masked first and you defined the unmasked area first) but was recently changed (for whatever reason). Pressing F worked fine though.

Lucas added the

labels 2023-05-23 00:12:03 +02:00

Iliya Katushenock added the

Sculpt, Paint & Texture

label 2023-05-23 07:34:54 +02:00

Philipp Oeser commented

2023-05-23 09:46:46 +02:00

Member

Can confirm, will check.

NOTE: 3.4 was fine, 3.5 is already broken for me.

Can confirm, will check. NOTE: 3.4 was fine, 3.5 is already broken for me.

Philipp Oeser added

Sculpt, Paint & Texture

and removed

Sculpt, Paint & Texture

labels 2023-05-23 09:47:07 +02:00

Philipp Oeser commented

2023-05-23 10:40:32 +02:00

Member

Behavior changed in dce7917717

So to get the previous behavior, it seems you have to not only use F, but also E in addition.
This might turn out to be an intentional change, not quite sure I read the commit message right :

If the current behavior is desired for an expand operation the user can use E & F in the modal keymap (Which is less often the case).

Reading up on #97903 also doesnt really make it clearer for me, right now, we are still defining masked (as in not affected by sculpting) with the expand mask operator -- and to truly invert, this is now even a button push more than it was previously?

I would like feedback from @JulienKaspar and @JosephEagar .
Will raise prio since (if this turns out to be a regression) the commit is still in the timeframe of "recent" (~ 6 months)

Behavior changed in dce7917717cd9f07466651cdb9659a247f1a19ee So to get the previous behavior, it seems you have to not only use F, but also E in addition. This might turn out to be an intentional change, not quite sure I read the commit message right : > - If the current behavior is desired for an expand operation the user can use `E` & `F` in the modal keymap (Which is less often the case). Reading up on #97903 also doesnt really make it clearer for me, right now, we are still defining masked (as in not affected by sculpting) with the expand mask operator -- and to truly invert, this is now even a button push more than it was previously? I would like feedback from @JulienKaspar and @JosephEagar . Will raise prio since (if this turns out to be a regression) the commit is still in the timeframe of "recent" (~ 6 months)

Philipp Oeser added

and removed

labels 2023-05-23 10:41:11 +02:00

Julien Kaspar commented

2023-05-23 10:58:28 +02:00

Member

Yes to get the old behavior you need to press F to Invert the effect and press E to no longer preserve the previous mask.
Both in combination will umask everything outside the expanded area instead of clearing the mask.

The recommended way to do this is to use mask expand with the default behavior and then invert the mask via the pie menu on A.
This is the workflow for creating masks in every other tool/brush as well.

Like the commit says this can be customized in the keymap preferences.
But the new behavior is much more flexible & desirable by default because of the listed reasons.

Yes to get the old behavior you need to press `F` to Invert the effect and press `E` to no longer preserve the previous mask. Both in combination will umask everything outside the expanded area instead of clearing the mask. The recommended way to do this is to use mask expand with the default behavior and then invert the mask via the pie menu on `A`. This is the workflow for creating masks in every other tool/brush as well. Like the commit says this can be customized in the keymap preferences. But the new behavior is much more flexible & desirable by default because of the listed reasons.

Julien Kaspar closed this issue

2023-05-23 10:58:30 +02:00

Blender Bot added

and removed

labels 2023-05-23 10:58:32 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project (Legacy)

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108164

No description provided.