I18n: translation does not occur when started from a thread which isn’t main #108206

New Issue

Damien Picard · 2023-05-23T21:25:24+02:00

Damien Picard commented

2023-05-23 21:25:24 +02:00

System Information
Operating system: Linux-6.2.0-20-generic-x86_64-with-glibc2.37 64 Bits, X11 UI

Blender Version
Broken: version: 3.6.0 Beta

Short description of error
In some circumstances, translation of a message is started from a secondary thread. But before translating, the BLT_translate() function checks that translation can proceed, in the following way:

bool BLT_translate(void)
{
#ifdef WITH_INTERNATIONAL
  return BLI_thread_is_main();
#else
  return false;
#endif
}

The result is that some messages will never be translated. So far I could locate two areas where this happens:

in some geometry nodes socket tooltips, see !107260;
in error reports from the USD exporter.

The decision comes from 2be1d8bbaf, which solves an issue with the boost::locale library (#56770). It is unclear whether this issue was solved since then. The ticket on Boost’s old tracker is here.

The commit did mention at the time:

This may be an annoying limit at some point, but doubt it will be any issue currently.

Exact steps for others to reproduce the error
To reproduce the issue with the USD exporter:

Choose a language that was recently translated (Catalan or French) from the User Preferences, after updating the translation MO files if needed
Open the attached blend file curve.blend (contains an object with one cyclic curve and one non-cyclic curve, which is unsupported by USD).
Export the object to USD
The following message appears: "Cannot export mixed cyclic and non-cyclic curves in the same Curves object", untranslated.
In BLT_translate(), change return BLI_thread_is_main(); to return true; and rebuild
Export the object again
The message appears again, but it is now translated.

**System Information** Operating system: Linux-6.2.0-20-generic-x86_64-with-glibc2.37 64 Bits, X11 UI **Blender Version** Broken: version: 3.6.0 Beta **Short description of error** In some circumstances, translation of a message is started from a secondary thread. But before translating, the `BLT_translate()` function checks that translation can proceed, in the following way: ```c bool BLT_translate(void) { #ifdef WITH_INTERNATIONAL return BLI_thread_is_main(); #else return false; #endif } ``` The result is that some messages will never be translated. So far I could locate two areas where this happens: 1. in some geometry nodes socket tooltips, see !107260; 2. in error reports from the USD exporter. The decision comes from 2be1d8bbaf, which solves an issue with the boost::locale library (#56770). It is unclear whether this issue was solved since then. The ticket on Boost’s old tracker is [here](http://trac.cpp.al/trac10/ticket/6320). The commit did mention at the time: > This *may* be an annoying limit at some point, but doubt it will be any issue currently. **Exact steps for others to reproduce the error** To reproduce the issue with the USD exporter: - Choose a language that was recently translated (Catalan or French) from the User Preferences, after updating the translation MO files if needed - Open the attached blend file [curve.blend](/attachments/e2f7219d-bf82-4844-a13f-d7f7b1a443a3) (contains an object with one cyclic curve and one non-cyclic curve, which is unsupported by USD). - Export the object to USD - The following message appears: "Cannot export mixed cyclic and non-cyclic curves in the same Curves object", untranslated. - In `BLT_translate()`, change `return BLI_thread_is_main();` to `return true;` and rebuild - Export the object again - The message appears again, but it is now translated.

curve.blend

88 KiB

Damien Picard added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

I18n: translation does not occur when started from a thread which isn’t main #108206