Assets: the same catalog UUID appearing in different asset libraries causes failed assertions in the 'All' library #108624

New Issue

Sybren A. Stüvel · 2023-06-05T16:37:22+02:00

Sybren A. Stüvel commented

2023-06-05 16:37:22 +02:00

System Information
Operating system: Linux-5.15.0-73-generic-x86_64-with-glibc2.35 64 Bits, X11 UI
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.182.03

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: Mon Jun 5 14:21:39 2023 +0200, hash: c18ee2e84dcebaf5831640c987e5fd434219e46c
Worked: probably broken since the introduction of the 'All' library

Short description of error
Having two asset libraries that both have a catalog with the same UUID cause an error:

BLI_assert failed: blender/source/blender/blenlib/BLI_map.hh:1093, add_new__impl(), at '!this->contains_as(key)'

Exact steps for others to reproduce the error

Extract the attached ZIP file. It contains a blend file and two asset libraries.
Run Blender in debug mode.
Open the blend file.
Run the script in the text editor (which adds the two asset libraries to your preferences; don't worry, they won't be saved)
Refresh the 'All' asset catalog.
See the failed assertion

Workaround

Applying this patch will work around this issue:

diff --git a/source/blender/asset_system/intern/asset_catalog.cc b/source/blender/asset_system/intern/asset_catalog.cc
index d27763c08d7..8512824b6d4 100644
--- a/source/blender/asset_system/intern/asset_catalog.cc
+++ b/source/blender/asset_system/intern/asset_catalog.cc
@@ -686,7 +686,7 @@ static void copy_catalog_map_into_existing(const OwningAssetCatalogMap &source,
 {
   for (const auto &orig_catalog_uptr : source.values()) {
     auto copy_catalog_uptr = std::make_unique<AssetCatalog>(*orig_catalog_uptr);
-    dest.add_new(copy_catalog_uptr->catalog_id, std::move(copy_catalog_uptr));
+    dest.add(copy_catalog_uptr->catalog_id, std::move(copy_catalog_uptr));
   }
 }

A better solution would be to implement some comparison function like bool AssetCatalog::is_consistent_with(const AC &other); that tests both the UUID and the catalog path are identical, and issue a warning if they are not, similar to what AssetCatalogService::parse_catalog_file() is doing.

**System Information** Operating system: Linux-5.15.0-73-generic-x86_64-with-glibc2.35 64 Bits, X11 UI Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.182.03 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: `Mon Jun 5 14:21:39 2023 +0200`, hash: `c18ee2e84dcebaf5831640c987e5fd434219e46c` Worked: probably broken since the introduction of the 'All' library **Short description of error** Having two asset libraries that both have a catalog with the same UUID cause an error: ``` BLI_assert failed: blender/source/blender/blenlib/BLI_map.hh:1093, add_new__impl(), at '!this->contains_as(key)' ``` **Exact steps for others to reproduce the error** - Extract the attached ZIP file. It contains a blend file and two asset libraries. - Run Blender in debug mode. - Open the blend file. - Run the script in the text editor (which adds the two asset libraries to your preferences; don't worry, they won't be saved) - Refresh the 'All' asset catalog. - See the failed assertion **Workaround** Applying this patch will work around this issue: ```diff diff --git a/source/blender/asset_system/intern/asset_catalog.cc b/source/blender/asset_system/intern/asset_catalog.cc index d27763c08d7..8512824b6d4 100644 --- a/source/blender/asset_system/intern/asset_catalog.cc +++ b/source/blender/asset_system/intern/asset_catalog.cc @@ -686,7 +686,7 @@ static void copy_catalog_map_into_existing(const OwningAssetCatalogMap &source, { for (const auto &orig_catalog_uptr : source.values()) { auto copy_catalog_uptr = std::make_unique<AssetCatalog>(*orig_catalog_uptr); - dest.add_new(copy_catalog_uptr->catalog_id, std::move(copy_catalog_uptr)); + dest.add(copy_catalog_uptr->catalog_id, std::move(copy_catalog_uptr)); } } ``` A better solution would be to implement some comparison function like `bool AssetCatalog::is_consistent_with(const AC &other);` that tests both the UUID and the catalog path are identical, and issue a warning if they are not, similar to what `AssetCatalogService::parse_catalog_file()` is doing.

108624-asset-repo-catalog-clash.zip

103 KiB

Sybren A. Stüvel added the

Pipeline, Assets & IO

labels 2023-06-05 16:38:22 +02:00