GPv3: Select pick operator #108660

New Issue

Falk David · 2023-06-06T15:08:21+02:00

Falk David commented

2023-06-06 15:08:21 +02:00

The VIEW3D_OT_select operator needs to be implemented for the new grease pencil data.

Checklist:

in blender/source/blender/editors/space_view3d/view3d_select.cc in the function view3d_select_exec, add a else if for OB_GREASE_PENCIL under the check for OB_CURVES
create a static function ed_grease_pencil_select_pick based on ed_curves_select_pick.
instead of reducing on bases reduce over the editable drawings. Get them using foreach_editable_drawing.
after finding the ClosestCurveDataBlock instead of deselecting the bases, deselect the drawings.

References:

ed_curves_select_pick in blender/source/blender/editors/space_view3d/view3d_select.cc
do_grease_pencil_box_select in #108661

The `VIEW3D_OT_select` operator needs to be implemented for the new grease pencil data. Checklist: - [x] in `blender/source/blender/editors/space_view3d/view3d_select.cc` in the function `view3d_select_exec`, add a `else if` for `OB_GREASE_PENCIL` under the check for `OB_CURVES` - [x] create a static function `ed_grease_pencil_select_pick` based on `ed_curves_select_pick`. - [x] instead of reducing on `bases` reduce over the editable drawings. Get them using `foreach_editable_drawing`. - [x] after finding the `ClosestCurveDataBlock` instead of deselecting the `bases`, deselect the drawings. References: - `ed_curves_select_pick` in `blender/source/blender/editors/space_view3d/view3d_select.cc` - `do_grease_pencil_box_select` in https://projects.blender.org/blender/blender/pulls/108661

Falk David added the

Type

To Do

label 2023-06-06 15:08:21 +02:00

Falk David added this to the Grease Pencil project 2023-06-06 15:08:22 +02:00

Falk David changed title from ~~GP3: Select pick operator~~ to GPv3: Select pick operator

2023-06-06 15:08:32 +02:00

Falk David referenced this issue

2023-06-06 15:18:56 +02:00

Selection Operators #107645

Sietse Brouwer self-assigned this 2023-06-07 11:36:27 +02:00

~~Sietse Brouwer referenced this issue 2023-06-07 18:19:48 +02:00~~