Assert: When loading asset libraries from within a large asset library #108703

New Issue

Closed

opened 2023-06-07 14:42:22 +02:00 by Lukas Tönne · 5 comments

Lukas Tönne commented

2023-06-07 14:42:22 +02:00

Member

System Information
Operating system: Linux-6.3.5-gentoo-x86_64-AMD_Ryzen_7_5700G_with_Radeon_Graphics-with-glibc2.36
Graphics card: AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.52, 6.3.5-gentoo)

Blender Version
Broken: 4.0.0 Alpha, branch: main, commit date: 2023-06-07 10:40, hash: eb7ae2fb82, type: Debug
Worked: ?

Short description of error
Loading asset libraries (by dragging a node socket link) inside an asset library file causes a crash.

Exact steps for others to reproduce the error
Unfortunately the error seems to depend on how long the libraries take to load. I could not repro with a simpler asset library, so the attached file contains my fairly large actual library.

Unzip the attached asset library into a folder
Add the folder to the Asset Libraries file paths in user preferences
Restart Blender (not sure if necessary but we want to force loading from a clean slate)
Open the race_condition_test.blend file
In the node editor press shift+A, or drag a link to open the search menu. It should crash in asset_system::copy_catalog_map_into_existing.

Callstack for comparison: callstack.txt

**System Information** Operating system: Linux-6.3.5-gentoo-x86_64-AMD_Ryzen_7_5700G_with_Radeon_Graphics-with-glibc2.36 Graphics card: AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.52, 6.3.5-gentoo) **Blender Version** Broken: 4.0.0 Alpha, branch: main, commit date: 2023-06-07 10:40, hash: eb7ae2fb82de, type: Debug Worked: ? **Short description of error** Loading asset libraries (by dragging a node socket link) inside an asset library file causes a crash. **Exact steps for others to reproduce the error** Unfortunately the error seems to depend on how long the libraries take to load. I could not repro with a simpler asset library, so the attached file contains my fairly large actual library. 1. Unzip the attached asset library into a folder 1. Add the folder to the Asset Libraries file paths in user preferences 1. Restart Blender (not sure if necessary but we want to force loading from a clean slate) 1. Open the race_condition_test.blend file 1. In the node editor press shift+A, or drag a link to open the search menu. It should crash in `asset_system::copy_catalog_map_into_existing`. Callstack for comparison: [callstack.txt](/attachments/f7f3e3b2-4d2c-4b6b-9f22-189ef9a7e88c)

asset_load_race_condition_test.zip

5.8 MiB

callstack.txt

18 KiB

Lukas Tönne added the

labels 2023-06-07 14:42:22 +02:00

Iliya Katushenock added the

label 2023-06-07 14:45:56 +02:00

Richard Antalik commented

2023-06-07 22:53:28 +02:00

Member

Can't confirm here.

Can't confirm here.

Pratik Borhade commented

2023-06-08 05:51:18 +02:00

Member

Can not replicate either in current master.

**System Information**
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 532.03

Can not replicate either in current master. ``` **System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 532.03 ```

Pratik Borhade commented

2023-06-08 05:54:51 +02:00

Member

From attached call-stack, this appears to be an assert-hit (not crash)
Can confirm in debug build.

From attached call-stack, this appears to be an assert-hit (not crash) Can confirm in debug build.

Pratik Borhade added

Pipeline, Assets & IO

and removed

labels 2023-06-08 05:55:16 +02:00

Pratik Borhade changed title from ~~Crash when loading asset libraries from within a large asset library~~ to Assert: When loading asset libraries from within a large asset library

2023-06-08 06:14:10 +02:00

Lukas Tönne commented

2024-02-11 12:44:32 +01:00

Author

Member

I keep running into this whenever i work on asset libraries in debug mode. It happens because an asset library can be loaded twice: first as part of the asset libraries path config, then a second time as a "local" library when opening its file.

Repro steps:

(optional) Load Factory Preferences to clear custom asset library paths.
In asset browser, switch to Current File, add a new catalog to the local asset library.
Mark the default cube as asset. Move the cube asset into the new catalog.
Save file in a new folder. Add the folder to the asset library paths in preferences.
Start Blender in Debug mode, open the file again.

Not sure what the best way to prevent this would be. Generally seems like a good idea to assert we're not unnecessarily loading libraries twice, but in this case it is expected.

I keep running into this whenever i work on asset libraries in debug mode. It happens because an asset library can be loaded twice: first as part of the asset libraries path config, then a second time as a "local" library when opening its file. Repro steps: 1. (optional) _Load Factory Preferences_ to clear custom asset library paths. 2. In asset browser, switch to _Current File_, add a new catalog to the local asset library. 3. Mark the default cube as asset. Move the cube asset into the new catalog. 4. Save file in a new folder. Add the folder to the asset library paths in preferences. 5. Start Blender in __Debug mode__, open the file again. Not sure what the best way to prevent this would be. Generally seems like a good idea to assert we're not unnecessarily loading libraries twice, but in this case it is expected.

Julian Eisel commented

2024-02-20 15:59:08 +01:00

Member

Let me clarify this a bit: Issue here is not a race condition, it's simply that when building the "All" asset library, multiple catalogs with the same UUID are found, which code assumes to be unique. I think this can easily happen when loading the "All" library in some way (e.g. when displaying the node add menu) while the current file is part of an asset library. Then you have two asset libraries loading the same asset library catalogs (same blender_assets.cats.txt).

Let me clarify this a bit: Issue here is not a race condition, it's simply that when building the "All" asset library, multiple catalogs with the same UUID are found, which code assumes to be unique. I think this can easily happen when loading the "All" library in some way (e.g. when displaying the node add menu) while the current file is part of an asset library. Then you have two asset libraries loading the same asset library catalogs (same `blender_assets.cats.txt`).

Julian Eisel referenced this issue from a commit

2024-02-20 16:49:37 +01:00

Fix #108703: assert when loading "All" asset library

Julian Eisel closed this issue

2024-02-20 16:49:39 +01:00

Blender Bot added

and removed

labels 2024-02-20 16:49:41 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108703

No description provided.