Test bf_imbuf_save fails with an assert in debug builds (DPX 8-bit save) #108754

New Issue

Closed

opened 2023-06-08 13:33:39 +02:00 by Martijn Versteegh · 5 comments

Martijn Versteegh commented

2023-06-08 13:33:39 +02:00

Member

System Information
Operating system: Linux-6.2.0-10007-tuxedo-x86_64-with-glibc2.35 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 3070 Ti Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 530.41.03

Blender Version
Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-06-08 09:02, hash: 2387290e4f8d
Worked: (newest version of Blender that worked as expected)

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Compile a debug version of v3.6-release
run ctest -R imbuf_save

It fails with the assert:

BLI_assert failed: source/blender/imbuf/intern/colormanagement.cc:2530, IMB_colormanagement_imbuf_for_write(), at '!(byte_output && linear_
float_output)'

**System Information** Operating system: Linux-6.2.0-10007-tuxedo-x86_64-with-glibc2.35 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 3070 Ti Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 530.41.03 **Blender Version** Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-06-08 09:02, hash: `2387290e4f8d` Worked: (newest version of Blender that worked as expected) **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] - Compile a debug version of v3.6-release - run `ctest -R imbuf_save` It fails with the assert: ``` BLI_assert failed: source/blender/imbuf/intern/colormanagement.cc:2530, IMB_colormanagement_imbuf_for_write(), at '!(byte_output && linear_ float_output)' ```

Martijn Versteegh added the

labels 2023-06-08 13:33:39 +02:00

Martijn Versteegh added this to the 3.6 LTS milestone 2023-06-08 13:34:08 +02:00

Martijn Versteegh changed title from ~~Test bf_imbuf_save fails with an asser in debugmode for v3.6-release~~ to Test bf_imbuf_save fails with an assert in debugmode for v3.6-release

2023-06-08 14:45:53 +02:00

Iliya Katushenock commented

2023-06-08 18:18:27 +02:00

Member

Same for 4.0

Same for 4.0

Iliya Katushenock added the

Images & Movies

labels 2023-06-08 18:18:43 +02:00

Ray molenkamp commented

2023-06-08 18:21:49 +02:00

Member

I bumped into it a while ago, @deadpin mentioned

it's known. haven't been able to fix it though. the test exposed the issue but it's technically been in blender "forever"

back then.

I bumped into it a while ago, @deadpin mentioned >it's known. haven't been able to fix it though. the test exposed the issue but it's technically been in blender "forever" back then.

Jesse Yurkovich changed title from ~~Test bf_imbuf_save fails with an assert in debugmode for v3.6-release~~ to Test bf_imbuf_save fails with an assert in debug builds (DPX 8-bit save)

2023-06-09 07:13:19 +02:00

Jesse Yurkovich added

and removed

labels 2023-06-09 07:13:24 +02:00

Jesse Yurkovich removed this from the 3.6 LTS milestone 2023-06-09 07:14:24 +02:00

Richard Antalik added the

Platforms, Builds & Tests

label 2023-06-09 23:13:01 +02:00

Martijn Versteegh commented

2023-12-09 10:16:39 +01:00

Author

Member

I bumped into it a while ago, @deadpin mentioned

it's known. haven't been able to fix it though. the test exposed the issue but it's technically been in blender "forever"

@deadpin Can you remember if there's an issue/report with more information about the underlying problem?

> I bumped into it a while ago, @deadpin mentioned > > >it's known. haven't been able to fix it though. the test exposed the issue but it's technically been in blender "forever" > @deadpin Can you remember if there's an issue/report with more information about the underlying problem?

Jesse Yurkovich commented

2023-12-09 10:26:25 +01:00

Member

This is it right here. Rundown is as follows:

DPX has always been marked as requiring a float buffer
DPX has always been able to be saved to an 8-bit buffer ... the contradiction
The assert that is firing was added last year 5baa3ecda6
The test hitting the assert was added this year
It seems like the code here is capable of handling the contradiction above since the image file "looks" correct. Maybe the assert itself is just incorrect and should be removed.
Removing DPX from the list of formats requiring a float buffer seems to produce broken images. Double check that.

This is it right here. Rundown is as follows: - DPX has always been marked as requiring a float buffer - DPX has always been able to be saved to an 8-bit buffer ... the contradiction - The assert that is firing was added last year 5baa3ecda66337c0584f0bc6c6e7af0a6c0f6320 - The test hitting the assert was added this year - It seems like the code here is capable of handling the contradiction above since the image file "looks" correct. Maybe the assert itself is just incorrect and should be removed. - Removing DPX from the list of formats requiring a float buffer seems to produce broken images. Double check that.

Martijn Versteegh commented

2023-12-11 13:03:22 +01:00

Author

Member

tx. I'll see if I can find the time to find out what's going on.

tx. I'll see if I can find the time to find out what's going on.

Jesse Yurkovich referenced a pull request that will close this issue

2024-02-06 19:31:03 +01:00

Fix #108754: remove overactive color management assert #117914

Jesse Yurkovich referenced this issue from a commit

2024-02-06 20:50:53 +01:00

Fix #108754: remove overactive color management assert

Jesse Yurkovich closed this issue

2024-02-06 20:50:55 +01:00

Blender Bot added

and removed

labels 2024-02-06 20:52:00 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108754

No description provided.