Shader editor material name on title bar doesn't follow pinned material #108894

New Issue

Open

opened 2023-06-12 15:11:20 +02:00 by Andrej · 3 comments

Andrej commented

2023-06-12 15:11:20 +02:00

Contributor

Blender 3.5.1

As you can see on the screenshot it's displaying material "Material" when current node tree is for another material (you can distinguish it by the different base color).

Way to reproduce:

open attached blend file
run the following code in python console

shader_editor = bpy.data.screens['Shading'].areas[3].spaces.active
shader_editor.pin = True
shader_editor.node_tree = bpy.data.materials['Second_material'].node_tree

Blender 3.5.1 As you can see on the screenshot it's displaying material "Material" when current node tree is for another material (you can distinguish it by the different base color). Way to reproduce: - open attached blend file - run the following code in python console ```python shader_editor = bpy.data.screens['Shading'].areas[3].spaces.active shader_editor.pin = True shader_editor.node_tree = bpy.data.materials['Second_material'].node_tree ``` ![image](/attachments/8d18deb6-d93d-4fe3-8a38-232d2bba2521)

353 KiB

python_api_node_tree_update.blend

852 KiB

Andrej added the

labels 2023-06-12 15:11:21 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-06-12 15:30:34 +02:00

YimingWu commented

2023-06-12 15:45:07 +02:00

Member

I believe that title selector shows the selected material slot in the active object, so technically it's "not correct" to manually change the node tree being displayed, but rather change the active material slot.

I believe that title selector shows the selected material slot in the active object, so technically it's "not correct" to manually change the node tree being displayed, but rather change the active material slot.

Andrej commented

2023-06-12 15:48:20 +02:00

Author

Contributor

But when you pin some material manually from UI it's showing correct material even if it's not currently selected.

But when you pin some material manually from UI it's showing correct material even if it's not currently selected.

YimingWu commented

2023-06-13 08:54:42 +02:00

Member

Yeah I can confirm that the title will not follow "Pinned" material. I think we should fix that.

Looks like material.node_tree.name is not the name of the material itself, and the thing that's being pinned to the shader editor is the node tree, not the material. So I'm not sure how to deal with this, maybe we could simply hide the name, or put node_tree.name there (which is simply "Shader Node Tree") when it's pinned.

Yeah I can confirm that the title will not follow "Pinned" material. I think we should fix that. Looks like `material.node_tree.name` is not the name of the material itself, and the thing that's being pinned to the shader editor is the node tree, not the material. So I'm not sure how to deal with this, maybe we could simply hide the name, or put `node_tree.name` there (which is simply "Shader Node Tree") when it's pinned.

YimingWu changed title from ~~Changing shader editor node tree from python api doesn't change topbar shader name.~~ to Shader editor material name on title bar doesn't follow pinned material or `shader_editor.node_tree`

2023-06-13 08:55:57 +02:00

YimingWu changed title from ~~Shader editor material name on title bar doesn't follow pinned material or `shader_editor.node_tree`~~ to Shader editor material name on title bar doesn't follow pinned material

2023-06-13 08:56:08 +02:00

YimingWu added

and removed

labels 2023-06-13 09:02:14 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108894

No description provided.