Regression: crash and assert hit in curve sculpt mode after undo #108923

New Issue

Closed

opened 2023-06-13 06:45:11 +02:00 by Pratik Borhade · 6 comments

Pratik Borhade commented

2023-06-13 06:45:11 +02:00

Member

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 532.03

Blender Version
Broken: 4.0, 31145ffce538cd0c73a88709ced00415f65075ed
Worked: 3.6 beta.

Git bisect points to: ebb5643e59

Short description of error
Crash and assert hit at BLI_assert(id->us >= 0); on Undo operation in curve sculpt mode.

Exact steps for others to reproduce the error

Open default scene.
Add Empty hair object on default cube.
Switch to sculpt mode.
Undo.
Repeat last two steps if crash does not happen after first attempt

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 532.03 **Blender Version** Broken: 4.0, `31145ffce538cd0c73a88709ced00415f65075ed` Worked: 3.6 beta. Git bisect points to: ebb5643e598a17b2f21b4e50acac35afe82dbd55 **Short description of error** Crash and assert hit at `BLI_assert(id->us >= 0);` on Undo operation in curve sculpt mode. **Exact steps for others to reproduce the error** 1. Open default scene. 2. Add `Empty hair` object on default cube. 3. Switch to sculpt mode. 4. Undo. 5. Repeat last two steps if crash does not happen after first attempt

Pratik Borhade added the

labels 2023-06-13 06:45:12 +02:00

Iliya Katushenock added the

Nodes & Physics

Sculpt, Paint & Texture

labels 2023-06-13 08:58:13 +02:00

Iliya Katushenock commented

2023-06-13 08:59:47 +02:00

Member

I can not reproduce that in last debug build

I can not reproduce that in last debug build

Pratik Borhade commented

2023-06-14 04:30:08 +02:00

Author

Member

@mod_moder , can still confirm in current master (I'll check which commit broke this).
Repeat last two steps if crash does not happen on first try.

@mod_moder , can still confirm in current master (I'll check which commit broke this). Repeat last two steps if crash does not happen on first try.

Pratik Borhade commented

2023-06-14 08:33:53 +02:00

Author

Member

Git bisect points to: ebb5643e59

Git bisect points to: ebb5643e598a17b2f21b4e50acac35afe82dbd55

Iliya Katushenock removed the

Nodes & Physics

labels 2023-06-14 14:21:08 +02:00

Jesse Yurkovich commented

2023-06-14 21:16:38 +02:00

Member

I can confirm the crash with a release build of Windows and with an ASAN build on Linux though they're a bit different:

Windows

ExceptionCode         : EXCEPTION_ACCESS_VIOLATION

BKE_lib_override_library_is_system_defined C:\Users\jesse\source\blender-git\blender\source\blender\blenkernel\intern\lib_override.cc:343
rna_property_editable_do C:\Users\jesse\source\blender-git\blender\source\blender\makesrna\intern\rna_access.cc:2001
ui_def_but_rna C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface.cc:4745
uiDefIconButR_prop C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface.cc:5633
uiDefAutoButR C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface_utils.cc:70
uiItemFullR C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface_layout.cc:2444
rna_uiItemR C:\Users\jesse\source\blender-git\blender\source\blender\makesrna\intern\rna_ui_api.c:124

Linux

==24308==ERROR: AddressSanitizer: heap-use-after-free on address 0x61d0049322f4 at pc 0x000000d9bc2e bp 0x7ffe16abe750 sp 0x7ffe16abe740
READ of size 4 at 0x61d0049322f4 thread T0
    #0 0xd9bc2d in id_us_plus_no_lib /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:302
    #1 0xda9230 in id_refcount_recompute_callback /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:1653
    #2 0xe11afe in BKE_lib_query_foreachid_process /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:88
    #3 0x161c8e2 in scene_foreach_paint /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:564
    #4 0x161f7f2 in scene_foreach_toolsettings /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:762
    #5 0x162152f in scene_foreach_id /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:906
    #6 0xe1412c in library_foreach_ID_link /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:345
    #7 0xe142fa in BKE_library_foreach_ID_link /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:364
    #8 0xda9d09 in BKE_main_id_refcount_recompute /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:1685
    #9 0x8ed351 in setup_app_data /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/blendfile.cc:942

I can confirm the crash with a release build of Windows and with an ASAN build on Linux though they're a bit different: Windows ``` ExceptionCode : EXCEPTION_ACCESS_VIOLATION BKE_lib_override_library_is_system_defined C:\Users\jesse\source\blender-git\blender\source\blender\blenkernel\intern\lib_override.cc:343 rna_property_editable_do C:\Users\jesse\source\blender-git\blender\source\blender\makesrna\intern\rna_access.cc:2001 ui_def_but_rna C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface.cc:4745 uiDefIconButR_prop C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface.cc:5633 uiDefAutoButR C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface_utils.cc:70 uiItemFullR C:\Users\jesse\source\blender-git\blender\source\blender\editors\interface\interface_layout.cc:2444 rna_uiItemR C:\Users\jesse\source\blender-git\blender\source\blender\makesrna\intern\rna_ui_api.c:124 ``` Linux ``` ==24308==ERROR: AddressSanitizer: heap-use-after-free on address 0x61d0049322f4 at pc 0x000000d9bc2e bp 0x7ffe16abe750 sp 0x7ffe16abe740 READ of size 4 at 0x61d0049322f4 thread T0 #0 0xd9bc2d in id_us_plus_no_lib /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:302 #1 0xda9230 in id_refcount_recompute_callback /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:1653 #2 0xe11afe in BKE_lib_query_foreachid_process /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:88 #3 0x161c8e2 in scene_foreach_paint /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:564 #4 0x161f7f2 in scene_foreach_toolsettings /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:762 #5 0x162152f in scene_foreach_id /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/scene.cc:906 #6 0xe1412c in library_foreach_ID_link /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:345 #7 0xe142fa in BKE_library_foreach_ID_link /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_query.c:364 #8 0xda9d09 in BKE_main_id_refcount_recompute /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/lib_id.c:1685 #9 0x8ed351 in setup_app_data /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/blendfile.cc:942 ```

Jesse Yurkovich added

and removed

labels 2023-06-14 21:16:51 +02:00

Pratik Borhade commented

2023-06-15 04:41:40 +02:00

Author

Member

Git bisect points to: ebb5643e59

> Git bisect points to: ebb5643e598a17b2f21b4e50acac35afe82dbd55 cc @mont29

Pratik Borhade added

and removed

labels 2023-06-15 04:41:51 +02:00

Hans Goudey added

and removed

labels 2023-06-16 13:54:00 +02:00

Julian Eisel changed title from ~~Regression: crash and asset hit in curve sculpt mode after undo~~ to Regression: crash and assert hit in curve sculpt mode after undo

2023-06-19 11:37:43 +02:00

Bastien Montagne commented

2023-06-20 19:33:34 +02:00

Owner

This issue is actually a set of bugs in the scene_undo_preserve codepath (which attempts to preserve toolsettings accross undos, and therefore has to shuffle around ID pointers). the current design simply cannot work, it happened to 'not crash' before ebb5643e59 because of the extra complete recheck of pointers that used to happen at the end of the setup_app_data process, which was hiding the issues.

The whole handling of undo_preserve when dealing with data with some ID pointers needs to be re-thought here, the problem is actually very similar to the handling of the new 'no undo' IDs introduced in ebb5643e59, so hopefully similar (or even shared) code can be used.

This issue is actually a set of bugs in the `scene_undo_preserve` codepath (which attempts to preserve toolsettings accross undos, and therefore has to shuffle around ID pointers). the current design simply cannot work, it happened to 'not crash' before ebb5643e59 because of the extra complete recheck of pointers that used to happen at the end of the `setup_app_data` process, which was hiding the issues. The whole handling of `undo_preserve` when dealing with data with some ID pointers needs to be re-thought here, the problem is actually very similar to the handling of the new 'no undo' IDs introduced in ebb5643e59, so hopefully similar (or even shared) code can be used.

Bastien Montagne added

and removed

labels 2023-06-20 19:33:45 +02:00

Bastien Montagne self-assigned this 2023-06-20 19:33:52 +02:00

Bastien Montagne referenced this issue from a commit

2023-06-21 15:37:47 +02:00

Fix #108923: Serious issues in 'undo_preserve' process of Scene's toolsettings.

Bastien Montagne closed this issue

2023-06-21 15:37:48 +02:00

Blender Bot added

and removed

labels 2023-06-21 15:38:31 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108923

No description provided.