Edit source at a menu item with an external editor like VS Code makes Blender unresponsible #109149

Open
opened 2023-06-20 09:36:17 +02:00 by Arunderan · 5 comments

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.14

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-06-16 13:23, hash: 579a9d2e1fcf
Worked: (newest version of Blender that worked as expected)

Short description of error

Trying to edit a menu item of Blender with an external editor like VS Code makes Blender unresponsible.

Exact steps for others to reproduce the error

  • In the preferences add VS Code as the external editor. Add the $filepath expression too (shouldn't this be a default? ).
  • In the preferences activate Developer Extras in the Interface tab
  • Now right click at a menu item in Blender and choose Edit Source

VS Code now loads the code, but Blender becomes unresponsible. In the moment though when i close VS , Blender comes back. So i am not sure if this is intended behaviour.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.14 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-06-16 13:23, hash: `579a9d2e1fcf` Worked: (newest version of Blender that worked as expected) **Short description of error** Trying to edit a menu item of Blender with an external editor like VS Code makes Blender unresponsible. **Exact steps for others to reproduce the error** - In the preferences add VS Code as the external editor. Add the $filepath expression too (shouldn't this be a default? ). - In the preferences activate Developer Extras in the Interface tab - Now right click at a menu item in Blender and choose Edit Source VS Code now loads the code, but Blender becomes unresponsible. In the moment though when i close VS , Blender comes back. So i am not sure if this is intended behaviour.
Arunderan added the
Status
Needs Triage
Type
Report
Priority
Normal
labels 2023-06-20 09:36:18 +02:00
Member

This looks to be a expected behaviour.

in class TEXT_OT_jump_to_file_at_point(Operator):, the process will block until editor is closed.

        try:
            # With `check=True` if `process.returncode != 0` an exception will be raised.
            subprocess.run(args, check=True)
        except Exception as ex:
            self.report({'ERROR'}, "Exception running external editor: %r" % ex)
            return {'CANCELLED'}

Probably it should be blocking because otherwise it will introduce syncing problem and conflict resolving etc.

This looks to be a expected behaviour. in `class TEXT_OT_jump_to_file_at_point(Operator):`, the process will block until editor is closed. ```Py try: # With `check=True` if `process.returncode != 0` an exception will be raised. subprocess.run(args, check=True) except Exception as ex: self.report({'ERROR'}, "Exception running external editor: %r" % ex) return {'CANCELLED'} ``` Probably it should be blocking because otherwise it will introduce syncing problem and conflict resolving etc.
YimingWu added
Status
Needs Info from Developers
Interest
Text Editor
and removed
Status
Needs Triage
labels 2023-06-20 10:16:31 +02:00
Author

This would be sad behaviour. I would have to close and reopen the editor all the time :(

This would be sad behaviour. I would have to close and reopen the editor all the time :(
Contributor

It was not intentional behavior, fixed in #109156

It was not intentional behavior, fixed in #109156
Author

Yay \o/ Many thanks :)

Yay \o/ Many thanks :)
Contributor

Tanks for the report!

This looks to be a expected behaviour.

As it is now if it seems expected behavior, I didn't take into account that subprocess.run() can block Blender until the editor is closed, in tests I used code.cmd from %PATH%, it automatically invokes a new process, my bad.

Tanks for the report! > This looks to be a expected behaviour. As it is now if it seems expected behavior, I didn't take into account that `subprocess.run()` can block Blender until the editor is closed, in tests I used `code.cmd` from `%PATH%`, it automatically invokes a new process, my bad.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109149
No description provided.