Sculpt Mode: Mesh hidden when Active UV Layer is selected (fixed already request for 3.3 LTS backport) #109199

New Issue

Manuel · 2023-06-21T12:30:28+02:00

Manuel commented

2023-06-21 12:30:28 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: rB0759f671ce1f
Worked: 3.1.0

Short description of error
When selecting the active UV channel on an object with four UV channels AND four vertex color channels, the mesh will be hidden in sculpt mode. Deselecting the uv channel, changing the active one (camera icon) or deleting either one of the UV or vertex color channels all fix the problem.

SEEMS TO BE FIXED IN 3.5 but might be relevant for 3.3 LTS(?)

Exact steps for others to reproduce the error
New file:

Select Cube
Add 4 uv channels
Add 4 vertex color channels
Go to sculpt mode
Select the active UV channel (the one with the camera icon)

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40 **Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `rB0759f671ce1f` Worked: 3.1.0 **Short description of error** When selecting the active UV channel on an object with four UV channels AND four vertex color channels, the mesh will be hidden in sculpt mode. Deselecting the uv channel, changing the active one (camera icon) or deleting either one of the UV or vertex color channels all fix the problem. SEEMS TO BE FIXED IN 3.5 but might be relevant for 3.3 LTS(?) **Exact steps for others to reproduce the error** New file: - Select Cube - Add 4 uv channels - Add 4 vertex color channels - Go to sculpt mode - Select the active UV channel (the one with the camera icon)

👀 1

Manuel added the

labels 2023-06-21 12:30:29 +02:00

Philipp Oeser commented

2023-06-21 15:01:41 +02:00

Can confirm, lets see when that changed/was fixed

Philipp Oeser changed title from ~~Sculpt Mode: Mesh hidden when Active UV Layer is selected~~ to Sculpt Mode: Mesh hidden when Active UV Layer is selected (fixed already request for 3.3 LTS backport)

2023-06-21 15:06:05 +02:00

Philipp Oeser added

and removed

labels 2023-06-21 15:06:24 +02:00

Philipp Oeser commented

2023-06-21 17:13:59 +02:00

Boy, this bisect is a pain (and would probably not really be helpful either, so I dropped it).
There was a time when sculpt was so broken, you couldnt open a file in sculptmode at all...

So the whole thing was fixed somewhere between 8a68f4f808 and 22c3db72ca, can @JosephEagar name a commit that is suitable for backporting to 3.3 LTS that would fix this issue there?

Boy, this bisect is a **pain** (and would probably not really be helpful either, so I dropped it). There was a time when sculpt was so broken, you couldnt open a file in sculptmode at all... So the whole thing was fixed somewhere between 8a68f4f80814 and 22c3db72ca2f, can @JosephEagar name a commit that is suitable for backporting to 3.3 LTS that would fix this issue there?

Philipp Oeser added the

Module

Sculpt, Paint & Texture

label 2023-06-21 17:14:17 +02:00

Joseph Eagar commented

2023-06-22 00:11:32 +02:00

IIRC this was not a simple fix, what's the branch name for 3.3 LTS? Just blender-v3.3-release? I can take a look.

Pratik Borhade added this to the 3.3 LTS milestone 2023-06-22 06:34:40 +02:00

Philipp Oeser commented

2023-06-22 09:05:53 +02:00

Yep, it is blender-v3.3-release.
If you find something that applies cleanly, you can also add that commit(s) to #100749

Yep, it is `blender-v3.3-release`. If you find something that applies cleanly, you can also add that commit(s) to #100749

Joseph Eagar commented

2023-06-23 08:50:25 +02:00

a6ba8e5f38 was the main commit for this fix, but it already seems to be in the branch. It must be a follow-up fix commit.

a6ba8e5f38dbf62392088c3020aab549b7c80554 was the main commit for this fix, but it already seems to be in the branch. It must be a follow-up fix commit.

Joseph Eagar commented

2023-06-23 08:54:28 +02:00

Yeesh. How important is it to fix this? I think the problem is the original, highly broken PBVH drawing code. I had to rewrite it from scratch in C++ (and inside the proper code module, it was originally in the GPU module instead of draw).

The original code had no way to know which attributes were needed for the current set of viewport shaders. So it uploaded all of them, inside a single VBO. There's a limit to how many attributes a single VBO can contain, so once a certain number of attributes are created the mesh glitches or disappears . The new code only uploads the attributes the GPU needs and puts them in multiple VBOs.

Yeesh. How important is it to fix this? I think the problem is the original, highly broken PBVH drawing code. I had to rewrite it from scratch in C++ (and inside the proper code module, it was originally in the GPU module instead of draw). The original code had no way to know which attributes were needed for the current set of viewport shaders. So it uploaded all of them, inside a single VBO. There's a limit to how many attributes a single VBO can contain, so once a certain number of attributes are created the mesh glitches or disappears . The new code only uploads the attributes the GPU needs and puts them in multiple VBOs.

Joseph Eagar commented

2023-06-23 09:05:58 +02:00

I wasn't able to find a clean set of commits. If necessary I can backport the new code manually.

Philipp Oeser commented

2023-06-23 09:17:20 +02:00

I would not backport the new code to LTS just for this fix (it might come with other bugs -- possibly unreported yet -- which somehow contradicts the purpose of LTS).

Therefor, I am closing this report, thx for the input everyone!

I would not backport the new code to LTS just for this fix (it might come with other bugs -- possibly unreported yet -- which somehow contradicts the purpose of LTS). Therefor, I am closing this report, thx for the input everyone!

Philipp Oeser closed this issue

2023-06-23 09:17:22 +02:00

Blender Bot added

and removed

labels 2023-06-23 09:17:24 +02:00

Sign in to join this conversation.