GPv3: Select Alternate #109204

New Issue

Falk David · 2023-06-21T13:59:34+02:00

Falk David commented

2023-06-21 13:59:34 +02:00

Difficulty: ⚫🔴🔴

The GPENCIL_OT_select_alternate operator needs to be adapted for the new grease pencil data type.

Checklist:

In blender/source/blender/editors/curves/intern/curves_selection.cc write a function void select_alternate(bke::CurvesGeometry &curves, const bool select_ends). Follow the structure in select_adjacent as reference.
The function should select every other point except of the start and end point which should be selected based on the select_ends parameter. There is no need to support float selections.
Write an operator GREASE_PENCIL_OT_select_alternate in blender/source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc. Declare a RNA_def_boolean named select_ends. Default to true.
In the exec function of the operator, iterate over the editable_drawings and call the ed::curves::select_alternate function on the drawing.
Add the operator to the menu VIEW3D_MT_select_edit_gpencil in blender/scripts/startup/bl_ui/space_view3d.py.

Difficulty: ⚫🔴🔴 The `GPENCIL_OT_select_alternate` operator needs to be adapted for the new grease pencil data type. Checklist: - [ ] In `blender/source/blender/editors/curves/intern/curves_selection.cc` write a function `void select_alternate(bke::CurvesGeometry &curves, const bool select_ends)`. Follow the structure in `select_adjacent` as reference. The function should select every other point except of the start and end point which should be selected based on the `select_ends` parameter. There is no need to support `float` selections. - [ ] Write an operator `GREASE_PENCIL_OT_select_alternate` in `blender/source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc`. Declare a `RNA_def_boolean` named `select_ends`. Default to `true`. - [ ] In the `exec` function of the operator, iterate over the `editable_drawings` and call the `ed::curves::select_alternate` function on the drawing. - [ ] Add the operator to the menu `VIEW3D_MT_select_edit_gpencil` in `blender/scripts/startup/bl_ui/space_view3d.py`.

Falk David added the

Type

To Do

label 2023-06-21 13:59:34 +02:00

Falk David added this to the Grease Pencil project 2023-06-21 13:59:35 +02:00

Gangneron commented

2023-06-21 15:47:51 +02:00

@filedescriptor hello which operator should we Add a VIEW3D_MT_select_edit_gpencil

Gangneron commented

2023-06-21 15:51:37 +02:00

For information for the moment I only want to take care of the UI on this task

Falk David commented

2023-06-21 16:06:18 +02:00

@Gangneron sorry, this task is already taken.

Gangneron commented

2023-06-21 16:12:57 +02:00

ok but have you seen my messages https://blender.chat/direct/sEq8E2ro5ikrGZ3atuFHRJBeFdM9YwrmtB

Lorenzo-Carpaneto commented

2023-06-22 12:00:16 +02:00

@filedescriptor In previous versions of blender select_alternate, select the points only for drawings that have some points selected. Do we want to keep this feature or we just do select alternate for every editable_drawing?

Moreover I think that the operator should be declared in grease_pencil_select.cc over grease_pencil_ops.cc, so I declared it there :)

@filedescriptor In previous versions of blender select_alternate, select the points only for drawings that have some points selected. Do we want to keep this feature or we just do select alternate for every `editable_drawing`? Moreover I think that the operator should be declared in `grease_pencil_select.cc` over `grease_pencil_ops.cc`, so I declared it there :)

Falk David commented

2023-06-22 12:32:04 +02:00

@Lorenzo-Carpaneto I think this feature should be kept. Only drawings with some selection should be changed.

Lorenzo-Carpaneto referenced a pull request that will close this issue

2023-06-22 14:11:39 +02:00

GPv3: Select Alternate #109240

Falk David referenced this issue from a commit

2023-06-23 11:34:07 +02:00

GPv3: Select Alternate

Falk David closed this issue

2023-06-23 11:34:07 +02:00

Blender Bot added the