Image Texture path failed to be imported as absolute after it was set to be relative and vice versa #109561

New Issue

Andrej · 2023-06-30T16:58:59+02:00

Andrej commented

2023-06-30 16:58:59 +02:00

Blender 3.6

When you create image texture node in shader graph and import texture and save it by relative path

then you cannot import it and save it by absolute path anymore.

Way to reproduce:

Create new .blend and save it.
Go to shader graph and image texture node.
Add texture to Image Texture node with "Open" button. Select some image and make sure "Relative Path" is set to True.
Use you use the command C.active_object.active_material.node_tree.nodes['Image Texture'].image.filepath to see that it was imported as relative. Output will be like //diffuse.jpg.
Remove the texture
Try to import it again but set "Relative Path" to False.
Run the command C.active_object.active_material.node_tree.nodes['Image Texture'].image.filepath it will still result in //diffuse.jpg because image was imported by relative path even though we set it to be absolute.

Blender 3.6 When you create image texture node in shader graph and import texture and save it by relative path then you cannot import it and save it by absolute path anymore. Way to reproduce: 1) Create new .blend and save it. 2) Go to shader graph and image texture node. 3) Add texture to Image Texture node with "Open" button. Select some image and make sure "Relative Path" is set to True. Use you use the command `C.active_object.active_material.node_tree.nodes['Image Texture'].image.filepath` to see that it was imported as relative. Output will be like `//diffuse.jpg`. ![image](/attachments/70fb3a9e-5935-4abb-954c-85fcbe768998) 4) Remove the texture ![image](/attachments/65572e69-b042-421d-a20c-b15edcdaf8f6) 5) Try to import it again but set "Relative Path" to False. Run the command ` C.active_object.active_material.node_tree.nodes['Image Texture'].image.filepath` it will still result in `//diffuse.jpg` because image was imported by relative path even though we set it to be absolute.

image.png

8.0 KiB

image.png

30 KiB

image.png

35 KiB

image.png

32 KiB

Andrej added the

labels 2023-06-30 16:59:00 +02:00

YimingWu commented

2023-06-30 17:34:53 +02:00

I believe this is simply blender doesn't remove datablocks until closing/purging. Try Purging data after unlinking image datablock, then importing?

I believe this is simply blender doesn't remove datablocks until closing/purging. Try Purging data after unlinking image datablock, then importing? ![图片](/attachments/10053e82-f8c5-41d9-bb40-10d1dce9d400)

图片.png

33 KiB

Andrej commented

2023-06-30 17:43:46 +02:00

@YimingWu it does work. But shouldn't it always prioritize the "relative path" flag from the dialog window over previous data block settings?

YimingWu commented

2023-06-30 17:55:54 +02:00

@pablovazquez Can we have a "prefer relative path" option in the user preference?

Pratik Borhade commented

2023-07-03 13:31:36 +02:00

Hi, codewise this is expected. If image data-block of same filepath is found in main storage then we use the existing image id.
A quick fix to change the file path will be:

diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c
index 5fe20ab29df..8ad7ec5e0b0 100644
--- a/source/blender/editors/space_image/image_ops.c
+++ b/source/blender/editors/space_image/image_ops.c
@@ -1325,6 +1325,9 @@ static Image *image_open_single(Main *bmain,
       }
     }
   }
+  else {
+    STRNCPY(ima->filepath, range->filepath);
+  }

   return ima;
 }

Hi, codewise this is expected. If image data-block of same filepath is found in main storage then we use the existing image id. A quick fix to change the file path will be: ``` diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c index 5fe20ab29df..8ad7ec5e0b0 100644 --- a/source/blender/editors/space_image/image_ops.c +++ b/source/blender/editors/space_image/image_ops.c @@ -1325,6 +1325,9 @@ static Image *image_open_single(Main *bmain, } } } + else { + STRNCPY(ima->filepath, range->filepath); + } return ima; } ```

👍 3

Pratik Borhade added

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-07-03 13:32:18 +02:00

Pratik Borhade self-assigned this 2023-07-03 13:32:26 +02:00

Pablo Vazquez commented

2023-07-05 11:17:24 +02:00

@pablovazquez Can we have a "prefer relative path" option in the user preference?

You mean adding a new preference? I think it should just respect whatever setting is set in the dialog.

> @pablovazquez Can we have a "prefer relative path" option in the user preference? You mean adding a new preference? I think it should just respect whatever setting is set in the dialog.

Pratik Borhade referenced a pull request that will close this issue

2023-07-07 12:18:09 +02:00

Fix #109561: Overwrite existing imagepath based on relativepath property #109815

Pratik Borhade referenced this issue from a commit

2023-09-02 07:20:02 +02:00

Fix #109561: Overwrite existing imagepath based on relativepath property

Pratik Borhade closed this issue

2023-09-02 07:20:03 +02:00

Blender Bot added

Status

Resolved

and removed