blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 746 Projects 19 Wiki Activity

Add option for Render Layers node to render in native scene resolution #109659

New Issue
Open
opened 2023-07-03 17:51:41 +02:00 by Max-Georg Schulzke · 6 comments
Max-Georg Schulzke commented 2023-07-03 17:51:41 +02:00
Copy Link

System Information
Operating system: 64bit Windows 10
Graphics card: RTX 3090

Blender Version
Broken: 2.93.6; 3.6.0
Worked: -

Short description of error
When using a file output node to save different scenes in different formats while rendering an animation, the file will always be in the format dimension of the currently active scene.

Possible overlapping with:
#87447

Exact steps for others to reproduce the error
You use the provided sample files and press render.
You will need to navigate to the set output paths in the Compositing node.
C:\OutputTest(3.6) and C:\OutputTest_293(2.93)

Replicate yourself:

  1. open default scene
  2. duplicate scene using "Linked Copy"
  3. in freshly duplicated Scene, change the "Format" > "Resolution" to 9:16 1080x1920
  4. open Compositing > "Use Nodes"
  5. add a "File Output" node > select it
  6. expand "Properties" and create a second output using "Add Input"
  7. duplicate "Render Layers" node and select the other scene in the duplicated "Render Layers" node
  8. plug each "Render Layers ⇾ Image" into one of the inputs of the "File Output" node
  9. now press Render

Expected Result:
Every image is saved by the File Output node in its own resolution, respective of the parent scenes "Format" settings.

Actual Result:
All images have the resolution of the currently selected Scene.

2.93.6 File
OutputNode_Test_293.blend
3.6.0 File
OutputNode_Test_36.blend

**System Information** Operating system: 64bit Windows 10 Graphics card: RTX 3090 **Blender Version** Broken: 2.93.6; 3.6.0 Worked: - **Short description of error** When using a file output node to save different scenes in different formats while rendering an animation, the file will always be in the format dimension of the currently active scene. **Possible overlapping with:** https://projects.blender.org/blender/blender/issues/87447 **Exact steps for others to reproduce the error** You use the provided sample files and press render. You will need to navigate to the set output paths in the Compositing node. C:\OutputTest(3.6) and C:\OutputTest_293(2.93) **Replicate yourself:** 1. open default scene 2. duplicate scene using "Linked Copy" 3. in freshly duplicated Scene, change the "Format" > "Resolution" to 9:16 1080x1920 4. open Compositing > "Use Nodes" 5. add a "File Output" node > select it 6. expand "Properties" and create a second output using "Add Input" 7. duplicate "Render Layers" node and select the other scene in the duplicated "Render Layers" node 8. plug each "Render Layers ⇾ Image" into one of the inputs of the "File Output" node 9. now press Render **Expected Result:** Every image is saved by the File Output node in its own resolution, respective of the parent scenes "Format" settings. **Actual Result:** All images have the resolution of the currently selected Scene. **2.93.6 File** [OutputNode_Test_293.blend](/attachments/644afeed-1bf0-469b-a76d-d750ef2e9970) **3.6.0 File** [OutputNode_Test_36.blend](/attachments/9bb2828b-7679-4fde-9d7d-80babc9e0d7a)
OutputNode_Test_293.blend
862 KiB
OutputNode_Test_36.blend
979 KiB
Max-Georg Schulzke added the
Status
Needs Triage
Type
Report
Priority
Normal
 labels 2023-07-03 17:51:42 +02:00
Pratik Borhade commented 2023-07-04 10:53:42 +02:00
Member
Copy Link

Thanks for the report. I can confirm. I'll check

Thanks for the report. I can confirm. I'll check
Pratik Borhade added
Module
VFX & Video
Status
Confirmed
 and removed
Status
Needs Triage
 labels 2023-07-04 10:53:55 +02:00
Philipp Oeser commented 2023-07-04 11:48:23 +02:00
Member
Copy Link

It seems do_render_compositor_scene uses the same Render for all scenes.
And this seems somewhat expected, see the following comment:

/* Render scene into render result, within a compositor node tree.
 * Uses the same image dimensions, does not recursively perform compositing. */

However, apparently there was some thought into using own resolution as well:

/* exception: scene uses own size (unfinished code) */

Here is a hakish/unfinished version that would use the scene's own size, BUT

  • that would probably break old files that rely on this
  • needs further investigation wrt crop and size percentage (should this be used from the orig scene?)
  • maybe this could be an option on the renderlayers node?
  • needs further input from render pipeline devs (@brecht might want to share insights?)
diff --git a/source/blender/render/intern/pipeline.cc b/source/blender/render/intern/pipeline.cc
index a146b4d62b1..522cad5b67f 100644
--- a/source/blender/render/intern/pipeline.cc
+++ b/source/blender/render/intern/pipeline.cc
@@ -1125,12 +1125,20 @@ static void do_render_compositor_scene(Render *re, Scene *sce, int cfra)
   BKE_scene_camera_switch_update(sce);
 
   /* exception: scene uses own size (unfinished code) */
-  if (false) {
+  rcti disprect_new;
+  bool use_own_size = true;
+  if (use_own_size) {
     BKE_render_resolution(&sce->r, false, &winx, &winy);
-  }
+    resc->r.xsch = winx;
+    resc->r.ysch = winy;
 
+    disprect_new.xmin = 0;
+    disprect_new.xmax = winx;
+    disprect_new.ymin = 0;
+    disprect_new.ymax = winy;
+  }
   /* initial setup */
-  RE_InitState(resc, re, &sce->r, &sce->view_layers, nullptr, winx, winy, &re->disprect);
+  RE_InitState(resc, use_own_size ? nullptr : re, &sce->r, &sce->view_layers, nullptr, winx, winy, use_own_size ? &disprect_new : &re->disprect);
 
   /* We still want to use 'rendercache' setting from org (main) scene... */
   resc->r.scemode = (resc->r.scemode & ~R_EXR_CACHE_FILE) | (re->r.scemode & R_EXR_CACHE_FILE);
It seems `do_render_compositor_scene` uses the same `Render` for all scenes. And this seems somewhat expected, see the following comment: ``` /* Render scene into render result, within a compositor node tree. * Uses the same image dimensions, does not recursively perform compositing. */ ``` However, apparently there was some thought into using own resolution as well: `/* exception: scene uses own size (unfinished code) */` Here is a hakish/unfinished version that would use the scene's own size, BUT - that would probably break old files that rely on this - needs further investigation wrt crop and size percentage (should this be used from the orig scene?) - maybe this could be an option on the renderlayers node? - needs further input from render pipeline devs (@brecht might want to share insights?) ``` diff --git a/source/blender/render/intern/pipeline.cc b/source/blender/render/intern/pipeline.cc index a146b4d62b1..522cad5b67f 100644 --- a/source/blender/render/intern/pipeline.cc +++ b/source/blender/render/intern/pipeline.cc @@ -1125,12 +1125,20 @@ static void do_render_compositor_scene(Render *re, Scene *sce, int cfra) BKE_scene_camera_switch_update(sce); /* exception: scene uses own size (unfinished code) */ - if (false) { + rcti disprect_new; + bool use_own_size = true; + if (use_own_size) { BKE_render_resolution(&sce->r, false, &winx, &winy); - } + resc->r.xsch = winx; + resc->r.ysch = winy; + disprect_new.xmin = 0; + disprect_new.xmax = winx; + disprect_new.ymin = 0; + disprect_new.ymax = winy; + } /* initial setup */ - RE_InitState(resc, re, &sce->r, &sce->view_layers, nullptr, winx, winy, &re->disprect); + RE_InitState(resc, use_own_size ? nullptr : re, &sce->r, &sce->view_layers, nullptr, winx, winy, use_own_size ? &disprect_new : &re->disprect); /* We still want to use 'rendercache' setting from org (main) scene... */ resc->r.scemode = (resc->r.scemode & ~R_EXR_CACHE_FILE) | (re->r.scemode & R_EXR_CACHE_FILE); ```
Philipp Oeser commented 2023-07-04 11:51:57 +02:00
Member
Copy Link

Note: it does seem a bit inconsistent, since pushing this button will use the "right" resolution and feed it to the tree:

image

Note: it does seem a bit inconsistent, since pushing this button will use the "right" resolution and feed it to the tree: ![image](/attachments/ebcc8b90-5224-46f2-9a9e-0153a1328cac)
image.png
116 KiB
Brecht Van Lommel commented 2023-07-04 14:53:22 +02:00
Owner
Copy Link

The current state I would not consider a bug, it's working as designed for the common case where you want to composite a bunch of scenes and render layers together into one image. For that case it's convenient to have them all be the same resolution automatically, without e.g. accidentally leaving one scene at e.g. 50% resolution.

I'd be fine with there being an option to control this. Perhaps the resolution % should always be inherited.

The current state I would not consider a bug, it's working as designed for the common case where you want to composite a bunch of scenes and render layers together into one image. For that case it's convenient to have them all be the same resolution automatically, without e.g. accidentally leaving one scene at e.g. 50% resolution. I'd be fine with there being an option to control this. Perhaps the resolution % should always be inherited.
Philipp Oeser changed title from File output node only saving Format of the current scene? to Add option for Render Layers node to render in native scene resolution 2023-07-04 15:22:46 +02:00
Philipp Oeser added
Type
To Do
 and removed
Type
Report
 labels 2023-07-04 15:22:56 +02:00
Philipp Oeser commented 2023-07-04 15:23:13 +02:00
Member
Copy Link

Changed to TODO then

Changed to TODO then
Max-Georg Schulzke commented 2023-07-04 16:30:22 +02:00
Author
Copy Link

without e.g. accidentally leaving one scene at e.g. 50% resolution.

I really get your point for a classic composite pipeline

but I mostly do exhibit visualizations with different orthographic, perspective and fpsy formats
some landscape, some portrait and some matching the booth photograph dimensions for the fspy composite
and its really nice to just change the 3D exhibit once and directly push it to the renderfarm and have all the required renders again
for rapid design iterations

thanks for your service to blender

> without e.g. accidentally leaving one scene at e.g. 50% resolution. I really get your point for a classic composite pipeline but I mostly do exhibit visualizations with different orthographic, perspective and fpsy formats some landscape, some portrait and some matching the booth photograph dimensions for the fspy composite and its really nice to just change the 3D exhibit once and directly push it to the renderfarm and have all the required renders again for rapid design iterations thanks for your service to blender
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109659
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?