GPv3: Select Similar #109734

New Issue

Falk David · 2023-07-05T12:34:11+02:00

Falk David commented

2023-07-05 12:34:11 +02:00

This operator should replace the GPENCIL_OT_select_grouped and GPENCIL_OT_select_vertex_color operators.

Difficulty: 🔴🔴🔴

Add a new operator GREASE_PENCIL_OT_select_similar in blender/source/blender/editors/grease_pencil/intern/grease_pencil_select.cc. It should have an enum for the type, values for comparing to color, and floats as well as a threshold. The type should support layer, material, vertex_color, radius and opacity.
It's probably a good idea to write a static templated function that can return an IndexMask (either for the curves domain or the point domain) with the curves/points that should be selected. Something like mask_similar_elements.
Then it's possible to use index_mask::masked_fill to fill the masked indices in the selection attribute. Similar to how it is done in select_ends_exec in blender/source/blender/editors/curves/intern/curves_ops.cc.

This operator should replace the `GPENCIL_OT_select_grouped` and `GPENCIL_OT_select_vertex_color` operators. Difficulty: 🔴🔴🔴 Add a new operator `GREASE_PENCIL_OT_select_similar` in `blender/source/blender/editors/grease_pencil/intern/grease_pencil_select.cc`. It should have an enum for the `type`, values for comparing to color, and floats as well as a threshold. The type should support `layer`, `material`, `vertex_color`, `radius` and `opacity`. It's probably a good idea to write a static templated function that can return an `IndexMask` (either for the curves domain or the point domain) with the curves/points that should be selected. Something like `mask_similar_elements`. Then it's possible to use `index_mask::masked_fill` to fill the masked indices in the selection attribute. Similar to how it is done in `select_ends_exec` in `blender/source/blender/editors/curves/intern/curves_ops.cc`.

Falk David added the

Type

To Do

label 2023-07-05 12:34:11 +02:00

Falk David added this to the Grease Pencil project 2023-07-05 12:34:13 +02:00

Falk David referenced this issue

2023-07-05 12:34:51 +02:00

Selection Operators #107645

Matias Mendiola commented

2023-07-05 14:28:10 +02:00

Other selection could be added to this operator like select similar stroke length, vertex group, etc. See
https://projects.blender.org/blender/blender/pulls/104502#issuecomment-884237

Other selection could be added to this operator like select similar **stroke length**, **vertex group**, etc. See [https://projects.blender.org/blender/blender/pulls/104502#issuecomment-884237](url)

Chao Li commented

2023-07-08 05:09:41 +02:00

Hello. Has this task been taken? Although this seems a bit challenging to me, I'd like to give it a try.

Falk David commented

2023-07-09 13:13:47 +02:00

@Chao-Li Not as far as I know. If you want to give it a try, I'll move the task to the In Progress column

Chao Li commented

2023-07-09 21:57:16 +02:00

Thank you but please leave it in the To Do column for now. I just took a closer look. I feel like it's out of my scope and it may take more time than I have to figure it out. Hopefully someone will pick this up soon. I look forward to contribute to other community tasks in the future!

Lorenzo-Carpaneto commented

2023-07-18 20:09:57 +02:00

If it's not urgent, I would like to pick up this task :)

Falk David commented

2023-07-18 20:21:18 +02:00

@Lorenzo-Carpaneto Great. I moved it to the "In Progress" column

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPv3: Select Similar #109734