VSE: Some "Select Grouped" operators don't work as expected #109932

New Issue

Matthew Hinson · 2023-07-10T20:05:44+02:00

Matthew Hinson commented

2023-07-10 20:05:44 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-10 12:57, hash: 37d1d4cb07e6
Worked: (unknown)

Short description of error

Some of the operators in the VSE's "Select -> Grouped" menu have wrong/confusing names or don't behave as expected.

Select -> Grouped -> Effect Type

Despite the name and the tooltip, this operator does not check the effect type. It only checks whether the strip is an effect or not. Maybe it could be renamed to "Is Effect"? Similarly, the vague "Global Type" could be renamed to "Is Sound".

Select -> Grouped -> Data

When run on a file-based strip, it selects all strips pointing to the same folder rather than to the same file. This may be correct behavior for image sequences, but not for everything else (movies, sounds, single images).

In the screenshot below, the expectation is that it only adds the second strip to the selection, not the third.

Select -> Grouped -> Effect

Going by the tooltip ("Shared effects"), you'd expect that this operator selects content strips that share an effect strip with the active strip. Instead, it finds the effect types linked to the active strip, then selects any other content strips linked to that same effect type.

(So really, this should have been the "Effect Type" operator above)

In the screenshot below, I'd expect that it only adds "2.png" to the selection. Instead, it adds all the strips that are affected by an "Add" effect.

Select -> Grouped -> Effect/Linked

Apart from the tooltip not being very clear, this operator doesn't work at all (simply deselects everything) unless "Extend" is enabled in the "Adjust Last Operation" panel.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-10 12:57, hash: `37d1d4cb07e6` Worked: (unknown) **Short description of error** Some of the operators in the VSE's "Select -> Grouped" menu have wrong/confusing names or don't behave as expected. --- `Select -> Grouped -> Effect Type` Despite the name and the tooltip, this operator does not check the effect type. It only checks whether the strip is an effect or not. Maybe it could be renamed to "Is Effect"? Similarly, the vague "Global Type" could be renamed to "Is Sound". --- `Select -> Grouped -> Data` When run on a file-based strip, it selects all strips pointing to the same folder rather than to the same file. This may be correct behavior for image sequences, but not for everything else (movies, sounds, single images). In the screenshot below, the expectation is that it only adds the second strip to the selection, not the third. ![image](/attachments/37a8ca43-57c6-42df-a0f9-5863ecf38d0f) --- `Select -> Grouped -> Effect` Going by the tooltip ("Shared effects"), you'd expect that this operator selects content strips that share an effect strip with the active strip. Instead, it finds the effect *types* linked to the active strip, then selects any other content strips linked to that same effect type. (So really, this should have been the "Effect Type" operator above) In the screenshot below, I'd expect that it only adds "2.png" to the selection. Instead, it adds all the strips that are affected by an "Add" effect. ![image](/attachments/087d6589-2296-49fd-b01c-d9b56f38fe44) --- `Select -> Grouped -> Effect/Linked` Apart from the tooltip not being very clear, this operator doesn't work at all (simply deselects everything) unless "Extend" is enabled in the "Adjust Last Operation" panel.

image.png

12 KiB

image.png

28 KiB

Matthew Hinson added the

labels 2023-07-10 20:05:45 +02:00