Spline nodes misnomer #110555

New Issue

Miles Cooley · 2023-07-27T23:31:21+02:00

Miles Cooley commented

2023-07-27 23:31:21 +02:00

Blender Version
Broken: ~2.4.1

Summary: Several nodes that operate on splines inaccurately refer to splines as curves.

From https://docs.blender.org/manual/en/latest/modeling/curves/structure.html
"Splines are a substructure of curves and are the individual elements that make curve objects. A curve object can be composed of several different splines, just like mesh objects can have different discontinuous meshes under the same object."

This is reflected in the Spline option of the Domain selector (Capture Attribute, Sample Index, etc), and in the Spline nodes (Spline Length, Spline Parameter, (Set) Spline Resolution, Set Spline Type, Is/Set Spline Cyclic), and in Domain Size > Curve > Spline Count.

However, two of the new Curve Topology nodes and the Sample Curve node break this naming convention, as follows:

"Curve of Point" should be "Spline of Point"
- Outputs
  - "Curve Index" should be "Spline Index"
    - Tooltip: "curve" should be "spline"
  - "Index in Curve" should be "Index in Spline"
    - Tooltip should be reworded: "The index of the control point starting from the first control point in the spline."
      (This wording follows the form set by the Face of Corner > Index in Face tooltip.)
"Points of Curve" should be "Points of Spline"
- Inputs
  - "Curve Index" should be "Spline Index"
    - Tooltip should be updated (both "curve"s should be "spline"s).
  - Weights
    - Tooltip: "the curve's points" should be "each spline's points"
- Outputs
  - Point Index
    - Tooltip: "curve" should be "spline"
Sample Curve
- Options
  - "All Curves" should be "All Splines"
    - Tooltip should be updated (both "curve"s should be "spline"s).
- Inputs
  - "Curves" should be "Curve"
  - "Curve Index" should be "Spline Index"

These changes would greatly improve the understandability of the Curve Topology nodes and how they operate.

**Blender Version** Broken: ~2.4.1 Summary: Several nodes that operate on splines inaccurately refer to splines as curves. From https://docs.blender.org/manual/en/latest/modeling/curves/structure.html "Splines are a substructure of curves and are the individual elements that make curve objects. A curve object can be composed of several different splines, just like mesh objects can have different discontinuous meshes under the same object." This is reflected in the Spline option of the Domain selector (Capture Attribute, Sample Index, etc), and in the Spline nodes (Spline Length, Spline Parameter, (Set) Spline Resolution, Set Spline Type, Is/Set Spline Cyclic), and in Domain Size > Curve > Spline Count. However, two of the new Curve Topology nodes and the Sample Curve node break this naming convention, as follows: - "Curve of Point" should be "Spline of Point" - Outputs - "Curve Index" should be "Spline Index" - Tooltip: "curve" should be "spline" - "Index in Curve" should be "Index in Spline" - Tooltip should be reworded: "The index of the control point starting from the first control point in the spline." (This wording follows the form set by the Face of Corner > Index in Face tooltip.) - "Points of Curve" should be "Points of Spline" - Inputs - "Curve Index" should be "Spline Index" - Tooltip should be updated (both "curve"s should be "spline"s). - Weights - Tooltip: "the curve's points" should be "each spline's points" - Outputs - Point Index - Tooltip: "curve" should be "spline" - Sample Curve - Options - "All Curves" should be "All Splines" - Tooltip should be updated (both "curve"s should be "spline"s). - Inputs - "Curves" should be "Curve" - "Curve Index" should be "Spline Index" These changes would greatly improve the understandability of the Curve Topology nodes and how they operate.

blender-curve-misnomers.png

230 KiB

👀 1

Miles Cooley added the

labels 2023-07-27 23:31:22 +02:00

Hans Goudey commented

2023-07-28 04:08:37 +02:00

Thanks for the report. This isn't a bug though, just an incomplete naming convention change (mentioned here #102607). The reason for the slow progress is that we want to avoid making this a breaking change, but some inconsistencies in the Python API mean we have no way to change the socket labels without changing how they're addressed with the Python API. Hopefully we'll get a chance to change that in 4.0.

Since this is already mentioned in the task I linked though, I'll close this report.

Thanks for the report. This isn't a bug though, just an incomplete naming convention change (mentioned here #102607). The reason for the slow progress is that we want to avoid making this a breaking change, but some inconsistencies in the Python API mean we have no way to change the socket labels without changing how they're addressed with the Python API. Hopefully we'll get a chance to change that in 4.0. Since this is already mentioned in the task I linked though, I'll close this report.

Hans Goudey closed this issue

2023-07-28 04:08:39 +02:00

Blender Bot added

and removed

labels 2023-07-28 04:08:40 +02:00

Sign in to join this conversation.