VSE: Blade tool in Hard mode performs a Soft split (+ UI inconsistencies) #110835

New Issue

Matthew Hinson · 2023-08-05T18:18:49+02:00

Matthew Hinson commented

2023-08-05 18:18:49 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.67

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-10 12:57, hash: 37d1d4cb07e6
Worked: (unknown)

Short description of error
The Tool Settings of the "Blade" tool let you choose between "Soft" and "Hard" splits, but both options perform a soft split.

Apart from this, there are some UI inconsistencies:

The tool is called "Blade", but the equivalent operation in the Strip menu is called "Split".
The tool's settings are called "Soft" and "Hard", but the equivalent operations in the Strip menu are called "Split" and "Hold Split".
The context menu has "Split" but is missing "Hold Split". (Maybe this one is intentional)
The context menu shows the "K" keyboard shortcut, but the Strip menu does not. (As a result of this point and the above, the "Shift-K" keyboard shortcut for performing a Hard/Hold Split is not discoverable in the UI.)

Exact steps for others to reproduce the error

Open the VSE.
Add a movie strip.
Place the Playhead somewhere in the middle and click Strip -> Hold Split.
Delete the strip after the Playhead and drag the right handle of the remaining strip to the right. Notice that the newly revealed frames in the strip are dark blue; they're Hold frames as expected.
Delete the strip and re-add it.
Select the Blade tool, set the split type to "Hard" in the Tool Settings, and click somewhere in the strip.
Delete the strip after the Playhead and drag the right handle of the remaining strip to the right. Notice that the newly revealed frames in the strip are not dark blue; we got a Soft (non-Hold) split.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.67 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-10 12:57, hash: `37d1d4cb07e6` Worked: (unknown) **Short description of error** The Tool Settings of the "Blade" tool let you choose between "Soft" and "Hard" splits, but both options perform a soft split. Apart from this, there are some UI inconsistencies: * The tool is called "Blade", but the equivalent operation in the Strip menu is called "Split". * The tool's settings are called "Soft" and "Hard", but the equivalent operations in the Strip menu are called "Split" and "Hold Split". * The context menu has "Split" but is missing "Hold Split". (Maybe this one is intentional) * The context menu shows the "K" keyboard shortcut, but the Strip menu does not. (As a result of this point and the above, the "Shift-K" keyboard shortcut for performing a Hard/Hold Split is not discoverable in the UI.) **Exact steps for others to reproduce the error** * Open the VSE. * Add a movie strip. * Place the Playhead somewhere in the middle and click Strip -> Hold Split. * Delete the strip after the Playhead and drag the right handle of the remaining strip to the right. Notice that the newly revealed frames in the strip are dark blue; they're Hold frames as expected. * Delete the strip and re-add it. * Select the Blade tool, set the split type to "Hard" in the Tool Settings, and click somewhere in the strip. * Delete the strip after the Playhead and drag the right handle of the remaining strip to the right. Notice that the newly revealed frames in the strip are *not* dark blue; we got a Soft (non-Hold) split.

Matthew Hinson added the

labels 2023-08-05 18:18:50 +02:00

YimingWu commented

2023-08-06 05:44:47 +02:00

Can confirm. Happening in 3.6.1 as well.

Somehow type is never set when sequencer_split_invoke is called.