Anim: Theme confusion with 'Pose Bone' label #110874

New Issue

sanek122005 · 2023-08-07T08:00:57+02:00

sanek122005 commented

2023-08-07 08:00:57 +02:00

Blender Version
Broken: 3.6.1

Short description of error

Edit Mode:

Unselected head/tails should use "Wire Edit" instead of "Vertex".
Selected head/tails should use "Edge Select" instead of "Wire".

Pose Mode:

Unselected outline color currently uses "Wire", which is also used for a lot of other things. Would be nice to have a separate "Bone Outline" color, although this would only affect un-colored bones.
"Bone Pose" theme color name is inaccurate, should be "Bone Pose Selected" instead.

**Blender Version** Broken: 3.6.1 **Short description of error** Edit Mode: 1. Unselected head/tails should use "Wire Edit" instead of "Vertex". 2. Selected head/tails should use "Edge Select" instead of "Wire". <video src="/attachments/f78c01df-0ff5-4393-bbb6-e3c3250ac50c" title="2023-08-07 08-56-49.mp4" controls></video> Pose Mode: 1. Unselected outline color currently uses "Wire", which is also used for a lot of other things. Would be nice to have a separate "Bone Outline" color, although this would only affect un-colored bones. 2. "Bone Pose" theme color name is inaccurate, should be "Bone Pose Selected" instead. <video src="/attachments/138a14e4-fece-4006-88f9-1713df8f5ff6" title="2023-08-07 08-58-49.mp4" controls></video>

2023-08-07 08-58-49.mp4

8.4 MiB

2023-08-07 08-56-49.mp4

6.3 MiB

sanek122005 added the

labels 2023-08-07 08:00:58 +02:00

Pratik Borhade commented

2023-08-07 09:06:17 +02:00

The Head/Tail of bone uses color of vertex, including when selecting state. There should be a separate parameter for the color of the Head/Tail itself, and the color when they are selected

Hi, thanks for the report. This is more of a request than a bug. Existing edge/wire theme colors are used for edit and pose bones: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/intern/draw_common.cc#L105

  UI_GetThemeColor4fv(TH_BONE_POSE, gb->color_bone_pose);
  UI_GetThemeColor4fv(TH_BONE_POSE_ACTIVE, gb->color_bone_pose_active);
  UI_GetThemeColorShade4fv(TH_EDGE_SELECT, 60, gb->color_bone_active);
  UI_GetThemeColorShade4fv(TH_EDGE_SELECT, -20, gb->color_bone_select);
  UI_GetThemeColorBlendShade4fv(TH_WIRE, TH_BONE_POSE, 0.15f, 0, gb->color_bone_pose_active_unsel);

Outline of bone body uses Wire edit color, outline when bone is selected don`t have parameter

bone outline when don`t select, uses Wire color, it's inconvenient

Yes, if nothing is selected, default wire color is used, see : get_pchan_color_wire

"Pose bone" - the confusing parameter name... it should be called "Pose bone Selected"

Agree, this should be renamed. 😅

Forwarding to A&R devs for the decision.

> The Head/Tail of bone uses color of vertex, including when selecting state. There should be a separate parameter for the color of the Head/Tail itself, and the color when they are selected Hi, thanks for the report. This is more of a request than a bug. Existing edge/wire theme colors are used for edit and pose bones: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/intern/draw_common.cc#L105 ``` UI_GetThemeColor4fv(TH_BONE_POSE, gb->color_bone_pose); UI_GetThemeColor4fv(TH_BONE_POSE_ACTIVE, gb->color_bone_pose_active); UI_GetThemeColorShade4fv(TH_EDGE_SELECT, 60, gb->color_bone_active); UI_GetThemeColorShade4fv(TH_EDGE_SELECT, -20, gb->color_bone_select); UI_GetThemeColorBlendShade4fv(TH_WIRE, TH_BONE_POSE, 0.15f, 0, gb->color_bone_pose_active_unsel); ``` - - - > - Outline of bone body uses Wire edit color, outline when bone is selected don`t have parameter > - bone outline when don`t select, uses Wire color, it's inconvenient Yes, if nothing is selected, default wire color is used, see : [get_pchan_color_wire]( https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/overlay_armature.cc#L1189) - - - > "Pose bone" - the confusing parameter name... it should be called "Pose bone Selected" Agree, this should be renamed. 😅 Forwarding to A&R devs for the decision.

Pratik Borhade added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Anim: Theme confusion with 'Pose Bone' label #110874