Multires: Subdivision Set Relative is subdividing the object #110879

Open
opened 2023-08-07 10:28:13 +02:00 by Julien Kaspar · 4 comments
Member

System Information
Operating system: Linux-6.4.6-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI
Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 15.0.7, DRM 3.52, 6.4.6-gentoo) AMD 4.6 (Core Profile) Mesa 23.3.0-devel (git-50c29e1ffa)

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-06 21:11, hash: 93728fee53dc
Worked: --

Short description of error
With 6de6d7267f the shortcuts to increase or decrease the current multires level in sculpt mode are more accessible and more often used. This highlighted an issue.

There is a corner case where the relative level change is subdividing the multires.
If there is no multires detected yet, object.subdivision_set will create a multires modifier and the target level. This is useful when using the shortcuts Ctrl 1-6 to set an absolute level.
But the purpose of the relative option is just to go up & down existing levels.
When set to relative, it is not able to create new levels when a multires modifier is already detected.

This is an especially bad issue in the industry compatible keymap, where the shortcuts are currently being changed to be more accessible on D which is then very easy to press by accident and subdivide the mesh (#109750).

The ideal behavior would be that the object.subdivision_set, if set to relative, cannot be able to subdivide nor create a new multires modifier. It can only change existing levels on the an existing multires/subdiv modifier.

Exact steps for others to reproduce the error

  • Create a new object
  • Enter sculpt mode
  • Press Alt 2
  • A new multires modifier has been created with a single subdivision
  • Press Alt 1 and Alt 2 to lower and increase the level
  • Note how no new levels are created
**System Information** Operating system: Linux-6.4.6-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 15.0.7, DRM 3.52, 6.4.6-gentoo) AMD 4.6 (Core Profile) Mesa 23.3.0-devel (git-50c29e1ffa) **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-06 21:11, hash: `93728fee53dc` Worked: -- **Short description of error** With 6de6d7267f the shortcuts to increase or decrease the current multires level in sculpt mode are more accessible and more often used. This highlighted an issue. There is a corner case where the relative level change is subdividing the multires. If there is no multires detected yet, `object.subdivision_set` will create a multires modifier and the target level. This is useful when using the shortcuts `Ctrl 1-6` to set an absolute level. But the purpose of the relative option is just to go up & down existing levels. When set to relative, it is not able to create new levels when a multires modifier is already detected. This is an especially bad issue in the industry compatible keymap, where the shortcuts are currently being changed to be more accessible on `D` which is then very easy to press by accident and subdivide the mesh (#109750). The ideal behavior would be that the `object.subdivision_set`, if set to relative, cannot be able to subdivide nor create a new multires modifier. It can only change existing levels on the an existing multires/subdiv modifier. **Exact steps for others to reproduce the error** - Create a new object - Enter sculpt mode - Press `Alt 2` - A new multires modifier has been created with a single subdivision - Press `Alt 1` and `Alt 2` to lower and increase the level - Note how no new levels are created
Iliya Katushenock added
Interest
Sculpt, Paint & Texture
and removed
Module
Sculpt, Paint & Texture
labels 2023-08-07 11:59:40 +02:00

Should I confirm that Alt + 3 does nothing for me?

Should I confirm that `Alt + 3` does nothing for me?

Agree with the suggestion, although making the change depend on "relative" seems a little hidden. It could be a boolean option to add the modifier which the key-map sets to false as needed.

Agree with the suggestion, although making the change depend on "relative" seems a little hidden. It could be a boolean option to add the modifier which the key-map sets to false as needed.
Member

Can confirm.

Should I confirm that Alt + 3 does nothing for me?

This is expected. Alt + 3 is not mapped to create subdivision or change the level (it hides the object collection)

Can confirm. > Should I confirm that Alt + 3 does nothing for me? This is expected. Alt + 3 is not mapped to create subdivision or change the level (it hides the object collection)
Pratik Borhade added
Module
User Interface
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-08-08 05:59:36 +02:00
Author
Member

@ideasman42 Sounds great! We could make this two extra bool options for "subdivide" and "ensure modifier"? For the purpose of these sculpt mode shortcuts both these should be set to false.

@ideasman42 Sounds great! We could make this two extra bool options for "subdivide" and "ensure modifier"? For the purpose of these sculpt mode shortcuts both these should be set to false.
Julien Kaspar added
Type
Bug
and removed
Type
Report
labels 2023-08-08 10:18:40 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110879
No description provided.