Remove early 2.80 development 'scene collection' compatibility code #110918

New Issue

Closed

opened 2023-08-08 11:16:30 +02:00 by Bastien Montagne · 11 comments

Bastien Montagne commented

2023-08-08 11:16:30 +02:00

Owner

We still have a bit of compatibility code for early 2.80 development era blendfiles, to convert SceneCollection data (see USE_COLLECTION_COMPAT_28 define usages).

This proposal is to remove this compatibility code, since:

This is now (almost?) 4 years old.
These files were never produced by any released Blender version (so removing it would not go against our compatibility policy).

While not a big amount of code, this conversion is a bit annoying as it creeps into the generic readfile process. So not a big deal to keep it, but also do not really see the point of keeping it further.

We still have a bit of compatibility code for early 2.80 development era blendfiles, to convert `SceneCollection` data (see `USE_COLLECTION_COMPAT_28` define usages). This proposal is to remove this compatibility code, since: * This is now (almost?) 4 years old. * These files were never produced by any released Blender version (so removing it would not go against our compatibility policy). While not a big amount of code, this conversion is a bit annoying as it creeps into the generic readfile process. So not a big deal to keep it, but also do not really see the point of keeping it further.

Bastien Montagne added this to the 4.0 milestone 2023-08-08 11:16:30 +02:00

Bastien Montagne added the

labels 2023-08-08 11:16:31 +02:00

Bastien Montagne commented

2023-08-08 11:17:02 +02:00

Author

Owner

@brecht @Sergey @dfelinto @ideasman42 thoughts?

@brecht @Sergey @dfelinto @ideasman42 thoughts?

Sergey Sharybin commented

2023-08-08 11:20:01 +02:00

Owner

I think it is fine to remove this compatibility code.

I think it is fine to remove this compatibility code.

Bastien Montagne added the

label 2023-08-08 11:21:49 +02:00

Bastien Montagne referenced this issue

2023-08-08 15:10:15 +02:00

Remove compatibility code for blendfiles from early 2.80 development era. #110926

Bastien Montagne commented

2023-08-08 15:11:42 +02:00

Author

Owner

Proposed implementation in !110926.

Proposed implementation in !110926.

Campbell Barton commented

2023-08-08 15:29:13 +02:00

Owner

+1 to remove.

+1 to remove.

Dalai Felinto commented

2023-08-09 03:44:49 +02:00

Owner

Fine by me

Fine by me

Bastien Montagne referenced this issue from a commit

2023-08-09 11:15:34 +02:00

Remove compatibility code for blendfiles from early 2.80 development era.

Bastien Montagne commented

2023-08-09 11:23:01 +02:00

Author

Owner

Thanks, committed as 23835a393c.

Thanks, committed as 23835a393c.

Christian Clavet commented

2023-08-14 15:32:56 +02:00

Question from a non-developer about removing compatibility with older blender format...

Is there a tool that could convert all the old format files from the old blenders release to the current release?
If someone have a old project that he forgot to port the new version, it will be difficult to update it.

At some point, I really understand the point of removing theses codes and make the whole package smaller and more efficient. How about a separate tool that would do the job? Does it exist?

Question from a non-developer about removing compatibility with older blender format... Is there a tool that could convert all the old format files from the old blenders release to the current release? If someone have a old project that he forgot to port the new version, it will be difficult to update it. At some point, I really understand the point of removing theses codes and make the whole package smaller and more efficient. How about a separate tool that would do the job? Does it exist?

Sergey Sharybin commented

2023-08-14 15:39:11 +02:00

Owner

@christian-clavet Code which keeps compatibility with older Blender releases is hardly ever being removed. When it is removed, it means the feature is gone, and it having an external tool will not help you.

The code removed in this patch was for compatibility with files stored with development version of Blender from 2.80 cycle. Surely there is some possibility of existing .blend stored in that format, but chances of that are very low.

if you really run into such files, it is easier to open the file in Blender 3.6 and save and open in 4.0, than to maintain an external compatibility tool.

@christian-clavet Code which keeps compatibility with older Blender releases is hardly ever being removed. When it is removed, it means the feature is gone, and it having an external tool will not help you. The code removed in this patch was for compatibility with files stored with development version of Blender from 2.80 cycle. Surely there is some possibility of existing .blend stored in that format, but chances of that are very low. if you really run into such files, it is easier to open the file in Blender 3.6 and save and open in 4.0, than to maintain an external compatibility tool.

Christian Clavet commented

2023-08-14 16:28:37 +02:00

Thanks @Sergey ! I'll remember to get Blender 3.6 for such tasks.

Thanks @Sergey ! I'll remember to get Blender 3.6 for such tasks.

Campbell Barton commented

2023-08-15 03:20:22 +02:00

Owner

Can this be closed now?

Can this be closed now?

Bastien Montagne commented

2023-08-15 10:24:05 +02:00

Author

Owner

Indeed. forgot this was still open.

Indeed. forgot this was still open.

Bastien Montagne closed this issue

2023-08-15 10:24:07 +02:00

Blender Bot added the

label 2023-08-15 10:24:09 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110918

No description provided.