Click selecting a keyframe in the Dope Sheet deselects all channels #111016

Open
opened 2023-08-10 18:05:02 +02:00 by Christoph Lendenfeld · 7 comments

System Information
Operating system: Linux Mint
Graphics card: RTX 3070

Blender Version
Broken: latest master
Worked: checked until 2.93 and it still was broken

Short description of error
When click selecting a keyframe on a summary channel in the Dopesheet (and the Timeline which is basically a Dopesheet),
it deselects all channels.
If you drag select it, the selection is unchanged.

Click selecting a keyframe that is not on a summary channel does select the channel as well.

I would expect click and drag select to behave the same on summary channels.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

  • open the provided blend file (channels are already selected)
  • click select a keyframe on a summary channel in either the Timeline or the Dope Sheet
  • note the channels are all deselected
**System Information** Operating system: Linux Mint Graphics card: RTX 3070 **Blender Version** Broken: latest master Worked: checked until 2.93 and it still was broken **Short description of error** When click selecting a keyframe on a summary channel in the Dopesheet (and the Timeline which is basically a Dopesheet), it deselects all channels. If you drag select it, the selection is unchanged. Click selecting a keyframe that is not on a summary channel does select the channel as well. I would expect click and drag select to behave the same on summary channels. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). * open the provided blend file (channels are already selected) * click select a keyframe on a summary channel in either the Timeline or the Dope Sheet * note the channels are all deselected
Christoph Lendenfeld added the
Type
Report
Priority
Normal
Status
Needs Triage
labels 2023-08-10 18:05:03 +02:00
Christoph Lendenfeld added this to the Animation & Rigging project 2023-08-10 18:05:04 +02:00
Christoph Lendenfeld changed title from Click selecting a keyframe deselects all channels in Dope Sheet to Click selecting a keyframe in the Dope Sheet deselects all channels 2023-08-10 18:05:37 +02:00
Member

Can confirm.

However it looks like selecting summary channel is different from selecting channels or selecting key frame points in the f-curve viewer. If you select a key frame in summary channel, the keys from f-curve viewer shows a semi-transparent dot, but if you select individual keys or any key that's in the f-curve, it will become a solid dot.

Also moving the key in Dope Sheet and moving the key in f-curve behaves differently, if moved in f-curve it will adjust interpolation handle automatically while in dope sheet it won't.

Not sure about the differences, is this by design? @dr.sybren

Can confirm. However it looks like selecting summary channel is different from selecting channels or selecting key frame points in the f-curve viewer. If you select a key frame in summary channel, the keys from f-curve viewer shows a semi-transparent dot, but if you select individual keys or any key that's in the f-curve, it will become a solid dot. Also moving the key in Dope Sheet and moving the key in f-curve behaves differently, if moved in f-curve it will adjust interpolation handle automatically while in dope sheet it won't. Not sure about the differences, is this by design? @dr.sybren
YimingWu added
Module
Animation & Rigging
Status
Needs Info from Developers
and removed
Status
Needs Triage
labels 2023-08-11 04:07:04 +02:00
Member

I can confirm as well. @ChrisLend , you mean all channels should be selected when keyframe next to group/summary channel is selected? Was this discussed during A&R module meeting?
Can fix this if you explain the expected behavior 😅

I can confirm as well. @ChrisLend , you mean all channels should be selected when keyframe next to `group/summary channel` is selected? Was this discussed during A&R module meeting? Can fix this if you explain the expected behavior 😅
Author
Member

@PratikPB2123 we talked about this in the meeting on Tuesday and the consensus was that it should be consistent with box select. However there were not many animators present so we'll talk about it again on the next thursday meeting

@PratikPB2123 we talked about this in the meeting on Tuesday and the consensus was that it should be consistent with box select. However there were not many animators present so we'll talk about it again on the next thursday meeting
Author
Member

@PratikPB2123 sorry for the delay, this was now discussed in the bigger module meeting and the decision still stands that click select should behave like drag select

@PratikPB2123 sorry for the delay, this was now discussed in the bigger module meeting and the decision still stands that click select should behave like drag select
Christoph Lendenfeld added
Status
Confirmed
and removed
Status
Needs Info from Developers
labels 2023-09-29 16:39:23 +02:00
Christoph Lendenfeld self-assigned this 2023-10-03 10:11:49 +02:00
Author
Member

I was going to have a look at this, but I realized the error description is wrong.
Drag select does not select the channels.

So in order to make it consistent, I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer. This is super useful for layer switching.

Now I am not sure what the best solution would be, so I am unassigning myself again. Also updating the bug description to match the current behavior

I was going to have a look at this, but I realized the error description is wrong. Drag select does not select the channels. So in order to make it consistent, I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer. This is super useful for layer switching. Now I am not sure what the best solution would be, so I am unassigning myself again. Also updating the bug description to match the current behavior
Christoph Lendenfeld removed their assignment 2023-10-03 11:08:31 +02:00
Member

I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer

In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?

> I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?
Author
Member

I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer

In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?

I thought about that as well, but that makes the selection within the dope sheet inconsistent

> > I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer > > In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL? I thought about that as well, but that makes the selection within the dope sheet inconsistent
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111016
No description provided.