Click selecting a keyframe in the Dope Sheet deselects all channels #111016

New Issue

Christoph Lendenfeld · 2023-08-10T18:05:02+02:00

2023-08-10 18:05:02 +02:00

System Information
Operating system: Linux Mint
Graphics card: RTX 3070

Blender Version
Broken: latest master
Worked: checked until 2.93 and it still was broken

Short description of error
When click selecting a keyframe on a summary channel in the Dopesheet (and the Timeline which is basically a Dopesheet),
it deselects all channels.
If you drag select it, the selection is unchanged.

Click selecting a keyframe that is not on a summary channel does select the channel as well.

I would expect click and drag select to behave the same on summary channels.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

open the provided blend file (channels are already selected)
click select a keyframe on a summary channel in either the Timeline or the Dope Sheet
note the channels are all deselected

**System Information** Operating system: Linux Mint Graphics card: RTX 3070 **Blender Version** Broken: latest master Worked: checked until 2.93 and it still was broken **Short description of error** When click selecting a keyframe on a summary channel in the Dopesheet (and the Timeline which is basically a Dopesheet), it deselects all channels. If you drag select it, the selection is unchanged. Click selecting a keyframe that is not on a summary channel does select the channel as well. I would expect click and drag select to behave the same on summary channels. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). * open the provided blend file (channels are already selected) * click select a keyframe on a summary channel in either the Timeline or the Dope Sheet * note the channels are all deselected

key_selection_test.blend

842 KiB

👍 1

Christoph Lendenfeld added the

labels 2023-08-10 18:05:03 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-08-10 18:05:04 +02:00

Christoph Lendenfeld changed title from ~~Click selecting a keyframe deselects all channels in Dope Sheet~~ to Click selecting a keyframe in the Dope Sheet deselects all channels

2023-08-10 18:05:37 +02:00

YimingWu commented

2023-08-11 04:06:50 +02:00

Can confirm.

However it looks like selecting summary channel is different from selecting channels or selecting key frame points in the f-curve viewer. If you select a key frame in summary channel, the keys from f-curve viewer shows a semi-transparent dot, but if you select individual keys or any key that's in the f-curve, it will become a solid dot.

Also moving the key in Dope Sheet and moving the key in f-curve behaves differently, if moved in f-curve it will adjust interpolation handle automatically while in dope sheet it won't.

Not sure about the differences, is this by design? @dr.sybren

Can confirm. However it looks like selecting summary channel is different from selecting channels or selecting key frame points in the f-curve viewer. If you select a key frame in summary channel, the keys from f-curve viewer shows a semi-transparent dot, but if you select individual keys or any key that's in the f-curve, it will become a solid dot. Also moving the key in Dope Sheet and moving the key in f-curve behaves differently, if moved in f-curve it will adjust interpolation handle automatically while in dope sheet it won't. Not sure about the differences, is this by design? @dr.sybren

YimingWu added

Module

Animation & Rigging

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-08-11 04:07:04 +02:00

Pratik Borhade commented

2023-08-14 07:18:58 +02:00

I can confirm as well. @ChrisLend , you mean all channels should be selected when keyframe next to group/summary channel is selected? Was this discussed during A&R module meeting?
Can fix this if you explain the expected behavior 😅

I can confirm as well. @ChrisLend , you mean all channels should be selected when keyframe next to `group/summary channel` is selected? Was this discussed during A&R module meeting? Can fix this if you explain the expected behavior 😅

Christoph Lendenfeld commented

2023-08-17 09:10:21 +02:00

@PratikPB2123 we talked about this in the meeting on Tuesday and the consensus was that it should be consistent with box select. However there were not many animators present so we'll talk about it again on the next thursday meeting

👍 1

Christoph Lendenfeld commented

2023-09-14 19:11:05 +02:00

@PratikPB2123 sorry for the delay, this was now discussed in the bigger module meeting and the decision still stands that click select should behave like drag select

Christoph Lendenfeld added

Status

Confirmed

and removed

Status

Needs Info from Developers

labels 2023-09-29 16:39:23 +02:00

Christoph Lendenfeld self-assigned this 2023-10-03 10:11:49 +02:00

Christoph Lendenfeld commented

2023-10-03 11:08:24 +02:00

I was going to have a look at this, but I realized the error description is wrong.
Drag select does not select the channels.

So in order to make it consistent, I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer. This is super useful for layer switching.

Now I am not sure what the best solution would be, so I am unassigning myself again. Also updating the bug description to match the current behavior

I was going to have a look at this, but I realized the error description is wrong. Drag select does not select the channels. So in order to make it consistent, I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer. This is super useful for layer switching. Now I am not sure what the best solution would be, so I am unassigning myself again. Also updating the bug description to match the current behavior

Christoph Lendenfeld removed their assignment 2023-10-03 11:08:31 +02:00

Pratik Borhade commented

2023-10-03 11:31:13 +02:00

I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer

In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?

> I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?

Christoph Lendenfeld commented

2023-10-03 12:41:36 +02:00

I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer

In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL?

I thought about that as well, but that makes the selection within the dope sheet inconsistent

> > I tried removing the behavior of selecting the channel when a key is selected. That conflicts with Grease Pencil though, where selecting a key selects the channel and the layer > > In that case, clear channel selection (and highlight selected key-channel) when datatype is ANIMCONT_GPENCIL? I thought about that as well, but that makes the selection within the dope sheet inconsistent

Christoph Lendenfeld referenced this issue

2023-10-06 12:15:46 +02:00

"Clean Keyframes" in Dope Sheet only works if channels are selected #87160

Bart van der Braak added

and removed

labels 2024-08-14 13:10:01 +02:00

Sign in to join this conversation.