Item panel displays incorrect weights for active vertex #111306

Closed
opened 2023-08-19 22:40:45 +02:00 by Robert-MacDavid · 2 comments

System Information
Operating system: Windows 10
Graphics card: Nvidia Titan X (Pascal)

Blender Version
Broken: 3.6.2
Worked: Dunno, a few weeks ago.

Short description of error
When one vertex is selected in edit mode on a weight painted model, incorrect weights for all but one vertex group are displayed in the Item->Vertex Weights panel. They are all displayed as equal to the final groups weight. If the groups are reordered, the displayed weights change to match the new final group's weight.

It appears the bug was introduced by this commit: cd74ba6413
Each groups weight was previously stored in a loop-local variable (dw->weight) when passed to the drawing function but they are now stored in a shared, non-loop-local variable (tfp->active_vertex_weight). This causes each loop iteration to clobber the weight set by the last iteration, resulting in the final iteration's weight being displayed for all groups.
At least, that is what I think I'm seeing. I don't know what language this is so I don't know how to try testing my hypothesis.

Exact steps for others to reproduce the error
The attached .blend has a default cube with four weight groups and reproduces the error in 3.6.2. To reproduce in any file, select one vertex on any weight painted model and view the vertex group weights in the item panel in edit mode. The weight of each vertex group will be displayed as identical to the final groups' weight.

**System Information** Operating system: Windows 10 Graphics card: Nvidia Titan X (Pascal) **Blender Version** Broken: 3.6.2 Worked: Dunno, a few weeks ago. **Short description of error** When one vertex is selected in edit mode on a weight painted model, incorrect weights for all but one vertex group are displayed in the Item->Vertex Weights panel. They are all displayed as equal to the final groups weight. If the groups are reordered, the displayed weights change to match the new final group's weight. It appears the bug was introduced by this commit: https://projects.blender.org/blender/blender/commit/cd74ba6413161169c98d006c5cbcc7cc31f2ff94 Each groups weight was previously stored in a loop-local variable (`dw->weight`) when passed to the drawing function but they are now stored in a shared, non-loop-local variable (`tfp->active_vertex_weight`). This causes each loop iteration to clobber the weight set by the last iteration, resulting in the final iteration's weight being displayed for all groups. At least, that is what I think I'm seeing. I don't know what language this is so I don't know how to try testing my hypothesis. **Exact steps for others to reproduce the error** The attached .blend has a default cube with four weight groups and reproduces the error in 3.6.2. To reproduce in any file, select one vertex on any weight painted model and view the vertex group weights in the item panel in edit mode. The weight of each vertex group will be displayed as identical to the final groups' weight.
Robert-MacDavid added the
Type
Report
Priority
Normal
Status
Needs Triage
labels 2023-08-19 22:40:46 +02:00
Robert-MacDavid changed title from Item panel displays all vertex weights for active vertex as identical to Item panel displays incorrect weights for active vertex 2023-08-20 02:51:48 +02:00
Member

Duplicate of #111273

Closing

Duplicate of https://projects.blender.org/blender/blender/issues/111273 Closing
Blender Bot added
Status
Archived
and removed
Status
Needs Triage
labels 2023-08-20 03:34:00 +02:00
Member

For reference, was caused by cd74ba6413

For reference, was caused by cd74ba6413161169c98d006c5cbcc7cc31f2ff94
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111306
No description provided.