GPU Codegen parser warning #111353

New Issue

Charlie Jolly · 2023-08-21T18:06:42+02:00

Charlie Jolly commented

2023-08-21 18:06:42 +02:00

I'm working on a patch for Gabor Noise: #110802

@OmarEmaraDev suggested opening a bug report.

The function below has to be written with a return type rather than void.

Using void generates the following gpu_codegen parser warning. Unknown parameter type "GaborParams"

void gabor_sample(
    GaborParams gp, float orand, float orand2, float prand, out vec3 omega, out float phi)

As a workaround I have written the function with a return type of GaborParams which solves the issue.

GaborParams is a struct of floats.

GaborParams gabor_sample(
    GaborParams gp, float orand, float orand2, float prand, out vec3 omega, out float phi)
{
  float pvar = mix(0.0, prand * 2.0 - 1.0, gp.phase_variance);
  phi = M_2PI * pvar + gp.phase;

  /* Anisotropic direction. */
  if (gp.anisotropic == 1) {
    omega = gp.direction;
  }
  else { /* Isotropic. */
    float ovar = M_PI * (orand * 2.0 - 1.0);
    float omega_t = ovar * gp.rot_variance - gp.rotation;
    float cos_omega_p = 1.0 - 2.0 * orand2;
    float sin_omega_p = sqrt(1.0 - cos_omega_p * cos_omega_p);
    float sin_omega_t = sin(omega_t);
    float cos_omega_t = cos(omega_t);
    omega = normalize(vec3(cos_omega_t * sin_omega_p, sin_omega_t * sin_omega_p, cos_omega_p));
  }
  /* Return GaborParams to workaround gpu_codegen parser warning when return type is set to void :
   * Unknown parameter type "GaborParams". */
  return gp;
}

I'm working on a patch for Gabor Noise: https://projects.blender.org/blender/blender/pulls/110802 @OmarEmaraDev suggested opening a bug report. The function below has to be written with a return type rather than void. Using `void` generates the following gpu_codegen parser warning. `Unknown parameter type "GaborParams"` ``` void gabor_sample( GaborParams gp, float orand, float orand2, float prand, out vec3 omega, out float phi) ``` As a workaround I have written the function with a return type of `GaborParams` which solves the issue. `GaborParams` is a struct of floats. ``` GaborParams gabor_sample( GaborParams gp, float orand, float orand2, float prand, out vec3 omega, out float phi) { float pvar = mix(0.0, prand * 2.0 - 1.0, gp.phase_variance); phi = M_2PI * pvar + gp.phase; /* Anisotropic direction. */ if (gp.anisotropic == 1) { omega = gp.direction; } else { /* Isotropic. */ float ovar = M_PI * (orand * 2.0 - 1.0); float omega_t = ovar * gp.rot_variance - gp.rotation; float cos_omega_p = 1.0 - 2.0 * orand2; float sin_omega_p = sqrt(1.0 - cos_omega_p * cos_omega_p); float sin_omega_t = sin(omega_t); float cos_omega_t = cos(omega_t); omega = normalize(vec3(cos_omega_t * sin_omega_p, sin_omega_t * sin_omega_p, cos_omega_p)); } /* Return GaborParams to workaround gpu_codegen parser warning when return type is set to void : * Unknown parameter type "GaborParams". */ return gp; } ```

Charlie Jolly added the

labels 2023-08-21 18:06:42 +02:00

Clément Foucault was assigned by Charlie Jolly

2023-08-21 18:06:43 +02:00

Clément Foucault commented

2023-08-21 18:32:13 +02:00

This is a problem in our codegen parsing code. Every function with void return type it parsed as potential GPUFunction.

This could be fixed by using a custom keyword as return type to tag functions to be parsed as GPUFunction.

This is a problem in our codegen parsing code. Every function with `void` return type it parsed as potential `GPUFunction`. This could be fixed by using a custom keyword as return type to tag functions to be parsed as `GPUFunction`.

👍 1

Clément Foucault removed their assignment 2023-08-21 18:41:02 +02:00

Germano Cavalcante commented

2023-08-21 23:48:07 +02:00

This is a problem in our codegen parsing code. (...)

Seems a known issue then? So I'll confirm the report and set it as Known Issue.

However this issue seems to qualify as a build issue. And build issues are off-topic on the bug tracker as explained by the submission form.

First time reporting? See tips.

For feature requests, feedback, questions or issues building Blender, see communication channels.

In these cases we recommend asking on blender.chat or DevTalk.

> This is a problem in our codegen parsing code. (...) Seems a known issue then? So I'll confirm the report and set it as `Known Issue`. However this issue seems to qualify as a build issue. And build issues are off-topic on the bug tracker as explained by the [submission form](https://projects.blender.org/blender/blender/issues/new?template=.gitea%2fissue_template%2fbug.yaml). > **First time reporting? See tips.** > - For feature requests, feedback, questions or issues building Blender, see [communication channels](https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests). In these cases we recommend asking on [blender.chat](https://blender.chat/channel/blender-coders) or [DevTalk](https://devtalk.blender.org/c/blender).

Germano Cavalcante added

and removed