Error deleting an object with shape keys #111905

New Issue

RedMser · 2023-09-03T23:46:47+02:00

RedMser commented

2023-09-03 23:46:47 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.68

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-30 10:37, hash: e071288ab290
Worked: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-10 03:47, hash: 4ad63687cbc4

Short description of error
I made a custom Blender build to create a repro for another bug. But I stumbled upon a new bug by accident?

Deleting an object with shape keys shows an error in the GUI and console:

Read blend: "C:\Users\VRLand\Desktop\lib\lib.blend"
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.001 (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACKeyAction (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.002 (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.001 (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACKeyAction (from '[Main]'): 0 <= 0
ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.002 (from '[Main]'): 0 <= 0
Error: Shapekey KEKey.001 has an invalid 'from' pointer (0000000000000000), it will be deleted
Error: Shapekey KEKey.002 has an invalid 'from' pointer (0000000000000000), it will be deleted

Exact steps for others to reproduce the error

Empty blend file
Create a cube with two shape keys (Basis and Key)
Delete the cube
Save and reload the file

lib.blend shows the error directly when loaded.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.68 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-30 10:37, hash: `e071288ab290` Worked: version: 4.0.0 Alpha, branch: main, commit date: 2023-08-10 03:47, hash: `4ad63687cbc4` **Short description of error** I made a custom Blender build to create a repro for another bug. But I stumbled upon a new bug by accident? Deleting an object with shape keys shows an error in the GUI and console: ``` Read blend: "C:\Users\VRLand\Desktop\lib\lib.blend" ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.001 (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACKeyAction (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.002 (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.001 (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACKeyAction (from '[Main]'): 0 <= 0 ERROR (bke.lib_id): E:\blender-src\blender\source\blender\blenkernel\intern\lib_id.cc:337 id_us_min: ID user decrement error: ACAction.002 (from '[Main]'): 0 <= 0 Error: Shapekey KEKey.001 has an invalid 'from' pointer (0000000000000000), it will be deleted Error: Shapekey KEKey.002 has an invalid 'from' pointer (0000000000000000), it will be deleted ``` **Exact steps for others to reproduce the error** - Empty blend file - Create a cube with two shape keys (Basis and Key) - Delete the cube - Save and reload the file lib.blend shows the error directly when loaded.

lib.blend

974 KiB

RedMser added the

labels 2023-09-03 23:46:47 +02:00

YimingWu commented

2023-09-04 08:38:56 +02:00

Yepp can confirm. Will bisect.

Yepp can confirm. Will bisect. ![图片](/attachments/f5402bb9-ce69-4372-8246-6e25843227fe)

图片.png

5.7 KiB

YimingWu added

and removed

labels 2023-09-04 08:39:14 +02:00

YimingWu commented

2023-09-04 11:04:08 +02:00

Failed to bisect this one, here all good up to e071288ab2 which makes no sense...

Can't seem to use New > General > Add Shape Keys > Save > Revert, probably needs to reopen blender to read the file?

Failed to bisect this one, here all good up to e071288ab2901f43a5cde82a4 which makes no sense... Can't seem to use `New > General > Add Shape Keys > Save > Revert`, probably needs to reopen blender to read the file?

Philipp Oeser commented

2023-09-04 14:35:10 +02:00

My bisect points to 47672bd06a

This however only added this error to the user visible reports, the same error can be reproduced in - at least down to - 3.3 LTS (here only on the commandline though) as well

My bisect points to 47672bd06a4c1092cef5576ff4b865ddd96a6619 This however only added this error to the user visible reports, the same error can be reproduced in - at least down to - 3.3 LTS (here only on the commandline though) as well

Philipp Oeser commented

2023-09-04 14:36:21 +02:00

@mont29 might still know more here

Bastien Montagne commented

2023-09-04 14:52:17 +02:00

This commit merely reveals the issue I think, will investigate further to try to understand what is actually happening here.

Bastien Montagne commented

2023-09-04 15:04:21 +02:00

Hmppffff... this is... annoying, but not really a bug, in that code is behaving as expected:
*Deleting the object make the obdata (the mesh) unused, so it's not written in the .blend file
*However, since the mesh still exist, the shapekey data is still used, hence written to the .blend file.
So on next load, blend file has shapekeys with no associated geometry...

Will check if this can be quickly addressed for this special case, otherwise it will fall under the known TODO/design task of data handling around file saving, see #61209 and #87490.

Hmppffff... this is... annoying, but not really a bug, in that code is behaving as expected: *Deleting the object make the obdata (the mesh) unused, so it's not written in the .blend file *However, since the mesh still exist, the shapekey data is still used, hence written to the .blend file. So on next load, blend file has shapekeys with no associated geometry... Will check if this can be quickly addressed for this special case, otherwise it will fall under the known TODO/design task of data handling around file saving, see #61209 and #87490.

👀 1

YimingWu commented

2023-09-04 15:39:15 +02:00

@mont29 I guess this explains the behaviour when I use File > Revert it won't prompt me the error (since the data still exists in the memory)?

@mont29 I guess this explains the behaviour when I use `File > Revert` it won't prompt me the error (since the data still exists in the memory)?

Bastien Montagne commented

2023-09-04 15:49:22 +02:00

@ChengduLittleA not sure what you mean? File > Revert merely re-read current loaded file from disk...

@ChengduLittleA not sure what you mean? `File > Revert` merely re-read current loaded file from disk...

YimingWu commented

2023-09-04 15:58:37 +02:00

@mont29 yeah, I save the file after deleting the object with shape key, then revert, it never gives me this error this way, unless I reopen blender it will show the "invalid 'from' pointer".

Bastien Montagne referenced this issue from a commit

2023-09-04 16:14:29 +02:00

Fix #111905: Filewrite: Do not write ShapeKeys of unused geometry.

Bastien Montagne closed this issue

2023-09-04 16:14:30 +02:00

Blender Bot added

and removed

labels 2023-09-04 16:14:32 +02:00