blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 759 Projects 19 Wiki Activity

Geometry disappearing when using simulation zone #111978

New Issue
Closed
opened 2023-09-05 15:47:19 +02:00 by MKRelax · 7 comments
MKRelax commented 2023-09-05 15:47:19 +02:00
Copy Link

System Information
Operating system: Windows 10
Graphics card: NVidia RTX 3080Ti

Blender Version
Broken: 3.6.2 and also blender-3.6.3-candidate+v36.2fc04eaf4310-windows.amd64-release
Worked: blender-4.0.0-alpha+main.9f8d062de4e6-windows.amd64-release

Geometry randomly dissappears when using a Simulation Zone (even when empty).
This bug is present in 3.6.3 but is seems to have been fixed in 4.0. It would be great if that fix could be backported to 3.6, although it seems to be part of bigger changes.

Exact steps for others to reproduce the error

  1. Use default cube (or a plane or loose vertices).
  2. Add Geometry Nodes with only an empty Simulation Zone in it.
  3. Set end_frame to 100000 and scrub through the timeline.
  4. The geometry disappears after some scrubbing over longer distances (like 1000 or 500 frames).
  5. Turning off Simulation Nodes -> Cache seems to worsen the problem.
**System Information** Operating system: Windows 10 Graphics card: NVidia RTX 3080Ti **Blender Version** Broken: 3.6.2 and also blender-3.6.3-candidate+v36.2fc04eaf4310-windows.amd64-release Worked: blender-4.0.0-alpha+main.9f8d062de4e6-windows.amd64-release Geometry randomly dissappears when using a Simulation Zone (even when empty). This bug is present in 3.6.3 but is seems to have been fixed in 4.0. It would be great if that fix could be backported to 3.6, although it seems to be part of bigger changes. **Exact steps for others to reproduce the error** 1. Use default cube (or a plane or loose vertices). 2. Add Geometry Nodes with only an empty Simulation Zone in it. 3. Set end_frame to 100000 and scrub through the timeline. 4. The geometry disappears after some scrubbing over longer distances (like 1000 or 500 frames). 5. Turning off Simulation Nodes -> Cache seems to worsen the problem.
simulation-zone-bug.blend
762 KiB
👀 1
MKRelax added the
Priority
Normal
Type
Report
Status
Needs Triage
 labels 2023-09-05 15:47:20 +02:00
MKRelax commented 2023-09-05 18:25:05 +02:00
Author
Copy Link

Demo video. This happens when scrubbing the timeline, but also during normal viewport playback, especially in heavy scenes (probably due to skipping frames). When the same Node setup is repeated in the scene, they tend to break at the same frame, but not always (as shown).
Since clearing the cache makes the problem disappear (only to re-appear at a different frame), this is probably a caching problem. As said, this seems to have been solved in 4.0, I'm hoping to backport this to 3.6.

Demo video. This happens when scrubbing the timeline, but also during normal viewport playback, especially in heavy scenes (probably due to skipping frames). When the same Node setup is repeated in the scene, they tend to break at the same frame, but not always (as shown). Since clearing the cache makes the problem disappear (only to re-appear at a different frame), this is probably a caching problem. As said, this seems to have been solved in 4.0, I'm hoping to backport this to 3.6.
simulation-zone-bug.blend.mp4
14 MiB
Iliya Katushenock commented 2023-09-05 19:50:19 +02:00
Member
Copy Link

Implementation of the Simulation Nodes is radically different in 4.0 and 3.6, so this was not a separate fix, but a radical rework. I do not think that such a point fix via backport is possible.

Implementation of the Simulation Nodes is radically different in 4.0 and 3.6, so this was not a separate fix, but a radical rework. I do not think that such a point fix via backport is possible.
Iliya Katushenock added the
Interest
Geometry Nodes
Interest
Nodes & Physics
 labels 2023-09-05 19:50:27 +02:00
Pratik Borhade commented 2023-09-06 04:44:07 +02:00
Member
Copy Link

Hi, thanks for the report. I can confirm.
Should work in 3.6. I'll bisect to ensure the resolving commit.

Hi, thanks for the report. I can confirm. Should work in 3.6. I'll bisect to ensure the resolving commit.
👍 1
Pratik Borhade added this to the 3.6 LTS milestone 2023-09-06 04:44:33 +02:00
MKRelax commented 2023-09-06 23:25:45 +02:00
Author
Copy Link

Thank you @PratikPB2123 for adding this to the 3.6 LTS milestone!
To save you time, I have disected myself and found that this commit fixed it for 4.0:

81096abe2a3929c5e02e8d8c697a9571079fe0ef is the first new commit
commit 81096abe2a3929c5e02e8d8c697a9571079fe0ef
Author: Jacques Lucke <jacques@blender.org>
Date:   Fri Aug 4 19:34:35 2023 +0200

    Fix: simulation outputs empty geometry when going to frame zero

    Previously, simulation nodes would output default values when there is no
    current simulation state and nothing should be computed. Now, the data is
    just passed through which is usually less confusing.

    Pull Request: https://projects.blender.org/blender/blender/pulls/110800

 .../geometry/nodes/node_geo_simulation_input.cc    | 44 ++++++++++++----------
 .../geometry/nodes/node_geo_simulation_output.cc   | 24 ++++++++++--
 2 files changed, 45 insertions(+), 23 deletions(-)

I'm not a C++ developer and have not tried to backport this to 3.6 branch yet, but it seems doable at first glance.

It would be great to backport/reimplement this for 3.6 since that is an LTS version and this bug potentially impacts many, if not all, simulation node setups. Thanks again.

Thank you @PratikPB2123 for adding this to the 3.6 LTS milestone! To save you time, I have disected myself and found that this commit fixed it for 4.0: ``` 81096abe2a3929c5e02e8d8c697a9571079fe0ef is the first new commit commit 81096abe2a3929c5e02e8d8c697a9571079fe0ef Author: Jacques Lucke <jacques@blender.org> Date: Fri Aug 4 19:34:35 2023 +0200 Fix: simulation outputs empty geometry when going to frame zero Previously, simulation nodes would output default values when there is no current simulation state and nothing should be computed. Now, the data is just passed through which is usually less confusing. Pull Request: https://projects.blender.org/blender/blender/pulls/110800 .../geometry/nodes/node_geo_simulation_input.cc | 44 ++++++++++++---------- .../geometry/nodes/node_geo_simulation_output.cc | 24 ++++++++++-- 2 files changed, 45 insertions(+), 23 deletions(-) ``` I'm not a C++ developer and have not tried to backport this to 3.6 branch yet, but it seems doable at first glance. It would be great to backport/reimplement this for 3.6 since that is an LTS version and this bug potentially impacts many, if not all, simulation node setups. Thanks again.
Pratik Borhade commented 2023-09-07 05:38:08 +02:00
Member
Copy Link

Thanks @MKRelax :D

@JacquesLucke , can we backport your commit to 3.6? It haven't introduced any new bug yet (no references at least)

Thanks @MKRelax :D @JacquesLucke , can we backport your commit to 3.6? It haven't introduced any new bug yet (no references at least)
MKRelax commented 2023-09-08 00:50:20 +02:00
Author
Copy Link

I honestly didn't know the difference between a "pointer" and a "reference" until today and I don't have a clue what the code does, but I managed to backport this to 3.6. Solves it for me, but needs a code review (preferably from @JacquesLucke) before merging.

After applying this patch I still ran into (similar) problems in 3.6. But they turn out to be present in 4.0 as well and were not introduced by the commit that was backported. See #112094.

I honestly didn't know the difference between a "pointer" and a "reference" until today and I don't have a clue what the code does, but I managed to backport this to 3.6. Solves it for me, but needs a code review (preferably from @JacquesLucke) before merging. After applying this patch I still ran into (similar) problems in 3.6. But they turn out to be present in 4.0 as well and were not introduced by the commit that was backported. See #112094.
MKRelax commented 2023-09-15 10:20:25 +02:00
Author
Copy Link

Commit e55ca270e2 (to repair a failed assertion in 3.6) also fixes this. There is no more need to backport the 4.0 commit.

Commit https://projects.blender.org/blender/blender/commit/e55ca270e2c37ebbfd09858ba9ec36e9a5361b37 (to repair a failed assertion in 3.6) also fixes this. There is no more need to backport the 4.0 commit.
Blender Bot added
Status
Archived
 and removed
Status
Confirmed
 labels 2023-09-15 10:20:31 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
partial-write-refactor
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
3.6 LTS
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111978
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?